LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] x86_64: Fix preprocessor condition
@ 2007-01-16  9:44 Josef 'Jeff' Sipek
  0 siblings, 0 replies; 4+ messages in thread
From: Josef 'Jeff' Sipek @ 2007-01-16  9:44 UTC (permalink / raw)
  To: linux-kernel; +Cc: akpm, Josef 'Jeff' Sipek

Signed-off-by: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
---
 include/asm-x86_64/io.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-x86_64/io.h b/include/asm-x86_64/io.h
index 6ee9fad..7d0b568 100644
--- a/include/asm-x86_64/io.h
+++ b/include/asm-x86_64/io.h
@@ -100,7 +100,7 @@ __OUTS(l)
 
 #define IO_SPACE_LIMIT 0xffff
 
-#if defined(__KERNEL__) && __x86_64__
+#if defined(__KERNEL__) && defined(__x86_64__)
 
 #include <linux/vmalloc.h>
 
-- 
1.5.0.rc1.g696b


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] x86_64: Fix preprocessor condition
  2007-01-31 17:16   ` Andi Kleen
@ 2007-01-31 17:40     ` Josef Sipek
  0 siblings, 0 replies; 4+ messages in thread
From: Josef Sipek @ 2007-01-31 17:40 UTC (permalink / raw)
  To: Andi Kleen; +Cc: Josef 'Jeff' Sipek, linux-kernel, torvalds

On Wed, Jan 31, 2007 at 06:16:02PM +0100, Andi Kleen wrote:
> 
> > -#if defined(__KERNEL__) && __x86_64__
> > +#if defined(__KERNEL__) && defined(__x86_64__)
> 
> Undefined symbols are replaced with 0, so the old line was already ok.

Fair enough, however sparse is not very happy about underfined symbols.

Jeff.

-- 
Reality is merely an illusion, albeit a very persistent one.
		- Albert Einstein

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] x86_64: Fix preprocessor condition
  2007-01-31 17:11 ` [PATCH] x86_64: Fix preprocessor condition Josef 'Jeff' Sipek
@ 2007-01-31 17:16   ` Andi Kleen
  2007-01-31 17:40     ` Josef Sipek
  0 siblings, 1 reply; 4+ messages in thread
From: Andi Kleen @ 2007-01-31 17:16 UTC (permalink / raw)
  To: Josef 'Jeff' Sipek; +Cc: linux-kernel, torvalds


> -#if defined(__KERNEL__) && __x86_64__
> +#if defined(__KERNEL__) && defined(__x86_64__)

Undefined symbols are replaced with 0, so the old line was already ok.
	
-Andi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] x86_64: Fix preprocessor condition
  2007-01-31  4:28 Linux 2.6.20-rc7 Linus Torvalds
@ 2007-01-31 17:11 ` Josef 'Jeff' Sipek
  2007-01-31 17:16   ` Andi Kleen
  0 siblings, 1 reply; 4+ messages in thread
From: Josef 'Jeff' Sipek @ 2007-01-31 17:11 UTC (permalink / raw)
  To: linux-kernel; +Cc: torvalds, ak, Josef 'Jeff' Sipek

Signed-off-by: Josef 'Jeff' Sipek <jsipek@cs.sunysb.edu>
---
 include/asm-x86_64/io.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-x86_64/io.h b/include/asm-x86_64/io.h
index 6ee9fad..7d0b568 100644
--- a/include/asm-x86_64/io.h
+++ b/include/asm-x86_64/io.h
@@ -100,7 +100,7 @@ __OUTS(l)
 
 #define IO_SPACE_LIMIT 0xffff
 
-#if defined(__KERNEL__) && __x86_64__
+#if defined(__KERNEL__) && defined(__x86_64__)
 
 #include <linux/vmalloc.h>
 
-- 
1.5.0.rc1.g5355


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-01-31 17:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-16  9:44 [PATCH] x86_64: Fix preprocessor condition Josef 'Jeff' Sipek
2007-01-31  4:28 Linux 2.6.20-rc7 Linus Torvalds
2007-01-31 17:11 ` [PATCH] x86_64: Fix preprocessor condition Josef 'Jeff' Sipek
2007-01-31 17:16   ` Andi Kleen
2007-01-31 17:40     ` Josef Sipek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).