LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Piet Delaney <piet@bluelane.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Piet Delaney <piet@bluelane.com>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	Chris Wright <chrisw@sous-sol.org>,
	dm-crypt@saout.de, Andrey <dm-crypt-revealed-address@lelik.org>,
	Jens Axboe <jens.axboe@oracle.com>,
	agk@redhat.com
Subject: Re: [dm-devel] [stable][PATCH < 2.6.19] Fix data corruption with dm-crypt over RAID5
Date: Wed, 17 Jan 2007 00:44:08 -0800	[thread overview]
Message-ID: <1169023448.10964.244.camel@piet2.bluelane.com> (raw)
In-Reply-To: <1165026476.29307.23.camel@leto.intern.saout.de>

[-- Attachment #1: Type: text/plain, Size: 2183 bytes --]

On Sat, 2006-12-02 at 03:27 +0100, Christophe Saout wrote:

Hi Christophe:

I'm wondering about trying out your patch with dm-crypt on 2.6.12. 
The code in drivers/md/dm-crypt.c`crypt_endio() appears to be the same.

Is there a reason that this isn't necessary or would be a bad idea.
Looks like the existing code isn't checking the BIO_UPTODATE flag
before doing the bio_put(). Looks the the second part of not calling
kcryptd_queue_io() and forwarding the processing to the cryptd is
effectively the same. The 1st change will set error if BIO_UPTODATE
isn't set and that will cause the 2nd change to skip calling 
kcryptd_queue_io().

I'm not sure about the change in the arg to bio_data_dir() 
changing from bio to io->bio. Perhaps they are equivalent;
care to comment on that.

Unless I hear otherwise I'll try it out Tomorrow.

-piet

> Fix corruption issue with dm-crypt on top of software raid5. Cancelled
> readahead bio's that report no error, just have BIO_UPTODATE cleared
> were reported as successful reads to the higher layers (and leaving
> random content in the buffer cache). Already fixed in 2.6.19.
> 
> Signed-off-by: Christophe Saout <christophe@saout.de>
> 
> 
> --- linux-2.6.18.orig/drivers/md/dm-crypt.c	2006-09-20 05:42:06.000000000 +0200
> +++ linux-2.6.18/drivers/md/dm-crypt.c	2006-12-02 03:03:36.000000000 +0100
> @@ -717,13 +717,15 @@
>  	if (bio->bi_size)
>  		return 1;
>  
> +	if (!bio_flagged(bio, BIO_UPTODATE) && !error)
> +		error = -EIO;
> +                        
>  	bio_put(bio);
>  
>  	/*
>  	 * successful reads are decrypted by the worker thread
>  	 */
> -	if ((bio_data_dir(bio) == READ)
> -	    && bio_flagged(bio, BIO_UPTODATE)) {
> +	if (bio_data_dir(io->bio) == READ && !error) {
>  		kcryptd_queue_io(io);
>  		return 0;
>  	}
> 
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
-- 
Piet Delaney                                    Phone: (408) 200-5256
Blue Lane Technologies                          Fax:   (408) 200-5299
10450 Bubb Rd.
Cupertino, Ca. 95014                            Email: piet@bluelane.com

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2007-01-17  8:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <456B732F.6080906@lelik.org>
     [not found] ` <20061129145208.GQ4409@agk.surrey.redhat.com>
     [not found]   ` <456F46E3.6030702@lelik.org>
     [not found]     ` <1164983209.24524.20.camel@leto.intern.saout.de>
     [not found]       ` <20061201152143.GE4409@agk.surrey.redhat.com>
     [not found]         ` <45704B95.3020308@lelik.org>
     [not found]           ` <1165026116.29307.18.camel@leto.intern.saout.de>
2006-12-02  2:27             ` Christophe Saout
2006-12-02  3:49               ` Chris Wright
2006-12-02 11:00                 ` Christophe Saout
2007-01-17  8:44               ` Piet Delaney [this message]
2007-02-23  2:49               ` Piet Delaney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1169023448.10964.244.camel@piet2.bluelane.com \
    --to=piet@bluelane.com \
    --cc=agk@redhat.com \
    --cc=akpm@osdl.org \
    --cc=chrisw@sous-sol.org \
    --cc=dm-crypt-revealed-address@lelik.org \
    --cc=dm-crypt@saout.de \
    --cc=dm-devel@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [dm-devel] [stable][PATCH < 2.6.19] Fix data corruption with dm-crypt over RAID5' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).