LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Cedric Le Goater <clg@fr.ibm.com>,
	Oleg Nesterov <oleg@tv-sign.ru>,
	Daniel Hokka Zakrisson <daniel@hozac.com>,
	linux-kernel@vger.kernel.org, herbert@13thfloor.at,
	akpm@osdl.org, Linux Containers <containers@lists.osdl.org>
Subject: Re: NFS causing oops when freeing namespace
Date: Wed, 17 Jan 2007 17:46:42 -0500	[thread overview]
Message-ID: <1169074003.6523.15.camel@lade.trondhjem.org> (raw)
In-Reply-To: <m1d55d8ex3.fsf@ebiederm.dsl.xmission.com>

On Wed, 2007-01-17 at 15:30 -0700, Eric W. Biederman wrote:
> Cedric Le Goater <clg@fr.ibm.com> writes:
> >
> > your first analysis was correct : exit_task_namespaces() should be moved 
> > above exit_notify(tsk). It will require some extra fixes for nsproxy 
> > though.
> 
> I think the only issue is the child_reaper and currently we only have one of
> those.  When we really do the pid namespace we are going to have to revisit
> this.  My gut feel says that we won't be able to exit our pid namespace until
> the process is waited on.  So we may need to break up exit_task_namespace into
> individual components.

It makes little sense, afaics, to have an interruptible sleep in
something like lockd_down() if you have no pid space or signal handling.

That isn't the only place where the process has to wait in an NFS
unmount, BTW. Things like rpc client cleanup (waiting for all the RPC
tasks to complete) also tend to lead to interruptible sleeps.

Trond


  reply	other threads:[~2007-01-17 22:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-17 10:28 Daniel Hokka Zakrisson
2007-01-17 12:44 ` Eric W. Biederman
2007-01-17 13:13   ` Daniel Hokka Zakrisson
2007-01-17 18:58     ` Oleg Nesterov
2007-01-17 19:20       ` Cedric Le Goater
2007-01-17 19:46         ` Oleg Nesterov
2007-01-17 20:31           ` Cedric Le Goater
2007-01-17 22:30             ` Eric W. Biederman
2007-01-17 22:46               ` Trond Myklebust [this message]
2007-01-17 22:55               ` Oleg Nesterov
2007-01-18  4:46                 ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1169074003.6523.15.camel@lade.trondhjem.org \
    --to=trond.myklebust@fys.uio.no \
    --cc=akpm@osdl.org \
    --cc=clg@fr.ibm.com \
    --cc=containers@lists.osdl.org \
    --cc=daniel@hozac.com \
    --cc=ebiederm@xmission.com \
    --cc=herbert@13thfloor.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --subject='Re: NFS causing oops when freeing namespace' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).