LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Fix missing include of list.h in sysfs.h
@ 2007-01-17 16:51 Frank Haverkamp
  2007-01-17 21:14 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Frank Haverkamp @ 2007-01-17 16:51 UTC (permalink / raw)
  To: linux-kernel; +Cc: greg

Sysfs.h uses definitions (e.g. struct list_head s_sibling) from list.h
but does not include it.

Signed-off-by: Frank Haverkamp <haver@vnet.ibm.com>
---
 include/linux/sysfs.h |    1 +
 1 file changed, 1 insertion(+)

--- ubi-2.6.git.orig/include/linux/sysfs.h
+++ ubi-2.6.git/include/linux/sysfs.h
@@ -11,6 +11,7 @@
 #define _SYSFS_H_
 
 #include <linux/compiler.h>
+#include <linux/list.h>
 #include <asm/atomic.h>
 
 struct kobject;



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix missing include of list.h in sysfs.h
  2007-01-17 16:51 [PATCH] Fix missing include of list.h in sysfs.h Frank Haverkamp
@ 2007-01-17 21:14 ` Greg KH
  2007-01-18  8:25   ` Frank Haverkamp
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2007-01-17 21:14 UTC (permalink / raw)
  To: Frank Haverkamp; +Cc: linux-kernel

On Wed, Jan 17, 2007 at 05:51:18PM +0100, Frank Haverkamp wrote:
> Sysfs.h uses definitions (e.g. struct list_head s_sibling) from list.h
> but does not include it.
> 
> Signed-off-by: Frank Haverkamp <haver@vnet.ibm.com>
> ---
>  include/linux/sysfs.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- ubi-2.6.git.orig/include/linux/sysfs.h
> +++ ubi-2.6.git/include/linux/sysfs.h
> @@ -11,6 +11,7 @@
>  #define _SYSFS_H_
>  
>  #include <linux/compiler.h>
> +#include <linux/list.h>
>  #include <asm/atomic.h>

Does this currently cause a build error on any platform for 2.6.20-rc5?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix missing include of list.h in sysfs.h
  2007-01-17 21:14 ` Greg KH
@ 2007-01-18  8:25   ` Frank Haverkamp
  0 siblings, 0 replies; 3+ messages in thread
From: Frank Haverkamp @ 2007-01-18  8:25 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, Frank Haverkamp

Hi Greg,

On Wed, 2007-01-17 at 13:14 -0800, Greg KH wrote:

> Does this currently cause a build error on any platform for 2.6.20-rc5?

Not that I know of. I saw it because a friend of mine tried to port
some old code and played with the include ordering. Somehow he got
a compile error doing it, and we found that it is strange that sysfs.h
is using structs from list.h but is not including it. As result I sent
the patch to propose that it gets included to avoid any possible
trouble.

Frank


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-01-18  8:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-17 16:51 [PATCH] Fix missing include of list.h in sysfs.h Frank Haverkamp
2007-01-17 21:14 ` Greg KH
2007-01-18  8:25   ` Frank Haverkamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).