LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: Jens Axboe <jens.axboe@oracle.com>,
JFS Discussion <jfs-discussion@lists.sourceforge.net>,
fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging
Date: Thu, 18 Jan 2007 08:15:30 -0600 [thread overview]
Message-ID: <1169129730.7295.10.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <20070118063019.GA31164@filer.fsl.cs.sunysb.edu>
On Thu, 2007-01-18 at 01:30 -0500, Josef Sipek wrote:
> On Wed, Jan 17, 2007 at 04:55:49PM -0600, Dave Kleikamp wrote:
> > /*
> > * jfs_lock.h
> > @@ -42,6 +43,7 @@ do { \
> > if (cond) \
> > break; \
> > unlock_cmd; \
> > + blk_replug_current_nested(); \
> > schedule(); \
> > lock_cmd; \
> > } \
>
> Is {,un}lock_cmd a macro? ...
They are the commands passed into this macro (as arguments) to
release/take a lock. This is a home-grown wait_on_event type macro
where the condition must be checked while holding a lock. And the
commands passed in are themselves macros. The jfs code could probably
be cleaned up a bit as far as excessive use of macros for locking, but
it's been working for a few years with few problems.
--
David Kleikamp
IBM Linux Technology Center
prev parent reply other threads:[~2007-01-18 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 22:55 Dave Kleikamp
2007-01-17 23:18 ` Jens Axboe
2007-01-17 23:39 ` Dave Kleikamp
2007-01-17 23:46 ` Jens Axboe
2007-01-18 3:23 ` Dave Kleikamp
2007-01-18 6:30 ` Josef Sipek
2007-01-18 14:15 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1169129730.7295.10.camel@kleikamp.austin.ibm.com \
--to=shaggy@linux.vnet.ibm.com \
--cc=jens.axboe@oracle.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--subject='Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).