LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [RESEND][PATCH] 9p: fix bogus return code checks during initialization
@ 2007-01-18 20:14 Eric Van Hensbergen
0 siblings, 0 replies; only message in thread
From: Eric Van Hensbergen @ 2007-01-18 20:14 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, v9fs-developer, Eric Van Hensbergen
There is a simple logic error in init_v9fs - the return code checks are
reversed. This patch fixes the return code and adds some messages to
prevent module initialization from failing silently.
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
---
fs/9p/mux.c | 4 +++-
fs/9p/v9fs.c | 11 ++++++++---
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/fs/9p/mux.c b/fs/9p/mux.c
index 944273c..147ceef 100644
--- a/fs/9p/mux.c
+++ b/fs/9p/mux.c
@@ -132,8 +132,10 @@ int v9fs_mux_global_init(void)
v9fs_mux_poll_tasks[i].task = NULL;
v9fs_mux_wq = create_workqueue("v9fs");
- if (!v9fs_mux_wq)
+ if (!v9fs_mux_wq) {
+ printk(KERN_WARNING "v9fs: mux: creating workqueue failed\n");
return -ENOMEM;
+ }
return 0;
}
diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index 0b96fae..d9b561b 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -457,14 +457,19 @@ static int __init init_v9fs(void)
v9fs_error_init();
- printk(KERN_INFO "Installing v9fs 9P2000 file system support\n");
+ printk(KERN_INFO "Installing v9fs 9p2000 file system support\n");
ret = v9fs_mux_global_init();
- if (!ret)
+ if (ret) {
+ printk(KERN_WARNING "v9fs: starting mux failed\n");
return ret;
+ }
ret = register_filesystem(&v9fs_fs_type);
- if (!ret)
+ if (ret) {
+ printk(KERN_WARNING "v9fs: registering file system failed\n");
v9fs_mux_global_exit();
+ }
+
return ret;
}
--
1.5.0.rc1.gdf1b-dirty
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-01-18 20:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-18 20:14 [RESEND][PATCH] 9p: fix bogus return code checks during initialization Eric Van Hensbergen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).