LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Benjamin Romer <benjamin.romer@unisys.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: vgoyal@in.ibm.com, "Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org
Subject: Re: PATCH: Update disable_IO_APIC to use 8-bit destination field  (X86_64)
Date: Fri, 19 Jan 2007 12:14:13 -0500	[thread overview]
Message-ID: <1169226853.6467.16.camel@ustr-romerbm-2.na.uis.unisys.com> (raw)
In-Reply-To: <20070119074333.ae9d351b.rdunlap@xenotime.net>

On Fri, 2007-01-19 at 07:43 -0800, Randy Dunlap wrote:
> On Fri, 19 Jan 2007 10:11:10 -0500 Benjamin Romer wrote:
> 
> > On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote:
> > > On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote:
> > > [..]
> > > > > >
> > > > > > OK, here's the updated patch that uses the new definition and fixes up
> > > > > > the other places that use it. I built and tested this on the ES7000/ONE
> > > > > > and it works well. :)
> > > > >
> > > > > Cool.
> > > > >
> > > > > I hate to pick nits by why the double underscore on dest?
> > > > >
> > > > 
> > > > It was defined that way in the updated structure definition you sent in
> > > > a previous mail, so I figured you wanted it that way. Here's another
> > > > revision with the double underscores removed. :)
> > > > 
> > > > -- Ben
> > > > 
> > > 
> > > This patch looks good to me. You might want to provide some description
> > > too for changelog.
> > > 
> > > Thanks
> > > Vivek
> > 
> > A simple description would look something like:
> > 
> > - Updated 4-bit IO-APIC physical dest field to 8-bit dest field for
> > xAPIC; fixes ES7000/ONE kexec timer hang
> > 
> > Is there a changelog file in the kernel for kexec somewhere, or does
> > this belong in the source file's comments somewhere? I can fix up the
> > patch as soon as I know where the right spot for the description is. :)
> 
> We use a source code management system for changelogs. (git)
> 
> Patch comments (changelog info) go in the email at the top of the
> patch.  See Documentation/SubmittingPatches and
> http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
> and http://linux.yyz.us/patch-format.html for more info.
> 
> ---
> ~Randy

Thanks for the pointers! I've bookmarked them for future reference, and
sent a new patch that follows the guidelines. :)

-- Ben


  reply	other threads:[~2007-01-19 17:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-17 16:46 Benjamin Romer
2007-01-17 19:08 ` Eric W. Biederman
2007-01-18  3:41   ` Vivek Goyal
2007-01-18  4:36     ` Vivek Goyal
2007-01-18  7:10       ` Eric W. Biederman
     [not found]         ` <2 0070118080003.GC31860@in.ibm.com>
2007-01-18  8:00         ` Vivek Goyal
2007-01-18 14:58           ` Benjamin Romer
2007-01-18 17:23           ` Benjamin Romer
2007-01-18 18:14             ` Eric W. Biederman
     [not found]               ` <1169147619.6665. 11.camel@ustr-romerbm-2.na.uis.unisys.com>
2007-01-18 19:13               ` Benjamin Romer
2007-01-19  3:49                 ` Vivek Goyal
2007-01-19 15:11                   ` Benjamin Romer
2007-01-19 15:43                     ` Randy Dunlap
2007-01-19 17:14                       ` Benjamin Romer [this message]
2007-01-19 15:55                     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1169226853.6467.16.camel@ustr-romerbm-2.na.uis.unisys.com \
    --to=benjamin.romer@unisys.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=vgoyal@in.ibm.com \
    --subject='Re: PATCH: Update disable_IO_APIC to use 8-bit destination field  (X86_64)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).