LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Roger While <simrw@sim-basis.de>
Cc: linux-kernel@vger.kernel.org, airlied@linux.ie
Subject: Re: [PATCH] gpu/radeonfb: add GPU support to radeonfb
Date: Thu, 25 Jan 2007 08:54:08 +1100	[thread overview]
Message-ID: <1169675648.18754.92.camel@localhost.localdomain> (raw)
In-Reply-To: <6.1.1.1.2.20070124172600.04f40dc8@192.168.6.12>

On Wed, 2007-01-24 at 17:30 +0100, Roger While wrote:
> @@ -241,9 +241,9 @@ void radeonfb_engine_reset(struct radeon
>   	INREG(HOST_PATH_CNTL);
>   	OUTREG(HOST_PATH_CNTL, host_path_cntl);
> 
> -	if (rinfo->family != CHIP_FAMILY_R300 ||
> -	    rinfo->family != CHIP_FAMILY_R350 ||
> -	    rinfo->family != CHIP_FAMILY_RV350)
> +	if (rinfo->gpu_info->family != CHIP_FAMILY_R300 ||
> +	    rinfo->gpu_info->family != CHIP_FAMILY_R350 ||
> +	    rinfo->gpu_info->family != CHIP_FAMILY_RV350)
>   		OUTREG(RBBM_SOFT_RESET, rbbm_soft_reset);
> 
> Alarm bells going off - "!=" combined with "||" ?
> Looks like a reset will always be done.

Wow, good catch ! That's a bug that has been in radeonfb pretty much for
ever ! Might have come from earlier versions of X before we had
IS_R300_VARIANT...

B


  reply	other threads:[~2007-01-24 21:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-24 16:30 Roger While
2007-01-24 21:54 ` Benjamin Herrenschmidt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-01-24 11:20 gpu sharing layer for kernel airlied
2007-01-24 11:20 ` [PATCH] gpu: Initial gpu layer addition airlied
2007-01-24 11:20   ` [PATCH] gpu/radeon: add a radeon lowlevel GPU driver airlied
2007-01-24 11:20     ` [PATCH] gpu/radeonfb: add GPU support to radeonfb airlied
2007-01-25  0:07       ` Benjamin Herrenschmidt
2007-01-30 19:50         ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1169675648.18754.92.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=airlied@linux.ie \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simrw@sim-basis.de \
    --subject='Re: [PATCH] gpu/radeonfb: add GPU support to radeonfb' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).