LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Neil Brown <neilb@suse.de>
Cc: Jesper Juhl <jesper.juhl@gmail.com>,
	nfs@lists.sourceforge.net,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [NFS] 2.6.17.8 - do_vfs_lock: VFS is out of sync with lock manager!
Date: Mon, 29 Jan 2007 09:16:50 -0500	[thread overview]
Message-ID: <1170080210.5757.6.camel@lade.trondhjem.org> (raw)
In-Reply-To: <17853.33116.113629.65031@notabene.brown>

On Mon, 2007-01-29 at 16:08 +1100, Neil Brown wrote:
> On Monday August 21, trond.myklebust@fys.uio.no wrote:
> > 
> > Could we instead replace it with a dprintk() that returns the value of
> > "res"? That will keep it useful for debugging purposes.
> 
> (only 5 months later...)
> 
> Sure, how about this?
> 
> Thanks,
> NeilBrown

ACKed.

Thanks Neil!

Trond

> 
> Remove warning: VFS is out of sync with lock manager.
> 
> But keep it as a dprintk
> 
> The message can be generated in a quite normal situation:
>  If a 'lock' request is interrupted, then the lock client needs to
>   record that the server has the lock, incase it does.
>  When we come the unlock, the server might say it doesn't, even
>   though we think it does (or might) and this generates the message.
> 
> Signed-off-by: Neil Brown <neilb@suse.de>
> 
> ### Diffstat output
>  ./fs/nfs/file.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff .prev/fs/nfs/file.c ./fs/nfs/file.c
> --- .prev/fs/nfs/file.c	2007-01-29 16:04:09.000000000 +1100
> +++ ./fs/nfs/file.c	2007-01-29 16:04:45.000000000 +1100
> @@ -434,8 +434,9 @@ static int do_vfs_lock(struct file *file
>  			BUG();
>  	}
>  	if (res < 0)
> -		printk(KERN_WARNING "%s: VFS is out of sync with lock manager!\n",
> -				__FUNCTION__);
> +		dprintk(KERN_WARNING "%s: VFS is out of sync with lock manager"
> +			" - error %d!\n",
> +				__FUNCTION__, res);
>  	return res;
>  }
>  


  reply	other threads:[~2007-01-29 14:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-08 14:39 Jesper Juhl
2006-08-09  5:53 ` Grant Coady
2006-08-09  8:07   ` Jesper Juhl
2006-08-10 22:37     ` Jesper Juhl
2006-08-11  0:30       ` Grant Coady
2006-08-13 23:08       ` Grant Coady
2006-08-17  6:49 ` [NFS] " Neil Brown
2006-08-17  9:58   ` Jesper Juhl
2006-08-21  3:34     ` Neil Brown
2006-08-21 19:54       ` Trond Myklebust
2006-11-21 12:43         ` Jesper Juhl
2006-11-27  9:19           ` Jesper Juhl
2007-01-29  5:08         ` Neil Brown
2007-01-29 14:16           ` Trond Myklebust [this message]
2007-01-30 23:42             ` Jesper Juhl
2007-02-01 22:39               ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1170080210.5757.6.camel@lade.trondhjem.org \
    --to=trond.myklebust@fys.uio.no \
    --cc=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    --subject='Re: [NFS] 2.6.17.8 - do_vfs_lock: VFS is out of sync with lock manager'\!'' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).