From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030245AbXAaQgL (ORCPT ); Wed, 31 Jan 2007 11:36:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030248AbXAaQgL (ORCPT ); Wed, 31 Jan 2007 11:36:11 -0500 Received: from amsfep20-int.chello.nl ([62.179.120.15]:43306 "EHLO amsfep20-int.chello.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030245AbXAaQgK (ORCPT ); Wed, 31 Jan 2007 11:36:10 -0500 Subject: Re: [PATCH] atomic.h : standardizing atomic primitives From: Peter Zijlstra To: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton , Ingo Molnar , Greg Kroah-Hartman , Christoph Hellwig , ltt-dev@shafik.org, systemtap@sources.redhat.com, Douglas Niehaus , "Martin J. Bligh" , Thomas Gleixner In-Reply-To: <20070131162539.GA31985@Krystal> References: <11685657414033-git-send-email-mathieu.desnoyers@polymtl.ca> <1170257321.9516.42.camel@twins> <20070131162539.GA31985@Krystal> Content-Type: text/plain Date: Wed, 31 Jan 2007 17:36:03 +0100 Message-Id: <1170261363.9516.50.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2007-01-31 at 11:25 -0500, Mathieu Desnoyers wrote: > Hi Peter, > > Thanks for testing Andrew's fixes. I haven't actually taken any from him. I just started afresh. > I am wondering about what happened to > the Powerpc recursive include problems Andrew experienced. Quoting him : > > "OK, I fixed eight separate compile errors in this patch series and > now powerpc is being very ugly with a twisty maze of include > dependencies. > > I'm giving up. Someone should publish a suite of cross-compilers for us > so stuff like this doesn't need to happen." > > I see that you have removed the include from bitops.h and > system.h in powerpc. If it compiles on every architectures, then it's a > good approach. Yeah, I fiddled around with those powerpc headers a bit until it stopped whining. Maybe the powerpc folks ought to eyeball it a bit, but it build a kernel image here. > I planned to post a new patch which uses macros for cmpxchg and xchg in > asm-generic/atomic.h instead of inline functions. It would remove the > dependency on system.h. However, if your modifications work well on > every architecture, my fix might not be needed. Anyone has a preferred > solution ? I have not been able to setup my cross-compiler test bench > yet due to some hardware issues and waited for it before I released > further fixes, but if you want to try my macro-based fix, I could post > it. Whatever people want; inlines are generally preferred due to the extra type checking. I just needed atomic_long_cmpxchg to work so I kicked your patches about till they compiled. > And about the alpha build, Does the assembler errors also happen without > this patch ? Yes. Something fishy going on there... gcc-4.1.1 + binutils-2.17 Compiler seems to build fine, but kernel code makes it go belly up.