LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michal Ostrowski <mostrows@watson.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: paulus@samba.org, linuxppc-dev@ozlabs.org, olecom@flower.upol.cz,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: Kbuild change breaks the ppc64 build
Date: Thu, 08 Feb 2007 08:12:00 -0600	[thread overview]
Message-ID: <1170943920.15584.234.camel@kdsk1.austin.ibm.com> (raw)
In-Reply-To: <20070208.040003.112623191.davem@davemloft.net>

Isn't the extra space there because you've included it in the definition
of "test"?  The attempt at introducing indentation introduces the extra
space character.  Defining test without the internal indentation should
produce the results you are looking for.


-- 
Michal Ostrowski <mostrows@watson.ibm.com>


On Thu, 2007-02-08 at 04:00 -0800, David Miller wrote:

> For some reason $(call ...) invocations add spaces.  I tried
> another test case:
> 
> define test
>  $(shell echo -n)
> endef
> 
> VAR:=$(call test)
> 
> all:
> 	@echo "\'$(VAR)\'"
> 
> And this always prints:
> 
> ' TEST'
> 
> even with GNU Make version 3.81
> 
> If I put a $(strip ...) around the define, the space is
> still there.  If I put the $(strip ...) around VAR's
> $(call), the space goes away.



  parent reply	other threads:[~2007-02-08 14:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08 11:10 Paul Mackerras
2007-02-08 12:00 ` David Miller
2007-02-08 12:35   ` Oleg Verych
2007-02-08 14:12   ` Michal Ostrowski [this message]
2007-02-08 12:47 ` Oleg Verych
2007-02-08 13:17   ` David Miller
2007-02-08 13:45     ` final (Re: Kbuild change breaks the ppc64 build) Oleg Verych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1170943920.15584.234.camel@kdsk1.austin.ibm.com \
    --to=mostrows@watson.ibm.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olecom@flower.upol.cz \
    --cc=paulus@samba.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: Kbuild change breaks the ppc64 build' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).