LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Kai" <epimetreus@fastmail.fm>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: Bio device too big | kernel BUG at mm/filemap.c:537!
Date: Fri, 09 Feb 2007 09:15:49 -0800	[thread overview]
Message-ID: <1171041349.4099.1173808365@webmail.messagingengine.com> (raw)
In-Reply-To: <17866.19962.601479.638730@notabene.brown>


On Thu, 8 Feb 2007 09:08:58 +1100, "Neil Brown" <neilb@suse.de> said:
> On Wednesday February 7, epimetreus@fastmail.fm wrote:
> > 
> > On Wed, 7 Feb 2007 10:26:56 +1100, "Neil Brown" <neilb@suse.de> said:
> > > On Tuesday February 6, neilb@suse.de wrote:
> > > > 
> > > > This patch should fix the worst of the offences, but I'd like to
> > > > experiment and think a bit more before I submit it to stable.
> > > > And probably test it too - as yet I have only compile and brain
> > > > tested.
> > > 
> > > Ok, I've experimented and tested and now I know what was causing the
> > > double-unlock.
> > > 
> > > The following patch is suitable for 2.6.20.1 and mainline.  There is
> > > room for a bit more improvement, but only for performance, not
> > > correctness.  I'll look into that later.
> > > 
> > > Thanks,
> > > NeilBrown
> > 
> > I figure I should test this on my hardware, but since the RAID array
> > resynched itself when I rebooted back into an earlier kernel version,
> > I'm guessing it means this bug introduced some corruption into the
> > array, when it occurred, so I'd like some pointers on how I can test it
> > out without compromising my data.
> 
> This bug should not introduce any data corruption.
> It causes some read requests to get a failure from the device, which
> will cause raid5 to remove the device from the array (Though the data
> will still be intact).
> On restart a resync will put everything back as it was.
> 
> It is quite possible (this happened to me in my testing) for several
> devices to get these errors and for several or even all of these
> device to get failed.  However even in this case the data is still
> intact and "mdadm --assemble --force ..." will put everything back
> together.
> 
> So there should be no risk of data corruption.
> 
> NeilBrown

I've been running it for the last few hours, and no error output, yet; I
even did some fairly heavy I/O stuff to try and mess with it, but it
hasn't budged. I'm ready to say, works for me.

-Kai

  reply	other threads:[~2007-02-09 17:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06  4:08 Kai
2007-02-06  4:37 ` Andrew Morton
2007-02-06  5:24   ` Neil Brown
2007-02-06 23:26     ` [PATCH] " Neil Brown
2007-02-07  1:15       ` Andrew Morton
2007-02-07  1:30         ` Neil Brown
2007-02-07  1:40           ` Andrew Morton
2007-02-07 16:26       ` Kai
2007-02-07 22:08         ` Neil Brown
2007-02-09 17:15           ` Kai [this message]
2007-02-12  8:51       ` J.A. Magallón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1171041349.4099.1173808365@webmail.messagingengine.com \
    --to=epimetreus@fastmail.fm \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] Re: Bio device too big | kernel BUG at mm/filemap.c:537'\!'' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).