LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Len Brown <lenb@kernel.org>
Cc: James Morris <jmorris@namei.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@muc.de>,
virtualization <virtualization@lists.osdl.org>
Subject: [PATCH 11/10] lguest: use disable_acpi()
Date: Sat, 10 Feb 2007 10:48:08 +1100 [thread overview]
Message-ID: <1171064888.15356.14.camel@localhost.localdomain> (raw)
In-Reply-To: <200702091249.58204.lenb@kernel.org>
On Fri, 2007-02-09 at 12:49 -0500, Len Brown wrote:
> On Friday 09 February 2007 12:14, James Morris wrote:
> > This is being disabled in the guest kernel only. The host and guest
> > kernels are expected to be the same build.
>
> Okay, but better to use disable_acpi()
> indeed, since this would be the first code not already inside CONFIG_ACPI
> to invoke disable_acpi(), we could define the inline as empty and you could
> then scratch the #ifdef too.
Thanks Len!
This applies on top of that series.
==
Len Brown <lenb@kernel.org> said:
> Okay, but better to use disable_acpi()
> indeed, since this would be the first code not already inside CONFIG_ACPI
> to invoke disable_acpi(), we could define the inline as empty and you could
> then scratch the #ifdef too.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff -r 85363b87e20b arch/i386/lguest/lguest.c
--- a/arch/i386/lguest/lguest.c Sat Feb 10 01:52:37 2007 +1100
+++ b/arch/i386/lguest/lguest.c Sat Feb 10 10:28:36 2007 +1100
@@ -555,10 +555,7 @@ static __attribute_used__ __init void lg
mce_disabled = 1;
#endif
-#ifdef CONFIG_ACPI
- acpi_disabled = 1;
- acpi_ht = 0;
-#endif
+ disable_acpi();
if (boot->initrd_size) {
/* We stash this at top of memory. */
INITRD_START = boot->max_pfn*PAGE_SIZE - boot->initrd_size;
diff -r 85363b87e20b include/asm-i386/acpi.h
--- a/include/asm-i386/acpi.h Sat Feb 10 01:52:37 2007 +1100
+++ b/include/asm-i386/acpi.h Sat Feb 10 10:43:43 2007 +1100
@@ -127,6 +127,7 @@ extern int acpi_irq_balance_set(char *st
#define acpi_ioapic 0
static inline void acpi_noirq_set(void) { }
static inline void acpi_disable_pci(void) { }
+static inline void disable_acpi(void) { }
#endif /* !CONFIG_ACPI */
next prev parent reply other threads:[~2007-02-09 23:48 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 9:11 [PATCH 0/10] lguest Rusty Russell
2007-02-09 9:14 ` [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler Rusty Russell
2007-02-09 9:15 ` [PATCH 2/10] lguest: Export symbols for lguest as a module Rusty Russell
2007-02-09 9:32 ` Andi Kleen
2007-02-09 12:06 ` Rusty Russell
2007-02-09 13:58 ` Andi Kleen
2007-02-10 11:39 ` Rusty Russell
2007-02-09 9:17 ` [PATCH 3/10] lguest: Expose get_futex_key, get_key_refs and drop_key_refs Rusty Russell
2007-02-09 9:18 ` [PATCH 4/10] lguest: Initialize esp0 properly all the time Rusty Russell
2007-02-09 9:19 ` [PATCH 5/10] Make hvc_console.c compile on non-PowerPC Rusty Russell
[not found] ` <1171012827.2718.42.camel@localhost.localdomain>
2007-02-09 9:22 ` [PATCH 7/10] lguest: Simple lguest network driver Rusty Russell
2007-02-09 9:23 ` [PATCH 8/10] lguest: console driver Rusty Russell
2007-02-09 9:24 ` [PATCH 9/10] lguest: block driver Rusty Russell
2007-02-09 9:25 ` [PATCH 10/10] lguest: documentatation including example launcher Rusty Russell
2007-02-09 9:35 ` [PATCH 6/10] lguest code: the little linux hypervisor Andrew Morton
2007-02-09 11:00 ` Rusty Russell
2007-02-09 11:13 ` Zachary Amsden
2007-02-09 11:50 ` Andi Kleen
2007-02-09 11:54 ` Zachary Amsden
2007-02-09 11:57 ` Andi Kleen
2007-02-09 12:08 ` Zachary Amsden
2007-02-09 22:29 ` David Miller
2007-02-09 10:09 ` Andi Kleen
2007-02-09 12:39 ` Rusty Russell
2007-02-09 13:57 ` Andi Kleen
2007-02-09 15:01 ` Rusty Russell
2007-02-09 14:17 ` Sam Ravnborg
2007-02-09 15:23 ` Rusty Russell
2007-02-12 13:34 ` [q] kbuild for private asm-offsets (Re: [PATCH 6/10] lguest code: the little linux hypervisor.) Oleg Verych
2007-02-12 17:24 ` Andi Kleen
2007-02-12 21:41 ` Sam Ravnborg
2007-02-12 23:41 ` Rusty Russell
2007-02-13 3:10 ` Oleg Verych
2007-02-16 15:55 ` [pp] kbuild: lguest with private asm-offsets (and some bloat) Oleg Verych
2007-02-16 15:59 ` [pp] kbuild: asm-offsets generalized Oleg Verych
2007-02-16 18:56 ` Sam Ravnborg
2007-02-16 21:56 ` Oleg Verych
2007-02-17 4:43 ` Rusty Russell
2007-02-17 5:33 ` Oleg Verych
2007-04-01 20:42 ` Sam Ravnborg
2007-04-01 21:08 ` Oleg Verych
2007-04-01 21:03 ` Sam Ravnborg
2007-02-09 10:55 ` [PATCH 6a/10] lguest: Config and headers Rusty Russell
2007-02-09 10:56 ` [PATCH 6b/10] lguest: the host code (lg.ko) Rusty Russell
2007-02-09 10:57 ` [PATCH 6c/10] lguest: the guest code Rusty Russell
2007-02-09 10:58 ` [PATCH 6d/10] lguest: the Makefiles Rusty Russell
2007-02-09 17:06 ` [PATCH 6c/10] lguest: the guest code Len Brown
2007-02-09 17:14 ` James Morris
2007-02-09 17:49 ` Len Brown
2007-02-09 23:48 ` Rusty Russell [this message]
2007-02-09 9:31 ` [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler Andi Kleen
2007-02-09 11:52 ` Rusty Russell
2007-02-09 20:49 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1171064888.15356.14.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=jmorris@namei.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
--subject='Re: [PATCH 11/10] lguest: use disable_acpi()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).