LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Olivier Galibert <galibert@pobox.com>
Cc: "Hack inc." <linux-kernel@vger.kernel.org>, autofs@linux.kernel.org
Subject: Re: [PATCH 2/2] Re: [autofs] Bad race condition in the new autofs protocol somewhere
Date: Mon, 12 Feb 2007 15:46:40 +0900 [thread overview]
Message-ID: <1171262800.18376.16.camel@raven.themaw.net> (raw)
In-Reply-To: <1171262594.18376.13.camel@raven.themaw.net>
On Mon, 2007-02-12 at 15:43 +0900, Ian Kent wrote:
> On Thu, 2007-02-08 at 11:33 +0900, Ian Kent wrote:
> > On Wed, 2007-02-07 at 19:18 +0100, Olivier Galibert wrote:
> > > On Thu, Feb 08, 2007 at 03:07:41AM +0900, Ian Kent wrote:
> > > > It may be better to update to a later kernel so I don't have to port the
> > > > patch to several different kernels. Is that possible?
> > >
> > > Sure, 2.6.20 or -git?
> >
> > 2.6.20 has all the patches I've proposed so far except for the one we're
> > working on so that would be best for me.
> >
> > Seems there may still be a problem with the patch so I'll let you know
> > what's happening as soon as I can.
>
> I think I'm just about done.
>
> Could you try using the two patches here against 2.6.20 please:
>
> Ian
---
--- linux-2.6.20/fs/autofs4/root.c.lookup-check-unhased 2007-02-12 13:49:46.000000000 +0900
+++ linux-2.6.20/fs/autofs4/root.c 2007-02-12 13:54:58.000000000 +0900
@@ -655,14 +655,29 @@ static struct dentry *autofs4_lookup(str
/*
* If this dentry is unhashed, then we shouldn't honour this
- * lookup even if the dentry is positive. Returning ENOENT here
- * doesn't do the right thing for all system calls, but it should
- * be OK for the operations we permit from an autofs.
+ * lookup. Returning ENOENT here doesn't do the right thing
+ * for all system calls, but it should be OK for the operations
+ * we permit from an autofs.
*/
if (dentry->d_inode && d_unhashed(dentry)) {
+ /*
+ * A user space application can (and has done in the past)
+ * remove and re-create this directory during the callback.
+ * This can leave us with an unhashed dentry, but a
+ * successful mount! So we need to perform another
+ * cached lookup in case the dentry now exists.
+ */
+ struct dentry *parent = dentry->d_parent;
+ struct dentry *new = d_lookup(parent, &dentry->d_name);
+ if (new != NULL)
+ dentry = new;
+ else
+ dentry = ERR_PTR(-ENOENT);
+
if (unhashed)
dput(unhashed);
- return ERR_PTR(-ENOENT);
+
+ return dentry;
}
if (unhashed)
next prev parent reply other threads:[~2007-02-12 6:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 17:34 Olivier Galibert
2007-02-07 18:07 ` [autofs] " Ian Kent
2007-02-07 18:18 ` Olivier Galibert
2007-02-08 2:33 ` Ian Kent
2007-02-12 6:43 ` [PATCH 1/2] " Ian Kent
2007-02-12 6:46 ` Ian Kent [this message]
2007-02-12 13:57 ` Olivier Galibert
2007-02-13 0:52 ` Ian Kent
2007-02-13 8:50 ` Olivier Galibert
2007-02-13 13:40 ` Ian Kent
2007-02-13 14:07 ` Chuck Ebbert
2007-02-13 15:54 ` Olivier Galibert
2007-02-13 15:57 ` Chuck Ebbert
2007-02-13 17:35 ` Ian Kent
2007-02-13 20:43 ` Olivier Galibert
2007-02-13 17:29 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1171262800.18376.16.camel@raven.themaw.net \
--to=raven@themaw.net \
--cc=autofs@linux.kernel.org \
--cc=galibert@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH 2/2] Re: [autofs] Bad race condition in the new autofs protocol somewhere' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).