LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Vignesh Babu BM <vignesh.babu@wipro.com> To: Kernel Janitors List <kernel-janitors@lists.osdl.org> Cc: tony.luck@intel.com, linux-ia64@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [KJ][PATCH] is_power_of_2 in ia64mm Date: Fri, 16 Feb 2007 17:33:55 +0530 [thread overview] Message-ID: <1171627435.6127.0.camel@wriver-t81fb058.linuxcoe> (raw) Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 diff --git a/arch/ia64/mm/hugetlbpage.c b/arch/ia64/mm/hugetlbpage.c index 0c7e94e..0ccc70e 100644 --- a/arch/ia64/mm/hugetlbpage.c +++ b/arch/ia64/mm/hugetlbpage.c @@ -16,6 +16,7 @@ #include <linux/smp_lock.h> #include <linux/slab.h> #include <linux/sysctl.h> +#include <linux/log2.h> #include <asm/mman.h> #include <asm/pgalloc.h> #include <asm/tlb.h> @@ -175,7 +176,7 @@ static int __init hugetlb_setup_sz(char *str) tr_pages = 0x15557000UL; size = memparse(str, &str); - if (*str || (size & (size-1)) || !(tr_pages & size) || + if (*str || !is_power_of_2(size) || !(tr_pages & size) || size <= PAGE_SIZE || size >= (1UL << PAGE_SHIFT << MAX_ORDER)) { printk(KERN_WARNING "Invalid huge page size specified\n"); -- Regards, Vignesh Babu BM _____________________________________________________________ "Why is it that every time I'm with you, makes me believe in magic?"
next reply other threads:[~2007-02-16 12:37 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-02-16 12:03 Vignesh Babu BM [this message] 2007-02-16 15:02 ` [KJ] [PATCH] is_power_of_2 in ia64mm Richard Knutsson 2007-02-16 15:13 ` Andreas Schwab 2007-02-16 15:57 ` Richard Knutsson 2007-02-16 15:59 ` Andreas Schwab 2007-02-16 16:40 ` Richard Knutsson 2007-02-16 16:43 ` Andreas Schwab 2007-02-16 17:06 ` Robert P. J. Day 2007-02-16 17:36 ` Richard Knutsson 2007-02-16 16:58 ` Robert P. J. Day 2007-02-16 15:27 ` Boot time Bluetooth BUG: warning: (value > m) at hid-core.c:793 Fortier,Vincent [Montreal] 2007-02-18 21:23 ` Jiri Kosina 2007-02-19 0:25 ` Marcel Holtmann 2007-02-19 9:36 ` Jiri Kosina 2007-02-27 15:54 ` Jiri Kosina 2007-02-27 16:12 ` Fortier,Vincent [Montreal] [not found] ` <Pine.LNX.4.64.0702271713220.10496@twin.jikos.cz> 2007-02-27 20:35 ` Fortier,Vincent [Montreal]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1171627435.6127.0.camel@wriver-t81fb058.linuxcoe \ --to=vignesh.babu@wipro.com \ --cc=kernel-janitors@lists.osdl.org \ --cc=linux-ia64@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).