LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Jaya Kumar <jayakumar.lkml@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2.6.20 1/1] fbdev,mm: hecuba/E-Ink fbdev driver
Date: Sat, 17 Feb 2007 13:34:12 +0100	[thread overview]
Message-ID: <1171715652.5186.7.camel@lappy> (raw)
In-Reply-To: <20070217104215.GB25512@localhost>

On Sat, 2007-02-17 at 11:42 +0100, Jaya Kumar wrote:
> Hi James, Geert, lkml and mm,

Hi Jaya,

> This patch adds support for the Hecuba/E-Ink display with deferred IO.
> The changes from the previous version are to switch to using a mutex
> and lock_page. I welcome your feedback and advice.

This changelog ought to be a little more extensive; esp. because you're
using these fancy new functions ->page_mkwrite() and page_mkclean() in a
novel way.

Also, I'd still like to see a way to call msync() on the mmap'ed region
to force a flush. I think providing a fb_fsync() method in fbmem.c and a
hook down to the driver ought to work.

Also, you now seem to use a fixed 1 second delay, perhaps provide an
ioctl or something to customize this?

And, as Andrew suggested last time around, could you perhaps push this
fancy new idea into the FB layer so that more drivers can make us of it?



  reply	other threads:[~2007-02-17 12:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-17 10:42 Jaya Kumar
2007-02-17 12:34 ` Peter Zijlstra [this message]
2007-02-17 13:25   ` Jaya Kumar
2007-02-17 13:59     ` Paul Mundt
2007-02-18 11:31       ` Jaya Kumar
2007-02-18 23:57         ` Paul Mundt
2007-02-20  4:13           ` Jaya Kumar
2007-02-20  4:38             ` Paul Mundt
2007-02-20  6:11               ` Jaya Kumar
2007-02-21 16:46                 ` Jaya Kumar
2007-02-20  8:07             ` Geert Uytterhoeven
2007-02-21 16:55               ` Jaya Kumar
2007-02-21 21:52                 ` James Simmons
2007-02-21 23:22                   ` Jaya Kumar
2007-02-28 16:50                     ` [Linux-fbdev-devel] [PATCH 2.6.20 1/1] fbdev, mm: " James Simmons
2007-02-21 23:43                 ` Antonino A. Daplas
2007-02-21 23:47                   ` Jaya Kumar
2007-02-21 23:43             ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1171715652.5186.7.camel@lappy \
    --to=a.p.zijlstra@chello.nl \
    --cc=jayakumar.lkml@gmail.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --subject='Re: [PATCH 2.6.20 1/1] fbdev,mm: hecuba/E-Ink fbdev driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).