LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Alex Riesen <fork0@users.sourceforge.net>
Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: 2.6.20-git13 kernel BUG at /mnt/md0/devel/linux-git/kernel/time/tick-sched.c:168
Date: Sun, 18 Feb 2007 13:36:56 +0100	[thread overview]
Message-ID: <1171802216.30834.172.camel@localhost.localdomain> (raw)
In-Reply-To: <20070218095037.GA3408@steel.home>

On Sun, 2007-02-18 at 10:50 +0100, Alex Riesen wrote:
> > The arch/i386/kernel/process.c part of the patch should apply to 2.6.20
> > as well. Can you check if the problem is there too ?
> 
> It does not apply and does not look trivially hackable.
> The code for cpu_idle was introduced in 2ff2d3d7 "i386: add idle notifier".

Here you go.

	tglx

Index: linux-2.6.20/arch/i386/kernel/process.c
===================================================================
--- linux-2.6.20.orig/arch/i386/kernel/process.c
+++ linux-2.6.20/arch/i386/kernel/process.c
@@ -189,6 +189,13 @@ void cpu_idle(void)
 				play_dead();
 
 			__get_cpu_var(irq_stat).idle_timestamp = jiffies;
+
+			local_irq_disable();
+			if (local_softirq_pending() && !need_resched())
+				printk(KERN_ERR
+				       "Idle: local softirq pending: %04x\n",
+				       local_softirq_pending());
+			local_irq_enable();
 			idle();
 		}
 		preempt_enable_no_resched();





  parent reply	other threads:[~2007-02-18 12:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16 20:38 Michal Piotrowski
2007-02-16 21:22 ` Thomas Gleixner
2007-02-16 21:24   ` Michal Piotrowski
     [not found]   ` <20070217144752.GA2503@steel.home>
2007-02-17 15:14     ` Thomas Gleixner
     [not found]       ` <20070217164652.GA2579@steel.home>
2007-02-17 18:24         ` Thomas Gleixner
2007-02-17 22:41         ` Michal Piotrowski
2007-02-18  8:41           ` Thomas Gleixner
     [not found]             ` <20070218095037.GA3408@steel.home>
2007-02-18 12:36               ` Thomas Gleixner [this message]
     [not found]                 ` <20070218172410.GA2421@steel.home>
2007-02-19  1:00                   ` Michal Piotrowski
2007-02-21 12:18           ` Michal Piotrowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1171802216.30834.172.camel@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=akpm@osdl.org \
    --cc=fork0@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=mingo@elte.hu \
    --subject='Re: 2.6.20-git13 kernel BUG at /mnt/md0/devel/linux-git/kernel/time/tick-sched.c:168' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).