LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Andi Kleen <ak@suse.de>
Cc: virtualization@lists.osdl.org, Chris Wright <chrisw@sous-sol.org>,
	xen-devel@lists.xensource.com,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries
Date: Thu, 22 Feb 2007 10:20:02 +1100	[thread overview]
Message-ID: <1172100002.13378.42.camel@localhost.localdomain> (raw)
In-Reply-To: <200702212315.12883.ak@suse.de>

On Wed, 2007-02-21 at 23:15 +0100, Andi Kleen wrote:
> On Wednesday 21 February 2007 21:52, Jeremy Fitzhardinge wrote:
> > Add a set of accessors to pack, unpack and modify page table entries
> > (at all levels).  This allows a paravirt implementation to control the
> > contents of pgd/pmd/pte entries.  For example, Xen uses this to
> > convert the (pseudo-)physical address into a machine address when
> > populating a pagetable entry, and converting back to pphys address
> > when an entry is read.
> 
> Do you have some lmbench numbers before/after this change? 
> iirc at least fork and exit do a lot of pte accesses in various forms.
> If it's measurable it might be needed to patch those for the native case.

Yes, __mkpte must be patched to avoid performance embarrassment.

Jeremy, did you want me to do this, or are you happy to?
Rusty.
PS. I really must revise my "paravirt-ops counter" patch which tallies
how much each op is getting called.



  parent reply	other threads:[~2007-02-21 23:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070221205254.169835700@goop.org>
     [not found] ` <20070221205323.770169136@goop.org>
2007-02-21 22:10   ` [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch Andi Kleen
2007-02-21 22:14     ` Jeremy Fitzhardinge
2007-02-21 22:16     ` Keir Fraser
2007-02-21 23:25     ` [Xen-devel] " Zachary Amsden
2007-02-21 23:29       ` Jeremy Fitzhardinge
     [not found] ` <20070221205322.869165491@goop.org>
2007-02-21 22:15   ` [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries Andi Kleen
2007-02-21 22:20     ` Jeremy Fitzhardinge
2007-02-21 23:20     ` Rusty Russell [this message]
2007-02-21 23:27       ` [Xen-devel] " Jeremy Fitzhardinge
     [not found] ` <20070221205323.842917348@goop.org>
2007-02-22  3:10   ` [patch 18/24] Xen-paravirt_ops: Some generic early printk & boot console fixups Andrew Morton
2007-02-22  5:48     ` Jeremy Fitzhardinge
2007-02-22  8:33       ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1172100002.13378.42.camel@localhost.localdomain \
    --to=rusty@rustcorp.com.au \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=chrisw@sous-sol.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    --cc=xen-devel@lists.xensource.com \
    --subject='Re: [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).