LKML Archive on
help / color / mirror / Atom feed
From: James Bottomley <>
To: Sumant Patro <>
Subject: Re: [PATCH] scsi: megaraid_sas - throttle io if cmds are in risk of being timed-out
Date: Fri, 16 Mar 2007 17:22:55 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1172784593.19842.21.camel@dumbo>

On Thu, 2007-03-01 at 13:29 -0800, Sumant Patro wrote:
> Driver to throttle IO to reduce risk of OS timing out cmds.
> Implemented a circular queue to keep track of pending OS cmds in FW. 
> This queue is periodically (every 10 sec) checked by a timer routine.
> If there is any cmd that is in risk of getting timed-out by the OS, 
> the host->can_queue is reduced to 16 and MEGASAS_FW_BUSY flag is set. 
> The host->can_queue will be restored to default value when the following 
> two conditions are met : 5 secs has elapsed and the # of outstanding cmds
> in FW is less than 17.
> Also increased the per cmd timeout to 120*HZ from 90*HZ.

OK, this is still not nice.  What you need to be doing is intercepting
the timeout before it fires (and quiesces the machine).  Currently the
eh_timed_out() callback is only exposed to transport classes, I'll put
it back into the host template and then you can use it.


  reply	other threads:[~2007-03-16 22:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-01 21:29 [PATCH] scsi: megaraid_sas - throttle io if cmds are in risk of being timed-out Sumant Patro
2007-03-16 22:22 ` James Bottomley [this message]
2007-03-19 23:08   ` [PATCH] scsi: megaraid_sas - throttle io if cmds are in riskof " Patro, Sumant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).