LKML Archive on
help / color / mirror / Atom feed
From: Lee Schermerhorn <>
To: Rik van Riel <>
Cc: linux-mm <>,
	linux-kernel <>
Subject: Re: [RFC][PATCH] split file and anonymous page queues #2
Date: Tue, 20 Mar 2007 12:24:57 -0400	[thread overview]
Message-ID: <1174407897.5664.38.camel@localhost> (raw)
In-Reply-To: <>

On Mon, 2007-03-19 at 20:52 -0400, Rik van Riel wrote:
> Split the anonymous and file backed pages out onto their own pageout
> queues.  This we do not unnecessarily churn through lots of anonymous
> pages when we do not want to swap them out anyway.
> This should (with additional tuning) be a great step forward in
> scalability, allowing Linux to run well on very large systems where
> scanning through the anonymous memory (on our way to the page cache
> memory we do want to evict) is slowing systems down significantly.
> This patch has been stress tested and seems to work, but has not
> been fine tuned or benchmarked yet.  For now the swappiness parameter
> can be used to tweak swap aggressiveness up and down as desired, but
> in the long run we may want to simply measure IO cost of page cache
> and anonymous memory and auto-adjust.
> We apply pressure to each of sets of the pageout queues based on:
> - the size of each queue
> - the fraction of recently referenced pages in each queue,
>     not counting used-once file pages
> - swappiness (file IO is more efficient than swap IO)
> Please take this patch for a spin and let me know what goes well
> and what goes wrong.

Rick:  Which tree is the patch against.  Diffs say 2.6.20.x86_64, but
doesn't apply to 2.6.20 which doesn't use __inc_zone_state() for things
like nr_active, nr_inactive, ...

Also, in the snippet:

>--- linux-2.6.20.x86_64/mm/swap_state.c.vmsplit 2007-02-04
>13:44:54.000000000 -0500
>+++ linux-2.6.20.x86_64/mm/swap_state.c 2007-03-19 12:00:23.000000000
>@@ -354,7 +354,7 @@ struct page *read_swap_cache_async(swp_e
>                        /*
>                         * Initiate read into locked page and return.
>                         */
>-                       lru_cache_add_active(new_page);
>+                       lru_cache_add_anon(new_page);
>                        swap_readpage(NULL, new_page);
>                        return new_page;
>                }

Should that be lru_cache_add_active_anon()? Or did you intend to add it
to the inactive anon list?

Finally, could you [should you?] skip scanning the anon lists--or at
least the inactive anon list--when nr_swap_pages == 0?  The anon pages
aren't going anywhere, right?  I think this would obviate Christoph L's
patch to exclude anon pages from the LRU when there is no swap.  


  parent reply	other threads:[~2007-03-20 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-20  0:52 [RFC][PATCH] split file and anonymous page queues #2 Rik van Riel
2007-03-20  1:06 ` Rik van Riel
2007-03-20  6:12 ` Nick Piggin
2007-03-20 12:27   ` Rik van Riel
2007-03-20 16:24 ` Lee Schermerhorn [this message]
2007-03-20 17:19   ` Rik van Riel
2007-03-20 18:39 ` Bob Picco
2007-03-20 18:06   ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1174407897.5664.38.camel@localhost \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).