From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1751625AbXCUKd0@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751625AbXCUKd0 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 21 Mar 2007 06:33:26 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751853AbXCUKdZ
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 21 Mar 2007 06:33:25 -0400
Received: from nwd2mail11.analog.com ([137.71.25.57]:33319 "EHLO
	nwd2mail11.analog.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751625AbXCUKdZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 21 Mar 2007 06:33:25 -0400
X-IronPort-AV: i="4.14,308,1170651600"; 
   d="scan'208"; a="25053418:sNHT23606702"
Subject: Re: [PATCH -mm 1/4] Blackfin: architecture update patch
From: "Wu, Bryan" <bryan.wu@analog.com>
Reply-To: bryan.wu@analog.com
To: Arnd Bergmann <arnd@arndb.de>
Cc: bryan.wu@analog.com, Andrew Morton <akpm@linux-foundation.org>,
       Paul Mundt <lethal@linux-sh.org>,
       bert hubert <bert.hubert@netherlabs.nl>, linux-kernel@vger.kernel.org
In-Reply-To: <200703211125.39816.arnd@arndb.de>
References: <1174471618.5648.50.camel@roc-desktop>
	 <200703211125.39816.arnd@arndb.de>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Organization: Analog Devices, Inc.
Date: Wed, 21 Mar 2007 18:33:19 +0800
Message-Id: <1174473199.5648.62.camel@roc-desktop>
Mime-Version: 1.0
X-Mailer: Evolution 2.6.1 
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2007-03-21 at 11:25 +0100, Arnd Bergmann wrote:
> On Wednesday 21 March 2007, Wu, Bryan wrote:
> 
> > @@ -97,6 +97,11 @@ static inline void leds_switch(int flag)
> >  /*
> >   * The idle loop on BFIN
> >   */
> > +#ifdef CONFIG_IDLE_L1
> > +static inline void default_idle(void)__attribute__((l1_text));
> > +void cpu_idle(void)__attribute__((l1_text));
> > +#endif
> > +
> 
> A forward declaration for an inline function seems rather pointless.
> Moreover, marking default_idle both l1_text and inline seems
> contradicting, right?
> 
> > diff -purN linux-2.6-orig/include/asm-blackfin/asm-offsets.h linux-2.6/include/asm-blackfin/asm-offsets.h
> > --- linux-2.6-orig/include/asm-blackfin/asm-offsets.h	1970-01-01 08:00:00.000000000 +0800
> > +++ linux-2.6/include/asm-blackfin/asm-offsets.h	2007-03-21 15:21:10.000000000 +0800
> > @@ -0,0 +1,89 @@
> > +#ifndef __ASM_OFFSETS_H__
> > +#define __ASM_OFFSETS_H__
> > +/*
> > + * DO NOT MODIFY.
> > + *
> > + * This file was generated by Kbuild
> 
> This file should be in the exclude list for your diff, it is generally not
> shipped with the kernel sources.

Got, I will fix it.

> 
> > +#ifndef __ASSEMBLY__
> > +
> > +static inline unsigned char readb(volatile unsigned char *addr)
> > +{
> 
> The prototype for this should normally contain an __iomem.
> This kind of error is normally caught by running 'make C=1'
> to use the 'sparse' tool. If you have not run that yet,
> you should start to, as it finds a number of common bugs.
> 
> > +/*
> > + * Map some physical address range into the kernel address space.
> > + */
> > +static inline void *__ioremap(unsigned long physaddr, unsigned long size,
> > +				int cacheflag)
> > +{
> > +	return (void *)physaddr;
> > +}
> 
> Likewise, this should return an __iomem pointer.

It will be fixed as soon as possible.
> 
> The rest of the patch looks good to me.
> 
> 	Arnd <><

I sent 4 mail to LKML, but this one lost. Arnd, can you receive this
email from LKML. 

Thanks a lot
-Bryan Wu