LKML Archive on
help / color / mirror / Atom feed
From: Mimi Zohar <>
Subject: [Patch 5/7] integrity: mtime patch for mmap files
Date: Fri, 23 Mar 2007 12:09:58 -0400	[thread overview]
Message-ID: <1174666198.11149.5.camel@localhost.localdomain> (raw)

mmaped files are hashed and hmac'ed properly by EVM after being modified
when the file's mtime is updated correctly.  Peter Staubach's 'memory
mapped files not updating timestamps v2' patch properly updates the
mmapped file's mtime.  In those cases when an application does not
first msync the file before calling munmap, the mtime is eventually
updated, but not before file_close is called.  This patch forces the
mtime for mmaped files to be updated in a timely manner.

signed-off-by: Mimi Zohar <>
Index: linux-2.6.21-rc4-mm1/mm/mmap.c
--- linux-2.6.21-rc4-mm1.orig/mm/mmap.c
+++ linux-2.6.21-rc4-mm1/mm/mmap.c
@@ -1790,6 +1790,7 @@ int do_munmap(struct mm_struct *mm, unsi
 	unsigned long end;
 	struct vm_area_struct *vma, *prev, *last;
+	struct file *file;
 	if ((start & ~PAGE_MASK) || start > TASK_SIZE || len > TASK_SIZE-start)
 		return -EINVAL;
@@ -1808,6 +1809,10 @@ int do_munmap(struct mm_struct *mm, unsi
 	if (vma->vm_start >= end)
 		return 0;
+	file = vma->vm_file;
+	if (file && test_and_clear_bit(AS_MCTIME, &file->f_mapping->flags))
+		file_update_time(file);
 	 * If we need to split any vma, do it now to save pain later.

             reply	other threads:[~2007-03-23 16:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-23 16:09 Mimi Zohar [this message]
2007-03-25  8:26 ` Andrew Morton
2007-03-26 20:49   ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1174666198.11149.5.camel@localhost.localdomain \ \ \ \ \ \ \ \ \
    --subject='Re: [Patch 5/7] integrity: mtime patch for mmap files' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).