LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Roman Zippel <zippel@linux-m68k.org>,
	john stultz <johnstul@us.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] ntp: avoid integer overflow in do_adjtimex()
Date: Sun, 25 Mar 2007 15:01:00 +0200	[thread overview]
Message-ID: <1174827661.10840.514.camel@localhost.localdomain> (raw)
In-Reply-To: <20070325111420.GA16988@elte.hu>

On Sun, 2007-03-25 at 13:14 +0200, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> > Here you go. It's ugly, but it should do the trick for now.
> > 
> > 	tglx
> 
> here's your patch with proper metadata:
> 
> --------------------->
> From: Thomas Gleixner <tglx@linutronix.de>
> Subject: [patch] ntp: avoid integer overflow in do_adjtimex()
> 
> John Stultz traced back ntpd problems to the following issue: 
> do_adjtimex() [used by ntpd] can overflow if there's a too long delay 
> between timer interrupts - as it can happen on NO_HZ. Expand the 
> time_adjust calculation/division from 32 bits to 64 bits.

Wrong metadata. This is a patch to fix John's patch vs. signedness.

	tglx




      reply	other threads:[~2007-03-25 12:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-24  0:40 [PATCH] Avoid time_offset overflows john stultz
2007-03-24  5:20 ` Roman Zippel
2007-03-25  9:09   ` Andrew Morton
2007-03-25 11:07     ` Thomas Gleixner
2007-03-25 11:14       ` [patch] ntp: avoid integer overflow in do_adjtimex() Ingo Molnar
2007-03-25 13:01         ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1174827661.10840.514.camel@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=zippel@linux-m68k.org \
    --subject='Re: [patch] ntp: avoid integer overflow in do_adjtimex()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).