LKML Archive on
help / color / mirror / Atom feed
From: Dan Engel <>
To: Jiri Kosina <>
Cc: Dmitry Torokhov <>,
Subject: Re: [PATCH] hid: add two led codes to hid input mapping
Date: Sun, 01 Apr 2007 23:28:59 -0400	[thread overview]
Message-ID: <1175484539.12355.18.camel@monica.engel.home> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

On Sun, 2007-04-01 at 19:43 +0200, Jiri Kosina wrote:
> On Sun, 1 Apr 2007, Dmitry Torokhov wrote:
> > No, I do not want to add any more LED constants to input. In fact I 
> > think that adding constants beyond keyboard indicators was a mistake. We 
> > have led subsystem that provides interface to control arbitrary leds and 
> > we should use it.
> Ah, of course. Dan, could you please redo the patch to use the leds 
> infrastructure and send it to me?

Perhaps I could find a way to do that, but it seem rather a round-about
way to go about it. The fact is that the input subsystem is already the
home of this device.

As far as I can tell, the led subsystem doesn't already provide any
framework for mapping LED's to HID input events. I could possibly create
a driver in the led subsystem that sends the corresponding events to the
input subsystem, but those events would be dropped by the input system,
anyway, since the event class would still have to be EV_LED and the code
would still be unrecognized without those two mappings.

Given that the HID or input subsystem still needs to be in the loop,
however the driver is written, can you give any advice for accomplishing
that without adding the extra LED mappings?

Thanks for any help,
-Dan Engel

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-04-02  3:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-01  2:56 Dan Engel
2007-04-01  9:01 ` Jiri Kosina
2007-04-01 14:57   ` Dmitry Torokhov
2007-04-01 17:43     ` Jiri Kosina
2007-04-02  3:28       ` Dan Engel [this message]
2007-04-02  4:04         ` Dmitry Torokhov
2007-04-02 10:14           ` Dan Engel
2007-04-02 13:06             ` Dmitry Torokhov
2007-04-02 13:33               ` Dan Engel
2007-04-02 13:46                 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175484539.12355.18.camel@monica.engel.home \ \ \ \ \
    --subject='Re: [PATCH] hid: add two led codes to hid input mapping' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).