LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Engel <dan@sourceharvest.com>
To: Dmitry Torokhov <dtor@insightbb.com>
Cc: Jiri Kosina <jkosina@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: add two led codes to hid input mapping
Date: Mon, 02 Apr 2007 06:14:02 -0400	[thread overview]
Message-ID: <1175508842.12355.34.camel@monica.engel.home> (raw)
In-Reply-To: <200704020004.51861.dtor@insightbb.com>

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

On Mon, 2007-04-02 at 00:04 -0400, Dmitry Torokhov wrote:

> Actually I want to keep input subystm out of the loop here, since LEDs
> such as mail, charging, etc have nothing to do with user input but
> rather reflect overall system/application state.
> 

What if I just added a HID_QUIRK_HIDDEV for the vendor/product id's in
the blacklist table in hiddev.c. That would force the creation of a
hiddev device, through which a user-space program could access the HID
usages directly.

It would be awkward, though, since there would also be an input event
device, but one through which the full functionality is not accessible.
Is there a HID_QUIRK that would force creation of a hiddev *instead of*
(rather than in addition to) an event dev?

Two things to keep in mind:

1) The device in question (it's a Belkin USB Flip KVM switch, just to
restate from the OP) has nothing to do with LED's. It just overloads the
LED HID usage codes to receive control from the PC.

2) No matter what we do in terms of presenting this device to user-land,
under the hood it's a HID-class USB device, and it probably doesn't make
sense to not make use of that.

Thanks,
-Dan

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-04-02 10:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-01  2:56 Dan Engel
2007-04-01  9:01 ` Jiri Kosina
2007-04-01 14:57   ` Dmitry Torokhov
2007-04-01 17:43     ` Jiri Kosina
2007-04-02  3:28       ` Dan Engel
2007-04-02  4:04         ` Dmitry Torokhov
2007-04-02 10:14           ` Dan Engel [this message]
2007-04-02 13:06             ` Dmitry Torokhov
2007-04-02 13:33               ` Dan Engel
2007-04-02 13:46                 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175508842.12355.34.camel@monica.engel.home \
    --to=dan@sourceharvest.com \
    --cc=dtor@insightbb.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] hid: add two led codes to hid input mapping' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).