LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Ed Lin <ed.lin@promise.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
jeff <jeff@garzik.org>, Promise_Linux <Promise_Linux@promise.com>
Subject: RE: [PATCH 1/4] [SCSI]stex: fix id mapping issue
Date: Wed, 04 Apr 2007 12:35:39 -0500 [thread overview]
Message-ID: <1175708139.3693.39.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <B70A50D07063384EB9BCE3330D18414F0327ED0C@nonameb.ptu.promise.com>
On Wed, 2007-04-04 at 10:31 -0700, Ed Lin wrote:
> Sorry. It seems the mail server has problem. The patch is here in plain
> text. I hope this time it does not mess up. I have problem with
> linux-scsi
> mail list, if you have comment please cc me. Thanks.
> --Ed Lin
The lines are still broken, I'm afraid ... you can just resend as an
attachement git-applypatch copes fine with that ... inline is just good
for quoting and replying.
> + if (hba->cardtype == st_shasta) {
> + host->max_channel = 7;
> + host->max_id = 16 + 1;
> + } else if (hba->cardtype == st_yosemite) {
> + host->max_channel = 127;
> + host->max_id = 1 + 1;
> + } else {
> + /* st_vsc and st_vsc1 */
> + host->max_channel = 0;
> + host->max_id = 128 + 1;
This is OK. The use of ->channel is still a bit strange ... could we
not simply use lun instead of channel (i.e. map the adapter id/lun to
the mid-layer id/lun instead of using id/channel)?
James
next prev parent reply other threads:[~2007-04-04 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 17:31 Ed Lin
2007-04-04 17:35 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-04-04 18:37 Ed Lin
2007-04-02 23:01 Ed Lin
2007-04-02 17:59 Ed Lin
2007-04-02 17:46 Ed Lin
2007-03-30 22:21 Ed Lin
2007-03-30 23:35 ` Jeff Garzik
2007-03-31 9:26 ` Christoph Hellwig
2007-03-31 14:22 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175708139.3693.39.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=Promise_Linux@promise.com \
--cc=ed.lin@promise.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--subject='RE: [PATCH 1/4] [SCSI]stex: fix id mapping issue' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).