LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [GIT PATCHES] V4L/DVB updates
@ 2007-04-15 15:31 Mauro Carvalho Chehab
  2007-04-16  0:33 ` [v4l-dvb-maintainer] " Michael Krufky
  2007-04-16 15:50 ` Dmitry Torokhov
  0 siblings, 2 replies; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-04-15 15:31 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, linux-dvb-maintainer, video4linux-list, linux-kernel

Linus,

Please pull from:
        ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master

For the following:

   - Fix Kernel Bugzilla #8301: spinlock fix for flexcop-pci
   - Fix 1/3 for bug 7819: fixed frontend hotplug issue
   - Fix 2/3 for bug 7819: demux and dvr
   - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
   - Usbvision: fix TDA9887 detection
   - Bt878: prevent probing wrong card entry

The fix for Bugzilla #7819 is bigger, since the current lock approach 
doesn't allow hotunplugging an USB DVB device. The other patches are 
trivial fixes.

Cheers,
Mauro.

---

 Documentation/logo.gif                             |  Bin
 drivers/media/dvb/b2c2/flexcop-pci.c               |    9 ++--
 drivers/media/dvb/bt8xx/bt878.c                    |    4 +-
 drivers/media/dvb/dvb-core/dmxdev.c                |   56 +++++++++++++++++++-
 drivers/media/dvb/dvb-core/dmxdev.h                |    2 +
 drivers/media/dvb/dvb-core/dvb_frontend.c          |   20 ++++++-
 drivers/media/dvb/dvb-core/dvb_net.c               |   32 +++++++++++-
 drivers/media/dvb/dvb-core/dvb_net.h               |    1 +
 drivers/media/dvb/dvb-core/dvbdev.c                |    1 +
 drivers/media/dvb/dvb-core/dvbdev.h                |    1 +
 drivers/media/video/usbvision/usbvision-i2c.c      |    1 +
 11 files changed, 115 insertions(+), 12 deletions(-)

Akinobu Mita (1):
      V4L/DVB (5513): Bt878: prevent probing wrong card entry

Hendrik Borghorst (1):
      V4L/DVB (5505): Fix Kernel Bugzilla #8301: spinlock fix for flexcop-pci

Markus Rechberger (3):
      V4L/DVB (5510): Fix 1/3 for bug 7819: fixed frontend hotplug issue
      V4L/DVB (5511): Fix 2/3 for bug 7819: demux and dvr
      V4L/DVB (5512): Fix 3/3 for bug 7819: fixed hotplugging for dvbnet

Thierry MERLE (1):
      V4L/DVB (5524): Usbvision: fix TDA9887 detection

---------------------------------------------------
V4L/DVB development is hosted at http://linuxtv.org


^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-15 15:31 [GIT PATCHES] V4L/DVB updates Mauro Carvalho Chehab
@ 2007-04-16  0:33 ` Michael Krufky
  2007-04-16  5:22   ` Manu Abraham
  2007-04-16 14:15   ` Adrian Bunk
  2007-04-16 15:50 ` Dmitry Torokhov
  1 sibling, 2 replies; 31+ messages in thread
From: Michael Krufky @ 2007-04-16  0:33 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linus Torvalds, linux-dvb-maintainer, Andrew Morton,
	video4linux-list, linux-kernel

Mauro,

I've been out of town for the past few days... I just got home and saw this:


Mauro Carvalho Chehab wrote:
>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
>    - Fix 2/3 for bug 7819: demux and dvr
>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
I don't think that this is 2.6.21 material.  These patches have not yet
received
enough testing to be sent to mainline.

I have tested them, and they seem to work for my cxusb device, but we have
yet to hear test results from users of usb dvb devices that do not use the
dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)

The bug that these patches fix has been around throughout the entire kernel
history of the dvb subsystem.  The bug is not a regression -- it has
always been
there.  In my opinion, it is too late in 2.6.21 development to apply
this change.
Because these fixes are not obvious, I think we should let them get some
more testing, and have them queued for 2.6.22 .


Regards,

Michael

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16  0:33 ` [v4l-dvb-maintainer] " Michael Krufky
@ 2007-04-16  5:22   ` Manu Abraham
  2007-04-16  8:17     ` Markus Rechberger
  2007-04-16 14:15   ` Adrian Bunk
  1 sibling, 1 reply; 31+ messages in thread
From: Manu Abraham @ 2007-04-16  5:22 UTC (permalink / raw)
  To: Michael Krufky
  Cc: Mauro Carvalho Chehab, linux-dvb-maintainer, Andrew Morton,
	Linus Torvalds, linux-kernel

Michael Krufky wrote:
> Mauro,
> 
> I've been out of town for the past few days... I just got home and saw this:
> 
> 
> Mauro Carvalho Chehab wrote:
>>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
>>    - Fix 2/3 for bug 7819: demux and dvr
>>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> I don't think that this is 2.6.21 material.  These patches have not yet
> received
> enough testing to be sent to mainline.
> 
> I have tested them, and they seem to work for my cxusb device, but we have
> yet to hear test results from users of usb dvb devices that do not use the
> dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
> 
> The bug that these patches fix has been around throughout the entire kernel
> history of the dvb subsystem.  The bug is not a regression -- it has
> always been
> there.  In my opinion, it is too late in 2.6.21 development to apply
> this change.
> Because these fixes are not obvious, I think we should let them get some
> more testing, and have them queued for 2.6.22 .


I am not arguing about the veracity of the patches, but how things are
handled.

Agreed to all the mentioned above. There is one more aspect. The
mentioned patches, do not have any ACK/SOB from any DVB
developer/maintainer for the same.

Huge regressions are created this way. One more time the regression
creator is caught.

Manu

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16  5:22   ` Manu Abraham
@ 2007-04-16  8:17     ` Markus Rechberger
  2007-04-16 10:00       ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 31+ messages in thread
From: Markus Rechberger @ 2007-04-16  8:17 UTC (permalink / raw)
  To: Manu Abraham
  Cc: Michael Krufky, linux-dvb-maintainer, Andrew Morton,
	Linus Torvalds, linux-kernel, Mauro Carvalho Chehab

On 4/16/07, Manu Abraham <abraham.manu@gmail.com> wrote:
> Michael Krufky wrote:
> > Mauro,
> >
> > I've been out of town for the past few days... I just got home and saw
> this:
> >
> >
> > Mauro Carvalho Chehab wrote:
> >>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
> >>    - Fix 2/3 for bug 7819: demux and dvr
> >>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> > I don't think that this is 2.6.21 material.  These patches have not yet
> > received
> > enough testing to be sent to mainline.
> >
> > I have tested them, and they seem to work for my cxusb device, but we have
> > yet to hear test results from users of usb dvb devices that do not use the
> > dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
> >
> > The bug that these patches fix has been around throughout the entire
> kernel
> > history of the dvb subsystem.  The bug is not a regression -- it has
> > always been
> > there.  In my opinion, it is too late in 2.6.21 development to apply
> > this change.
> > Because these fixes are not obvious, I think we should let them get some
> > more testing, and have them queued for 2.6.22 .
>
>
> I am not arguing about the veracity of the patches, but how things are
> handled.
>
> Agreed to all the mentioned above. There is one more aspect. The
> mentioned patches, do not have any ACK/SOB from any DVB
> developer/maintainer for the same.
>
> Huge regressions are created this way. One more time the regression
> creator is caught.
>

The patch has been around on the dvb mailinglist ([PATCH][RFC] DVB
Hotplug Fix, 5. April 2007), Michael looked at it when I told him
about it again separatly (12. April 2007)
Between that there was enough time to respond on it or review it.

Mauro told me at the beginning if noone responds he'll go forward
somehow because it fixes hotplugging, and after 2 weeks I wouldn't
expect anyone commenting that thread anymore.

It would be better to look and respond to that patch first before
responding about that you don't like how it's handled, Mauro also
wrote in his announcement that people should look at the recent
mercurial tree and he'll revert it if something doesn't work by
accident before submitting it to his git tree... still noone
complained about the hotplugging patch in there.

Markus

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16  8:17     ` Markus Rechberger
@ 2007-04-16 10:00       ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-04-16 10:00 UTC (permalink / raw)
  To: Markus Rechberger
  Cc: Manu Abraham, Michael Krufky, linux-dvb-maintainer,
	Andrew Morton, Linus Torvalds, linux-kernel

Em Seg, 2007-04-16 às 10:17 +0200, Markus Rechberger escreveu:
> On 4/16/07, Manu Abraham <abraham.manu@gmail.com> wrote:
> > Michael Krufky wrote:
> > > Mauro,
> > >
> > > I've been out of town for the past few days... I just got home and saw
> > this:
> > >
> > >
> > > Mauro Carvalho Chehab wrote:
> > >>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
> > >>    - Fix 2/3 for bug 7819: demux and dvr
> > >>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> > > I don't think that this is 2.6.21 material.  These patches have not yet
> > > received
> > > enough testing to be sent to mainline.
> > >
> > > I have tested them, and they seem to work for my cxusb device, but we have
> > > yet to hear test results from users of usb dvb devices that do not use the
> > > dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
> > >
> > > The bug that these patches fix has been around throughout the entire
> > kernel
> > > history of the dvb subsystem.  The bug is not a regression -- it has
> > > always been
> > > there.  In my opinion, it is too late in 2.6.21 development to apply
> > > this change.
> > > Because these fixes are not obvious, I think we should let them get some
> > > more testing, and have them queued for 2.6.22 .
> >
> >
> > I am not arguing about the veracity of the patches, but how things are
> > handled.
> >
> > Agreed to all the mentioned above. There is one more aspect. The
> > mentioned patches, do not have any ACK/SOB from any DVB
> > developer/maintainer for the same.
> >
> > Huge regressions are created this way. One more time the regression
> > creator is caught.
> >
> 
> The patch has been around on the dvb mailinglist ([PATCH][RFC] DVB
> Hotplug Fix, 5. April 2007), Michael looked at it when I told him
> about it again separatly (12. April 2007)
> Between that there was enough time to respond on it or review it.
> 
> Mauro told me at the beginning if noone responds he'll go forward
> somehow because it fixes hotplugging, and after 2 weeks I wouldn't
> expect anyone commenting that thread anymore.
> 
> It would be better to look and respond to that patch first before
> responding about that you don't like how it's handled, Mauro also
> wrote in his announcement that people should look at the recent
> mercurial tree and he'll revert it if something doesn't work by
> accident before submitting it to his git tree... still noone
> complained about the hotplugging patch in there.
Ditto.

It is really bad to have an OOPS that can be generated by simply
removing a device at the usb port. This can open a door for DoS attacks.
IMO, this kind of bug should be fixed as soon as possible. 

If you take a look at the history of this bug, it were reported back on
Jan, 14. Also, Adrian sent several regression reports c/c to
v4l-dvb-mailing list (so copying all V4L/DVB maintainers, including you,
me, Markus and the others), warning about the bug, and pointing that a
patch from Markus were already available.

I also explicitly warned at DVB ML that I were about to send this patch,
together with other fixes, asking the community for more tests. After
that, I received two positive answers on my mailbox from people that
tested and noticed that this really fixed the issue.

I don't think that 3 months is a short period of time for us to work on
a solution for the bug and have it done to be included on Kernel.

Cheers,
Mauro


^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16  0:33 ` [v4l-dvb-maintainer] " Michael Krufky
  2007-04-16  5:22   ` Manu Abraham
@ 2007-04-16 14:15   ` Adrian Bunk
  2007-04-16 14:52     ` CIJOML
                       ` (2 more replies)
  1 sibling, 3 replies; 31+ messages in thread
From: Adrian Bunk @ 2007-04-16 14:15 UTC (permalink / raw)
  To: Michael Krufky
  Cc: Mauro Carvalho Chehab, Linus Torvalds, linux-dvb-maintainer,
	Andrew Morton, video4linux-list, linux-kernel, CIJOML

On Sun, Apr 15, 2007 at 08:33:38PM -0400, Michael Krufky wrote:
> Mauro,
> 
> I've been out of town for the past few days... I just got home and saw this:
> 
> 
> Mauro Carvalho Chehab wrote:
> >    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
> >    - Fix 2/3 for bug 7819: demux and dvr
> >    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> I don't think that this is 2.6.21 material.  These patches have not yet
> received
> enough testing to be sent to mainline.
> 
> I have tested them, and they seem to work for my cxusb device, but we have
> yet to hear test results from users of usb dvb devices that do not use the
> dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
> 
> The bug that these patches fix has been around throughout the entire kernel
> history of the dvb subsystem.  The bug is not a regression -- it has
> always been
> there.  In my opinion, it is too late in 2.6.21 development to apply
> this change.
> Because these fixes are not obvious, I think we should let them get some
> more testing, and have them queued for 2.6.22 .

Unless I misunderstand anything, this should fix [1].

And this is a bug that was reported to be present in 2.6.21-rc but not 
in 2.6.20 (and it's therefore a regression, no matter whether the 
underlying problem was older and only exposed by some other change).

> Regards,
> 
> Michael

cu
Adrian

[1] http://lkml.org/lkml/2007/3/9/212

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16 14:15   ` Adrian Bunk
@ 2007-04-16 14:52     ` CIJOML
  2007-04-16 15:00     ` CIJOML
  2007-04-16 15:34     ` Michael Krufky
  2 siblings, 0 replies; 31+ messages in thread
From: CIJOML @ 2007-04-16 14:52 UTC (permalink / raw)
  To: Adrian Bunk
  Cc: Michael Krufky, Mauro Carvalho Chehab, Linus Torvalds,
	linux-dvb-maintainer, Andrew Morton, video4linux-list,
	linux-kernel

Hi,

I have tested these patches with:

Freecom DVB-T dongle
Pluto2 pcmcia card
Leadtek WinFast DTV dongle 1st generation
Leadtek WinFast DTV dongle 2nd generation

These are 4 different devices with 4 different hw and modules.
All works. Please apply.

Michal

Dne pondělí 16 duben 2007 16:15 Adrian Bunk napsal(a):
> On Sun, Apr 15, 2007 at 08:33:38PM -0400, Michael Krufky wrote:
> > Mauro,
> >
> > I've been out of town for the past few days... I just got home and saw
> > this:
> >
> > Mauro Carvalho Chehab wrote:
> > >    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
> > >    - Fix 2/3 for bug 7819: demux and dvr
> > >    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> >
> > I don't think that this is 2.6.21 material.  These patches have not yet
> > received
> > enough testing to be sent to mainline.
> >
> > I have tested them, and they seem to work for my cxusb device, but we
> > have yet to hear test results from users of usb dvb devices that do not
> > use the dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
> >
> > The bug that these patches fix has been around throughout the entire
> > kernel history of the dvb subsystem.  The bug is not a regression -- it
> > has always been
> > there.  In my opinion, it is too late in 2.6.21 development to apply
> > this change.
> > Because these fixes are not obvious, I think we should let them get some
> > more testing, and have them queued for 2.6.22 .
>
> Unless I misunderstand anything, this should fix [1].
>
> And this is a bug that was reported to be present in 2.6.21-rc but not
> in 2.6.20 (and it's therefore a regression, no matter whether the
> underlying problem was older and only exposed by some other change).
>
> > Regards,
> >
> > Michael
>
> cu
> Adrian
>
> [1] http://lkml.org/lkml/2007/3/9/212

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16 14:15   ` Adrian Bunk
  2007-04-16 14:52     ` CIJOML
@ 2007-04-16 15:00     ` CIJOML
  2007-04-16 15:34     ` Michael Krufky
  2 siblings, 0 replies; 31+ messages in thread
From: CIJOML @ 2007-04-16 15:00 UTC (permalink / raw)
  To: Adrian Bunk
  Cc: Michael Krufky, Mauro Carvalho Chehab, Linus Torvalds,
	linux-dvb-maintainer, Andrew Morton, video4linux-list,
	linux-kernel

One more addiction:

As a side effect this fixes also kernel crash, when you swsusp/swresume with 
USB dongle and playing DVB stream. 

Michal

Dne pondělí 16 duben 2007 16:15 Adrian Bunk napsal(a):
> On Sun, Apr 15, 2007 at 08:33:38PM -0400, Michael Krufky wrote:
> > Mauro,
> >
> > I've been out of town for the past few days... I just got home and saw
> > this:
> >
> > Mauro Carvalho Chehab wrote:
> > >    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
> > >    - Fix 2/3 for bug 7819: demux and dvr
> > >    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> >
> > I don't think that this is 2.6.21 material.  These patches have not yet
> > received
> > enough testing to be sent to mainline.
> >
> > I have tested them, and they seem to work for my cxusb device, but we
> > have yet to hear test results from users of usb dvb devices that do not
> > use the dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
> >
> > The bug that these patches fix has been around throughout the entire
> > kernel history of the dvb subsystem.  The bug is not a regression -- it
> > has always been
> > there.  In my opinion, it is too late in 2.6.21 development to apply
> > this change.
> > Because these fixes are not obvious, I think we should let them get some
> > more testing, and have them queued for 2.6.22 .
>
> Unless I misunderstand anything, this should fix [1].
>
> And this is a bug that was reported to be present in 2.6.21-rc but not
> in 2.6.20 (and it's therefore a regression, no matter whether the
> underlying problem was older and only exposed by some other change).
>
> > Regards,
> >
> > Michael
>
> cu
> Adrian
>
> [1] http://lkml.org/lkml/2007/3/9/212

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16 14:15   ` Adrian Bunk
  2007-04-16 14:52     ` CIJOML
  2007-04-16 15:00     ` CIJOML
@ 2007-04-16 15:34     ` Michael Krufky
  2007-04-16 16:16       ` Markus Rechberger
  2007-04-16 16:18       ` CIJOML
  2 siblings, 2 replies; 31+ messages in thread
From: Michael Krufky @ 2007-04-16 15:34 UTC (permalink / raw)
  To: Adrian Bunk
  Cc: Michael Krufky, video4linux-list, linux-kernel,
	Mauro Carvalho Chehab, CIJOML, linux-dvb-maintainer,
	Andrew Morton, Linus Torvalds

Adrian Bunk wrote:
> On Sun, Apr 15, 2007 at 08:33:38PM -0400, Michael Krufky wrote:
>> Mauro,
>>
>> I've been out of town for the past few days... I just got home and saw this:
>>
>>
>> Mauro Carvalho Chehab wrote:
>>>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
>>>    - Fix 2/3 for bug 7819: demux and dvr
>>>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
>> I don't think that this is 2.6.21 material.  These patches have not yet
>> received
>> enough testing to be sent to mainline.
>>
>> I have tested them, and they seem to work for my cxusb device, but we have
>> yet to hear test results from users of usb dvb devices that do not use the
>> dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
>>
>> The bug that these patches fix has been around throughout the entire kernel
>> history of the dvb subsystem.  The bug is not a regression -- it has
>> always been
>> there.  In my opinion, it is too late in 2.6.21 development to apply
>> this change.
>> Because these fixes are not obvious, I think we should let them get some
>> more testing, and have them queued for 2.6.22 .
> 
> Unless I misunderstand anything, this should fix [1].
> 
> And this is a bug that was reported to be present in 2.6.21-rc but not 
> in 2.6.20 (and it's therefore a regression, no matter whether the 
> underlying problem was older and only exposed by some other change).

Not true.  The DVB subsystem has NEVER been hot-unpluggable.  I confirm that the
patches SEEM to be correct, but this has not yet been verified.  None of the
authors of dvb-core gave their ACK on these changesets.

The DVB hotplug issue has been around since the very beginning.  I assure you,
that I consider this fix to be very important, and I really would love to see it
hit mainline.  However, given the situation, it is not appropriate to push these
in during -rc7

I have doubts on CIJOML's testing method -- there is no way he could have
unplugged the device while in use, while running 2.6.20.y and not receive an
OOPS.  CIJOML, please see the bottom of this email for

Sure, this will prevent an OOPS on some, and hopefully all devices...  but what
if it causes a regression for those untested?

Why do we have a merge window, if new changesets are going to be rushed into
late -rc kernels without proper testing, and without the ack of a dvb subsystem
maintainer?

Are we prepared to go for another -rc and 3 or 4 weeks of testing to confirm
that this fix doesn't cause new regressions?  I don't think so.


Markus Rechberger wrote:
> The patch has been around on the dvb mailinglist ([PATCH][RFC] DVB
> Hotplug Fix, 5. April 2007),

The patch was merged into the development repository at the same time the pull
request was issued to Linus.  This has NOT been tested on a wide scale.  It
should go to -mm for a while before being merged to mainline.

Mauro Carvalho Chehab wrote:
> I also explicitly warned at DVB ML that I were about to send this patch,
> together with other fixes, asking the community for more tests. After
> that, I received two positive answers on my mailbox from people that
> tested and noticed that this really fixed the issue.

One of those positive answers was me -  I explained that it worked for me, but
we need others to test.

You waited ONE DAY after sending this "warning" to the dvb mailing list?  (
http://linuxtv.org/pipermail/linux-dvb/2007-April/017204.html ) I saw that email
after seeing the pull request to Linus.  We dont have users testing the
repositories after each commit -- you _really_ need to give some more time to
allow for such testing.

CIJOML wrote:
> Hi,
>
> I have tested these patches with:
>
> Freecom DVB-T dongle
> Pluto2 pcmcia card
> Leadtek WinFast DTV dongle 1st generation
> Leadtek WinFast DTV dongle 2nd generation
>
> These are 4 different devices with 4 different hw and modules.
> All works. Please apply.

Well, that helps...  But it would still be nice to hear test results on a
CinergyT2 or flexcop-usb.

Which driver supports those Winfast dongles?  We already know for sure that the
patches work correctly for any driver based on the dvb-usb framework.

If you had the device open, and then disconnect it from the usb bus, no matter
what kernel version you're running, you should hit the OOPS.  I confirm that
these patches prevent that OOPS from occurring, but I have trouble believing
that you did NOT experience such an OOPS in 2.6.20.y

Could you please describe the method in which your test caused an OOPS using
2.6.21-rc and did NOT cause an oops in 2.6.20.y ?

-- 
Michael Krufky


^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [GIT PATCHES] V4L/DVB updates
  2007-04-15 15:31 [GIT PATCHES] V4L/DVB updates Mauro Carvalho Chehab
  2007-04-16  0:33 ` [v4l-dvb-maintainer] " Michael Krufky
@ 2007-04-16 15:50 ` Dmitry Torokhov
  2007-04-16 21:49   ` [v4l-dvb-maintainer] " Trent Piepho
  1 sibling, 1 reply; 31+ messages in thread
From: Dmitry Torokhov @ 2007-04-16 15:50 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Linus Torvalds, Andrew Morton, linux-dvb-maintainer,
	video4linux-list, linux-kernel

Hi Mauro,

On 4/15/07, Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
>   - Fix Kernel Bugzilla #8301: spinlock fix for flexcop-pci

While move of spin_lock_init before request_irq is obviously correct I
wonder what is the reason behind changing spin_lock_irq() into
spin_lock_irqsave() as I do not see flexcop_pci_isr being called from
anywhere but IRQ context.

BTW, is irq_lock needed at all?

-- 
Dmitry

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16 15:34     ` Michael Krufky
@ 2007-04-16 16:16       ` Markus Rechberger
  2007-04-27 21:34         ` Trent Piepho
  2007-04-16 16:18       ` CIJOML
  1 sibling, 1 reply; 31+ messages in thread
From: Markus Rechberger @ 2007-04-16 16:16 UTC (permalink / raw)
  To: Michael Krufky
  Cc: Adrian Bunk, video4linux-list, linux-kernel,
	Mauro Carvalho Chehab, linux-dvb-maintainer, CIJOML,
	Andrew Morton, Linus Torvalds, daniel, holger

On 4/16/07, Michael Krufky <mkrufky@linuxtv.org> wrote:
> Adrian Bunk wrote:
> > On Sun, Apr 15, 2007 at 08:33:38PM -0400, Michael Krufky wrote:
> >> Mauro,
> >>
> >> I've been out of town for the past few days... I just got home and saw
> this:
> >>
> >>
> >> Mauro Carvalho Chehab wrote:
> >>>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
> >>>    - Fix 2/3 for bug 7819: demux and dvr
> >>>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> >> I don't think that this is 2.6.21 material.  These patches have not yet
> >> received
> >> enough testing to be sent to mainline.
> >>
> >> I have tested them, and they seem to work for my cxusb device, but we
> have
> >> yet to hear test results from users of usb dvb devices that do not use
> the
> >> dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
> >>
> >> The bug that these patches fix has been around throughout the entire
> kernel
> >> history of the dvb subsystem.  The bug is not a regression -- it has
> >> always been
> >> there.  In my opinion, it is too late in 2.6.21 development to apply
> >> this change.
> >> Because these fixes are not obvious, I think we should let them get some
> >> more testing, and have them queued for 2.6.22 .
> >
> > Unless I misunderstand anything, this should fix [1].
> >
> > And this is a bug that was reported to be present in 2.6.21-rc but not
> > in 2.6.20 (and it's therefore a regression, no matter whether the
> > underlying problem was older and only exposed by some other change).
>
> Not true.  The DVB subsystem has NEVER been hot-unpluggable.  I confirm that
> the
> patches SEEM to be correct, but this has not yet been verified.  None of the
> authors of dvb-core gave their ACK on these changesets.
>
> The DVB hotplug issue has been around since the very beginning.  I assure
> you,
> that I consider this fix to be very important, and I really would love to
> see it
> hit mainline.  However, given the situation, it is not appropriate to push
> these
> in during -rc7
>
> I have doubts on CIJOML's testing method -- there is no way he could have
> unplugged the device while in use, while running 2.6.20.y and not receive an
> OOPS.  CIJOML, please see the bottom of this email for
>
> Sure, this will prevent an OOPS on some, and hopefully all devices...  but
> what
> if it causes a regression for those untested?
>
> Why do we have a merge window, if new changesets are going to be rushed into
> late -rc kernels without proper testing, and without the ack of a dvb
> subsystem
> maintainer?
>
> Are we prepared to go for another -rc and 3 or 4 weeks of testing to confirm
> that this fix doesn't cause new regressions?  I don't think so.
>

The problem I see with the cinergyT2 is that this driver reimplements
the frontend code and doesn't even use the dvb-core template, so a
proper fix would also be to reimplement that fix in the cinergyT2
device.
I don't think Daniel Mack or Holger Waechtler manage this driver
anymore because they didn't comment the last few fixes that were
applied to that driver (though I put them into CC here) As far as I
remember someone wrote that they didn't want to use the dvb_frontend
code back then for any reason.

So the only driver I'd take into account would be the flexcop driver.

Currently tested drivers are: dvb-usb based devices, and em28xx/em2880
based devices

Markus

>
> Markus Rechberger wrote:
> > The patch has been around on the dvb mailinglist ([PATCH][RFC] DVB
> > Hotplug Fix, 5. April 2007),
>
> The patch was merged into the development repository at the same time the
> pull
> request was issued to Linus.  This has NOT been tested on a wide scale.  It
> should go to -mm for a while before being merged to mainline.
>
> Mauro Carvalho Chehab wrote:
> > I also explicitly warned at DVB ML that I were about to send this patch,
> > together with other fixes, asking the community for more tests. After
> > that, I received two positive answers on my mailbox from people that
> > tested and noticed that this really fixed the issue.
>
> One of those positive answers was me -  I explained that it worked for me,
> but
> we need others to test.
>
> You waited ONE DAY after sending this "warning" to the dvb mailing list?  (
> http://linuxtv.org/pipermail/linux-dvb/2007-April/017204.html ) I saw that
> email
> after seeing the pull request to Linus.  We dont have users testing the
> repositories after each commit -- you _really_ need to give some more time
> to
> allow for such testing.
>
> CIJOML wrote:
> > Hi,
> >
> > I have tested these patches with:
> >
> > Freecom DVB-T dongle
> > Pluto2 pcmcia card
> > Leadtek WinFast DTV dongle 1st generation
> > Leadtek WinFast DTV dongle 2nd generation
> >
> > These are 4 different devices with 4 different hw and modules.
> > All works. Please apply.
>
> Well, that helps...  But it would still be nice to hear test results on a
> CinergyT2 or flexcop-usb.
>
> Which driver supports those Winfast dongles?  We already know for sure that
> the
> patches work correctly for any driver based on the dvb-usb framework.
>
> If you had the device open, and then disconnect it from the usb bus, no
> matter
> what kernel version you're running, you should hit the OOPS.  I confirm that
> these patches prevent that OOPS from occurring, but I have trouble believing
> that you did NOT experience such an OOPS in 2.6.20.y
>
> Could you please describe the method in which your test caused an OOPS using
> 2.6.21-rc and did NOT cause an oops in 2.6.20.y ?
>
> --
> Michael Krufky
>
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
>


-- 
Markus Rechberger

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16 15:34     ` Michael Krufky
  2007-04-16 16:16       ` Markus Rechberger
@ 2007-04-16 16:18       ` CIJOML
  2007-04-16 16:25         ` Michael Krufky
  1 sibling, 1 reply; 31+ messages in thread
From: CIJOML @ 2007-04-16 16:18 UTC (permalink / raw)
  To: Michael Krufky
  Cc: Adrian Bunk, video4linux-list, linux-kernel,
	Mauro Carvalho Chehab, linux-dvb-maintainer, Andrew Morton,
	Linus Torvalds

Dne pondělí 16 duben 2007 17:34 Michael Krufky napsal(a):
> Adrian Bunk wrote:
> > On Sun, Apr 15, 2007 at 08:33:38PM -0400, Michael Krufky wrote:
> >> Mauro,
> >>
> >> I've been out of town for the past few days... I just got home and saw
> >> this:
> >>
> >> Mauro Carvalho Chehab wrote:
> >>>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
> >>>    - Fix 2/3 for bug 7819: demux and dvr
> >>>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> >>
> >> I don't think that this is 2.6.21 material.  These patches have not yet
> >> received
> >> enough testing to be sent to mainline.
> >>
> >> I have tested them, and they seem to work for my cxusb device, but we
> >> have yet to hear test results from users of usb dvb devices that do not
> >> use the dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
> >>
> >> The bug that these patches fix has been around throughout the entire
> >> kernel history of the dvb subsystem.  The bug is not a regression -- it
> >> has always been
> >> there.  In my opinion, it is too late in 2.6.21 development to apply
> >> this change.
> >> Because these fixes are not obvious, I think we should let them get some
> >> more testing, and have them queued for 2.6.22 .
> >
> > Unless I misunderstand anything, this should fix [1].
> >
> > And this is a bug that was reported to be present in 2.6.21-rc but not
> > in 2.6.20 (and it's therefore a regression, no matter whether the
> > underlying problem was older and only exposed by some other change).
>
> Not true.  The DVB subsystem has NEVER been hot-unpluggable.  I confirm
> that the patches SEEM to be correct, but this has not yet been verified. 
> None of the authors of dvb-core gave their ACK on these changesets.
>
> The DVB hotplug issue has been around since the very beginning.  I assure
> you, that I consider this fix to be very important, and I really would love
> to see it hit mainline.  However, given the situation, it is not
> appropriate to push these in during -rc7
>
> I have doubts on CIJOML's testing method -- there is no way he could have
> unplugged the device while in use, while running 2.6.20.y and not receive
> an OOPS.  CIJOML, please see the bottom of this email for
>
> Sure, this will prevent an OOPS on some, and hopefully all devices...  but
> what if it causes a regression for those untested?
>
> Why do we have a merge window, if new changesets are going to be rushed
> into late -rc kernels without proper testing, and without the ack of a dvb
> subsystem maintainer?
>
> Are we prepared to go for another -rc and 3 or 4 weeks of testing to
> confirm that this fix doesn't cause new regressions?  I don't think so.
>
> Markus Rechberger wrote:
> > The patch has been around on the dvb mailinglist ([PATCH][RFC] DVB
> > Hotplug Fix, 5. April 2007),
>
> The patch was merged into the development repository at the same time the
> pull request was issued to Linus.  This has NOT been tested on a wide
> scale.  It should go to -mm for a while before being merged to mainline.
>
> Mauro Carvalho Chehab wrote:
> > I also explicitly warned at DVB ML that I were about to send this patch,
> > together with other fixes, asking the community for more tests. After
> > that, I received two positive answers on my mailbox from people that
> > tested and noticed that this really fixed the issue.
>
> One of those positive answers was me -  I explained that it worked for me,
> but we need others to test.
>
> You waited ONE DAY after sending this "warning" to the dvb mailing list?  (
> http://linuxtv.org/pipermail/linux-dvb/2007-April/017204.html ) I saw that
> email after seeing the pull request to Linus.  We dont have users testing
> the repositories after each commit -- you _really_ need to give some more
> time to allow for such testing.
>
> CIJOML wrote:
> > Hi,
> >
> > I have tested these patches with:
> >
> > Freecom DVB-T dongle
> > Pluto2 pcmcia card
> > Leadtek WinFast DTV dongle 1st generation
> > Leadtek WinFast DTV dongle 2nd generation
> >
> > These are 4 different devices with 4 different hw and modules.
> > All works. Please apply.
>
> Well, that helps...  But it would still be nice to hear test results on a
> CinergyT2 or flexcop-usb.
>
> Which driver supports those Winfast dongles?  We already know for sure that
> the patches work correctly for any driver based on the dvb-usb framework.
>
> If you had the device open, and then disconnect it from the usb bus, no
> matter what kernel version you're running, you should hit the OOPS.  I
> confirm that these patches prevent that OOPS from occurring, but I have
> trouble believing that you did NOT experience such an OOPS in 2.6.20.y
>
> Could you please describe the method in which your test caused an OOPS
> using 2.6.21-rc and did NOT cause an oops in 2.6.20.y ?

Hi,

I have tested these patches with 2.6.20-mh1 + v4l-dvb-b5be3479f070 patchset.
I also tried 2.6.21-rc6 + v4l-dvb-b5be3479f070 patchset and this combination 
also works without OOPS.

Winfast dongles are both dvb-usb based (DiBcom 3000M-C and DiBcom DiB7000P), 
but pluto2 is cardbus (pci) based.

I think we can include these patches into 2.6.21 and if we receive any 
problem, we still have 2.6.21.Z for fixing, don't we?

Michal

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16 16:18       ` CIJOML
@ 2007-04-16 16:25         ` Michael Krufky
  2007-04-16 22:15           ` hermann pitton
  2007-04-17  3:42           ` Mauro Carvalho Chehab
  0 siblings, 2 replies; 31+ messages in thread
From: Michael Krufky @ 2007-04-16 16:25 UTC (permalink / raw)
  To: CIJOML
  Cc: Michael Krufky, Adrian Bunk, video4linux-list, linux-kernel,
	Mauro Carvalho Chehab, linux-dvb-maintainer, Andrew Morton,
	Linus Torvalds

CIJOML wrote:
> Dne pondělí 16 duben 2007 17:34 Michael Krufky napsal(a):
>   
>> Adrian Bunk wrote:
>>     
>>> On Sun, Apr 15, 2007 at 08:33:38PM -0400, Michael Krufky wrote:
>>>       
>>>> Mauro,
>>>>
>>>> I've been out of town for the past few days... I just got home and saw
>>>> this:
>>>>
>>>> Mauro Carvalho Chehab wrote:
>>>>         
>>>>>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
>>>>>    - Fix 2/3 for bug 7819: demux and dvr
>>>>>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
>>>>>           
>>>> I don't think that this is 2.6.21 material.  These patches have not yet
>>>> received
>>>> enough testing to be sent to mainline.
>>>>
>>>> I have tested them, and they seem to work for my cxusb device, but we
>>>> have yet to hear test results from users of usb dvb devices that do not
>>>> use the dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
>>>>
>>>> The bug that these patches fix has been around throughout the entire
>>>> kernel history of the dvb subsystem.  The bug is not a regression -- it
>>>> has always been
>>>> there.  In my opinion, it is too late in 2.6.21 development to apply
>>>> this change.
>>>> Because these fixes are not obvious, I think we should let them get some
>>>> more testing, and have them queued for 2.6.22 .
>>>>         
>>> Unless I misunderstand anything, this should fix [1].
>>>
>>> And this is a bug that was reported to be present in 2.6.21-rc but not
>>> in 2.6.20 (and it's therefore a regression, no matter whether the
>>> underlying problem was older and only exposed by some other change).
>>>       
>> Not true.  The DVB subsystem has NEVER been hot-unpluggable.  I confirm
>> that the patches SEEM to be correct, but this has not yet been verified. 
>> None of the authors of dvb-core gave their ACK on these changesets.
>>
>> The DVB hotplug issue has been around since the very beginning.  I assure
>> you, that I consider this fix to be very important, and I really would love
>> to see it hit mainline.  However, given the situation, it is not
>> appropriate to push these in during -rc7
>>
>> I have doubts on CIJOML's testing method -- there is no way he could have
>> unplugged the device while in use, while running 2.6.20.y and not receive
>> an OOPS.  CIJOML, please see the bottom of this email for
>>
>> Sure, this will prevent an OOPS on some, and hopefully all devices...  but
>> what if it causes a regression for those untested?
>>
>> Why do we have a merge window, if new changesets are going to be rushed
>> into late -rc kernels without proper testing, and without the ack of a dvb
>> subsystem maintainer?
>>
>> Are we prepared to go for another -rc and 3 or 4 weeks of testing to
>> confirm that this fix doesn't cause new regressions?  I don't think so.
>>
>> Markus Rechberger wrote:
>>     
>>> The patch has been around on the dvb mailinglist ([PATCH][RFC] DVB
>>> Hotplug Fix, 5. April 2007),
>>>       
>> The patch was merged into the development repository at the same time the
>> pull request was issued to Linus.  This has NOT been tested on a wide
>> scale.  It should go to -mm for a while before being merged to mainline.
>>
>> Mauro Carvalho Chehab wrote:
>>     
>>> I also explicitly warned at DVB ML that I were about to send this patch,
>>> together with other fixes, asking the community for more tests. After
>>> that, I received two positive answers on my mailbox from people that
>>> tested and noticed that this really fixed the issue.
>>>       
>> One of those positive answers was me -  I explained that it worked for me,
>> but we need others to test.
>>
>> You waited ONE DAY after sending this "warning" to the dvb mailing list?  (
>> http://linuxtv.org/pipermail/linux-dvb/2007-April/017204.html ) I saw that
>> email after seeing the pull request to Linus.  We dont have users testing
>> the repositories after each commit -- you _really_ need to give some more
>> time to allow for such testing.
>>
>> CIJOML wrote:
>>     
>>> Hi,
>>>
>>> I have tested these patches with:
>>>
>>> Freecom DVB-T dongle
>>> Pluto2 pcmcia card
>>> Leadtek WinFast DTV dongle 1st generation
>>> Leadtek WinFast DTV dongle 2nd generation
>>>
>>> These are 4 different devices with 4 different hw and modules.
>>> All works. Please apply.
>>>       
>> Well, that helps...  But it would still be nice to hear test results on a
>> CinergyT2 or flexcop-usb.
>>
>> Which driver supports those Winfast dongles?  We already know for sure that
>> the patches work correctly for any driver based on the dvb-usb framework.
>>
>> If you had the device open, and then disconnect it from the usb bus, no
>> matter what kernel version you're running, you should hit the OOPS.  I
>> confirm that these patches prevent that OOPS from occurring, but I have
>> trouble believing that you did NOT experience such an OOPS in 2.6.20.y
>>
>> Could you please describe the method in which your test caused an OOPS
>> using 2.6.21-rc and did NOT cause an oops in 2.6.20.y ?
>>     
>
> Hi,
>
> I have tested these patches with 2.6.20-mh1 + v4l-dvb-b5be3479f070 patchset.
> I also tried 2.6.21-rc6 + v4l-dvb-b5be3479f070 patchset and this combination 
> also works without OOPS.
>   
Yes, that shows that the changesets prevent the oops, but it says
nothing about vanilla 2.6.20.y
> Winfast dongles are both dvb-usb based (DiBcom 3000M-C and DiBcom DiB7000P), 
> but pluto2 is cardbus (pci) based.
>   
just as I figured.  The pluto2 test results are great to hear, though --
thank you.
> I think we can include these patches into 2.6.21 and if we receive any 
> problem, we still have 2.6.21.Z for fixing, don't we?

The stable kernel series is not there for that purpose.  It is not there
to encourage a rush of patches into a final kernel release, only to
cause potential problems, with the 2.6.x.y series as a fallback for
fixes.  We should avoid the need for such last-minute fixes wherever
possible.

-- 
Michael Krufky



^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] Re: [GIT PATCHES] V4L/DVB updates
  2007-04-16 15:50 ` Dmitry Torokhov
@ 2007-04-16 21:49   ` Trent Piepho
  0 siblings, 0 replies; 31+ messages in thread
From: Trent Piepho @ 2007-04-16 21:49 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Mauro Carvalho Chehab, linux-dvb-maintainer, Andrew Morton,
	Linus Torvalds, video4linux-list, linux-kernel

On Mon, 16 Apr 2007, Dmitry Torokhov wrote:
> Hi Mauro,
>
> On 4/15/07, Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
> >   - Fix Kernel Bugzilla #8301: spinlock fix for flexcop-pci
>
> While move of spin_lock_init before request_irq is obviously correct I
> wonder what is the reason behind changing spin_lock_irq() into
> spin_lock_irqsave() as I do not see flexcop_pci_isr being called from
> anywhere but IRQ context.
>
> BTW, is irq_lock needed at all?

There was some more discussion on the linux-dvb list
http://www.linuxtv.org/pipermail/linux-dvb/2007-April/017024.html , and I
think we came to the conclusion that irq_lock isn't needed at all.  It does
nothing but serialize the ISR and ISRs are automatically serialized by the
kernel.

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16 16:25         ` Michael Krufky
@ 2007-04-16 22:15           ` hermann pitton
  2007-04-17  3:42           ` Mauro Carvalho Chehab
  1 sibling, 0 replies; 31+ messages in thread
From: hermann pitton @ 2007-04-16 22:15 UTC (permalink / raw)
  To: Michael Krufky
  Cc: CIJOML, video4linux-list, linux-kernel, Mauro Carvalho Chehab,
	linux-dvb-maintainer, Andrew Morton, Adrian Bunk, Linus Torvalds

Am Montag, den 16.04.2007, 12:25 -0400 schrieb Michael Krufky:
> CIJOML wrote:
> > Dne pondělí 16 duben 2007 17:34 Michael Krufky napsal(a):
> >   
> >> Adrian Bunk wrote:
> >>     
> >>> On Sun, Apr 15, 2007 at 08:33:38PM -0400, Michael Krufky wrote:
> >>>       
> >>>> Mauro,
> >>>>
> >>>> I've been out of town for the past few days... I just got home and saw
> >>>> this:
> >>>>
> >>>> Mauro Carvalho Chehab wrote:
> >>>>         
> >>>>>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
> >>>>>    - Fix 2/3 for bug 7819: demux and dvr
> >>>>>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> >>>>>           
> >>>> I don't think that this is 2.6.21 material.  These patches have not yet
> >>>> received
> >>>> enough testing to be sent to mainline.
> >>>>
> >>>> I have tested them, and they seem to work for my cxusb device, but we
> >>>> have yet to hear test results from users of usb dvb devices that do not
> >>>> use the dvb-usb framework.  (ttusb, flexcop-usb, cinergyT2, for example)
> >>>>
> >>>> The bug that these patches fix has been around throughout the entire
> >>>> kernel history of the dvb subsystem.  The bug is not a regression -- it
> >>>> has always been
> >>>> there.  In my opinion, it is too late in 2.6.21 development to apply
> >>>> this change.
> >>>> Because these fixes are not obvious, I think we should let them get some
> >>>> more testing, and have them queued for 2.6.22 .
> >>>>         
> >>> Unless I misunderstand anything, this should fix [1].
> >>>
> >>> And this is a bug that was reported to be present in 2.6.21-rc but not
> >>> in 2.6.20 (and it's therefore a regression, no matter whether the
> >>> underlying problem was older and only exposed by some other change).
> >>>       
> >> Not true.  The DVB subsystem has NEVER been hot-unpluggable.  I confirm
> >> that the patches SEEM to be correct, but this has not yet been verified. 
> >> None of the authors of dvb-core gave their ACK on these changesets.
> >>
> >> The DVB hotplug issue has been around since the very beginning.  I assure
> >> you, that I consider this fix to be very important, and I really would love
> >> to see it hit mainline.  However, given the situation, it is not
> >> appropriate to push these in during -rc7
> >>
> >> I have doubts on CIJOML's testing method -- there is no way he could have
> >> unplugged the device while in use, while running 2.6.20.y and not receive
> >> an OOPS.  CIJOML, please see the bottom of this email for
> >>
> >> Sure, this will prevent an OOPS on some, and hopefully all devices...  but
> >> what if it causes a regression for those untested?
> >>
> >> Why do we have a merge window, if new changesets are going to be rushed
> >> into late -rc kernels without proper testing, and without the ack of a dvb
> >> subsystem maintainer?
> >>
> >> Are we prepared to go for another -rc and 3 or 4 weeks of testing to
> >> confirm that this fix doesn't cause new regressions?  I don't think so.
> >>
> >> Markus Rechberger wrote:
> >>     
> >>> The patch has been around on the dvb mailinglist ([PATCH][RFC] DVB
> >>> Hotplug Fix, 5. April 2007),
> >>>       
> >> The patch was merged into the development repository at the same time the
> >> pull request was issued to Linus.  This has NOT been tested on a wide
> >> scale.  It should go to -mm for a while before being merged to mainline.
> >>
> >> Mauro Carvalho Chehab wrote:
> >>     
> >>> I also explicitly warned at DVB ML that I were about to send this patch,
> >>> together with other fixes, asking the community for more tests. After
> >>> that, I received two positive answers on my mailbox from people that
> >>> tested and noticed that this really fixed the issue.
> >>>       
> >> One of those positive answers was me -  I explained that it worked for me,
> >> but we need others to test.
> >>
> >> You waited ONE DAY after sending this "warning" to the dvb mailing list?  (
> >> http://linuxtv.org/pipermail/linux-dvb/2007-April/017204.html ) I saw that
> >> email after seeing the pull request to Linus.  We dont have users testing
> >> the repositories after each commit -- you _really_ need to give some more
> >> time to allow for such testing.
> >>
> >> CIJOML wrote:
> >>     
> >>> Hi,
> >>>
> >>> I have tested these patches with:
> >>>
> >>> Freecom DVB-T dongle
> >>> Pluto2 pcmcia card
> >>> Leadtek WinFast DTV dongle 1st generation
> >>> Leadtek WinFast DTV dongle 2nd generation
> >>>
> >>> These are 4 different devices with 4 different hw and modules.
> >>> All works. Please apply.
> >>>       
> >> Well, that helps...  But it would still be nice to hear test results on a
> >> CinergyT2 or flexcop-usb.
> >>
> >> Which driver supports those Winfast dongles?  We already know for sure that
> >> the patches work correctly for any driver based on the dvb-usb framework.
> >>
> >> If you had the device open, and then disconnect it from the usb bus, no
> >> matter what kernel version you're running, you should hit the OOPS.  I
> >> confirm that these patches prevent that OOPS from occurring, but I have
> >> trouble believing that you did NOT experience such an OOPS in 2.6.20.y
> >>
> >> Could you please describe the method in which your test caused an OOPS
> >> using 2.6.21-rc and did NOT cause an oops in 2.6.20.y ?
> >>     
> >
> > Hi,
> >
> > I have tested these patches with 2.6.20-mh1 + v4l-dvb-b5be3479f070 patchset.
> > I also tried 2.6.21-rc6 + v4l-dvb-b5be3479f070 patchset and this combination 
> > also works without OOPS.
> >   
> Yes, that shows that the changesets prevent the oops, but it says
> nothing about vanilla 2.6.20.y
> > Winfast dongles are both dvb-usb based (DiBcom 3000M-C and DiBcom DiB7000P), 
> > but pluto2 is cardbus (pci) based.
> >   
> just as I figured.  The pluto2 test results are great to hear, though --
> thank you.
> > I think we can include these patches into 2.6.21 and if we receive any 
> > problem, we still have 2.6.21.Z for fixing, don't we?
> 
> The stable kernel series is not there for that purpose.  It is not there
> to encourage a rush of patches into a final kernel release, only to
> cause potential problems, with the 2.6.x.y series as a fallback for
> fixes.  We should avoid the need for such last-minute fixes wherever
> possible.
> 

Hi,

there is still this simple word missing.

This was/is the most annoying always ever reported bug I can remember of
through aeons.

             the simple word is

"thanks" Markus, for trying to fix it.

Cheers,
Hermann





^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16 16:25         ` Michael Krufky
  2007-04-16 22:15           ` hermann pitton
@ 2007-04-17  3:42           ` Mauro Carvalho Chehab
  1 sibling, 0 replies; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-04-17  3:42 UTC (permalink / raw)
  To: Michael Krufky
  Cc: CIJOML, Adrian Bunk, video4linux-list, linux-kernel,
	linux-dvb-maintainer, Andrew Morton, Linus Torvalds

> > I have tested these patches with 2.6.20-mh1 + v4l-dvb-b5be3479f070 patchset.
> > I also tried 2.6.21-rc6 + v4l-dvb-b5be3479f070 patchset and this combination 
> > also works without OOPS.
> >   
> Yes, that shows that the changesets prevent the oops, but it says
> nothing about vanilla 2.6.20.y
> > Winfast dongles are both dvb-usb based (DiBcom 3000M-C and DiBcom DiB7000P), 
> > but pluto2 is cardbus (pci) based.
> >   
> just as I figured.  The pluto2 test results are great to hear, though --
> thank you.
> > I think we can include these patches into 2.6.21 and if we receive any 
> > problem, we still have 2.6.21.Z for fixing, don't we?
> 
> The stable kernel series is not there for that purpose.  It is not there
> to encourage a rush of patches into a final kernel release, only to
> cause potential problems, with the 2.6.x.y series as a fallback for
> fixes.  We should avoid the need for such last-minute fixes wherever
> possible.
For sure we should do the best to avoid regressions. But, IMO, a driver
for a hotpluggable device (USB) that can't support device hot plug is a
serious issue. 

If nobody have an issue pointing regressions on this, we should really
apply the fix for 2.6.21.

-- 
Cheers,
Mauro


^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-16 16:16       ` Markus Rechberger
@ 2007-04-27 21:34         ` Trent Piepho
  2007-04-27 22:43           ` Markus Rechberger
  0 siblings, 1 reply; 31+ messages in thread
From: Trent Piepho @ 2007-04-27 21:34 UTC (permalink / raw)
  To: Markus Rechberger
  Cc: Michael Krufky, Linux and Kernel Video,
	Linux Kernel Mailing list, Mauro Carvalho Chehab,
	linux-dvb-maintainer

On Mon, 16 Apr 2007, Markus Rechberger wrote:
> On 4/16/07, Michael Krufky <mkrufky@linuxtv.org> wrote:
> > Adrian Bunk wrote:
> > > On Sun, Apr 15, 2007 at 08:33:38PM -0400, Michael Krufky wrote:
> > >> Mauro,
> > >>
> > >> I've been out of town for the past few days... I just got home and saw
> > this:
> > >>
> > >>
> > >> Mauro Carvalho Chehab wrote:
> > >>>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
> > >>>    - Fix 2/3 for bug 7819: demux and dvr
> > >>>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> > >> I don't think that this is 2.6.21 material.  These patches have not yet
> > >> received
> > >> enough testing to be sent to mainline.

I wish these patches had more comments about how they worked, because it's
not clear to me exactly what they are doing or why they do it.

Fix 3/3 for bug 7819: fixed hotplugging for dvbnet

I'm just going to talk about this one patch, since it appears to be the
simplest.

This patch removes the 'wait_queue' memory of dvb_demux.  Why does a patch
to dvbnet have anything to do with the demux device?  Should this change
have been part of the previous patch, the one what fixes demux and dvr?

The patch replace the (file_operations)->release pointer with the new
function dvb_net_close() in place of dvb_generic_release().  The first
part of dvb_net_close() is just a cut&paste from dvb_generic_release(),
so maybe it would be better to just call dvb_generic_release() instead?

There is also a bug:

+static int dvb_net_close(struct inode *inode, struct file *file)
+{
+       struct dvb_device *dvbdev = file->private_data;
+       struct dvb_net *dvbnet = dvbdev->priv;
+
+       if (!dvbdev)
+               return -ENODEV;

The check for !dvbdev is too late, dvbdev was already dereferenced on the
previous line to get dvbnet, so if dvbdev is NULL you will have already
crashed.

Is the check for !dvbdev unnecessary paranoia?  Or can dvbdev actually be
NULL is some cases?

So, w.r.t. dvbnet, my understanding is that somehow dvb_net_release() is
called while the net device is still in use.  Is that correct?
dvb_net_release() will end up deleting some stuff that needs to be around
while there is still a user of the device?

Would it be possible to keep dvb_net_release() from getting called in the
first place until there are no users of the device?

When looking at this code, keep in mind that users starts at 1 and goes
down as the device is used.

void dvb_net_release (struct dvb_net *dvbnet)
{
        int i;

        dvbnet->exit = 1;
        if (dvbnet->dvbdev->users < 1)		/* line A */
                wait_event(dvbnet->dvbdev->wait_queue,  /* line B */
                                dvbnet->dvbdev->users==1);
	/* line C */
        dvb_unregister_device(dvbnet->dvbdev);
	[...]
}

Isn't there a race condition here?  What if there are no users of the
device at the time line A runs, but the device is opened before line C
runs?  After the wait_even() on line B returns there are no users, but what
if new users opens the device after the after line B?

Is seems like you need something to prevent new users from opening the
device, i.e. make it so that dvbnet->exit=1 prevents the device from
getting opened, but if that's the intention, I don't see where it's
happening.

In dvb_net_close():

+       if(dvbdev->users == 1 && dvbnet->exit==1) {
+               fops_put(file->f_op);
+               file->f_op = NULL;
+               wake_up(&dvbdev->wait_queue);
+       }

What is the purpose of the fops_put() call and setting file->f_op to NULL?

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-27 21:34         ` Trent Piepho
@ 2007-04-27 22:43           ` Markus Rechberger
  2007-04-28  6:33             ` Trent Piepho
  0 siblings, 1 reply; 31+ messages in thread
From: Markus Rechberger @ 2007-04-27 22:43 UTC (permalink / raw)
  To: Trent Piepho
  Cc: Michael Krufky, Linux and Kernel Video,
	Linux Kernel Mailing list, Mauro Carvalho Chehab,
	linux-dvb-maintainer

On 4/27/07, Trent Piepho <xyzzy@speakeasy.org> wrote:
> On Mon, 16 Apr 2007, Markus Rechberger wrote:
> > On 4/16/07, Michael Krufky <mkrufky@linuxtv.org> wrote:
> > > Adrian Bunk wrote:
> > > > On Sun, Apr 15, 2007 at 08:33:38PM -0400, Michael Krufky wrote:
> > > >> Mauro,
> > > >>
> > > >> I've been out of town for the past few days... I just got home and
> saw
> > > this:
> > > >>
> > > >>
> > > >> Mauro Carvalho Chehab wrote:
> > > >>>    - Fix 1/3 for bug 7819: fixed frontend hotplug issue
> > > >>>    - Fix 2/3 for bug 7819: demux and dvr
> > > >>>    - Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> > > >> I don't think that this is 2.6.21 material.  These patches have not
> yet
> > > >> received
> > > >> enough testing to be sent to mainline.
>
> I wish these patches had more comments about how they worked, because it's
> not clear to me exactly what they are doing or why they do it.
>
> Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
>
> I'm just going to talk about this one patch, since it appears to be the
> simplest.
>
> This patch removes the 'wait_queue' memory of dvb_demux.  Why does a patch
> to dvbnet have anything to do with the demux device?  Should this change
> have been part of the previous patch, the one what fixes demux and dvr?
>

The waitqueue got added in a previous patch just ignore it..

> The patch replace the (file_operations)->release pointer with the new
> function dvb_net_close() in place of dvb_generic_release().  The first
> part of dvb_net_close() is just a cut&paste from dvb_generic_release(),
> so maybe it would be better to just call dvb_generic_release() instead?
>

no because it needs the dvb_net structure which cannot be used in the
dvb_generic_release function.

> There is also a bug:
>
> +static int dvb_net_close(struct inode *inode, struct file *file)
> +{
> +       struct dvb_device *dvbdev = file->private_data;
> +       struct dvb_net *dvbnet = dvbdev->priv;
> +
> +       if (!dvbdev)
> +               return -ENODEV;
>
> The check for !dvbdev is too late, dvbdev was already dereferenced on the
> previous line to get dvbnet, so if dvbdev is NULL you will have already
> crashed.
>

I think this check isn't needed at all actually, why should someone
release dvbdev before already?

> Is the check for !dvbdev unnecessary paranoia?  Or can dvbdev actually be
> NULL is some cases?
>
> So, w.r.t. dvbnet, my understanding is that somehow dvb_net_release() is
> called while the net device is still in use.  Is that correct?
> dvb_net_release() will end up deleting some stuff that needs to be around
> while there is still a user of the device?
>
> Would it be possible to keep dvb_net_release() from getting called in the
> first place until there are no users of the device?
>
> When looking at this code, keep in mind that users starts at 1 and goes
> down as the device is used.
>
> void dvb_net_release (struct dvb_net *dvbnet)
> {
>         int i;
>
>         dvbnet->exit = 1;
>         if (dvbnet->dvbdev->users < 1)		/* line A */
>                 wait_event(dvbnet->dvbdev->wait_queue,  /* line B */
>                                 dvbnet->dvbdev->users==1);
> 	/* line C */
>         dvb_unregister_device(dvbnet->dvbdev);
> 	[...]
> }
>
> Isn't there a race condition here?  What if there are no users of the
> device at the time line A runs, but the device is opened before line C
> runs?  After the wait_even() on line B returns there are no users, but what
> if new users opens the device after the after line B?
>

yes this is a valid argument, practically it will never occure though.
Since I also wrote that I didn't have a dvb signal at the time of
writing this I don't even know if the dvb-net implementation is ok at
all.
I don't even know if that part of the framework works and if someone
really uses it.

> Is seems like you need something to prevent new users from opening the
> device, i.e. make it so that dvbnet->exit=1 prevents the device from
> getting opened, but if that's the intention, I don't see where it's
> happening.
>
> In dvb_net_close():
>
> +       if(dvbdev->users == 1 && dvbnet->exit==1) {
> +               fops_put(file->f_op);
> +               file->f_op = NULL;
> +               wake_up(&dvbdev->wait_queue);
> +       }
>
> What is the purpose of the fops_put() call and setting file->f_op to NULL?
>

fops_put lowers the usecount on the inode, after wake_up the f_op
structure is invalid because it's just allocated memory which gets
freed by the dvb release function.

thanks for reviewing,
Markus

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-27 22:43           ` Markus Rechberger
@ 2007-04-28  6:33             ` Trent Piepho
  2007-04-28  9:47               ` Markus Rechberger
  0 siblings, 1 reply; 31+ messages in thread
From: Trent Piepho @ 2007-04-28  6:33 UTC (permalink / raw)
  To: Markus Rechberger
  Cc: Michael Krufky, Linux and Kernel Video,
	Linux Kernel Mailing list, Mauro Carvalho Chehab,
	linux-dvb-maintainer

On Sat, 28 Apr 2007, Markus Rechberger wrote:
> On 4/27/07, Trent Piepho <xyzzy@speakeasy.org> wrote:
> > On Mon, 16 Apr 2007, Markus Rechberger wrote:
> > > > >> enough testing to be sent to mainline.
> >
> > I wish these patches had more comments about how they worked, because it's
> > not clear to me exactly what they are doing or why they do it.
> >
> > Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> >
> > I'm just going to talk about this one patch, since it appears to be the
> > simplest.
> >
> > This patch removes the 'wait_queue' memory of dvb_demux.  Why does a patch
> > to dvbnet have anything to do with the demux device?  Should this change
> > have been part of the previous patch, the one what fixes demux and dvr?
> >
>
> The waitqueue got added in a previous patch just ignore it..

Do the patches need to be applied all together?  If I apply just the first
two, do I get something that's broken?

> > The patch replace the (file_operations)->release pointer with the new
> > function dvb_net_close() in place of dvb_generic_release().  The first
> > part of dvb_net_close() is just a cut&paste from dvb_generic_release(),
> > so maybe it would be better to just call dvb_generic_release() instead?
> >
>
> no because it needs the dvb_net structure which cannot be used in the
> dvb_generic_release function.

I mean, have dvb_net_close() call dvb_generic_release() and then do the
extra stuff.

> > There is also a bug:
> >
> > +static int dvb_net_close(struct inode *inode, struct file *file)
> > +{
> > +       struct dvb_device *dvbdev = file->private_data;
> > +       struct dvb_net *dvbnet = dvbdev->priv;
> > +
> > +       if (!dvbdev)
> > +               return -ENODEV;
> >
> > The check for !dvbdev is too late, dvbdev was already dereferenced on the
> > previous line to get dvbnet, so if dvbdev is NULL you will have already
> > crashed.
> >
>
> I think this check isn't needed at all actually, why should someone
> release dvbdev before already?
>
> > Is the check for !dvbdev unnecessary paranoia?  Or can dvbdev actually be
> > NULL is some cases?
> >
> > So, w.r.t. dvbnet, my understanding is that somehow dvb_net_release() is
> > called while the net device is still in use.  Is that correct?
> > dvb_net_release() will end up deleting some stuff that needs to be around
> > while there is still a user of the device?
> >
> > Would it be possible to keep dvb_net_release() from getting called in the
> > first place until there are no users of the device?

What about this?  I don't have any hot pluggable hardware, so how does
dvb_net_release() get called when the device disconnects?

> > When looking at this code, keep in mind that users starts at 1 and goes
> > down as the device is used.
> >
> > void dvb_net_release (struct dvb_net *dvbnet)
> > {
> >         int i;
> >
> >         dvbnet->exit = 1;
> >         if (dvbnet->dvbdev->users < 1)		/* line A */
> >                 wait_event(dvbnet->dvbdev->wait_queue,  /* line B */
> >                                 dvbnet->dvbdev->users==1);
> > 	/* line C */
> >         dvb_unregister_device(dvbnet->dvbdev);
> > 	[...]
> > }
> >
> > Isn't there a race condition here?  What if there are no users of the
> > device at the time line A runs, but the device is opened before line C
> > runs?  After the wait_even() on line B returns there are no users, but what
> > if new users opens the device after the after line B?
> >
>
> yes this is a valid argument, practically it will never occure though.
> Since I also wrote that I didn't have a dvb signal at the time of
> writing this I don't even know if the dvb-net implementation is ok at
> all.
> I don't even know if that part of the framework works and if someone
> really uses it.
>
> > Is seems like you need something to prevent new users from opening the
> > device, i.e. make it so that dvbnet->exit=1 prevents the device from
> > getting opened, but if that's the intention, I don't see where it's
> > happening.
> >
> > In dvb_net_close():
> >
> > +       if(dvbdev->users == 1 && dvbnet->exit==1) {
> > +               fops_put(file->f_op);
> > +               file->f_op = NULL;
> > +               wake_up(&dvbdev->wait_queue);
> > +       }
> >
> > What is the purpose of the fops_put() call and setting file->f_op to NULL?
> >
>
> fops_put lowers the usecount on the inode, after wake_up the f_op
> structure is invalid because it's just allocated memory which gets
> freed by the dvb release function.

fopts_put() lowers the usecount of the module that owns the inode.  I don't
see how it works to add this when it wasn't here before?  Isn't it going to
mess up the module usecount by doing a fopts_put() that's not matched by a
fopts_get()?  I didn't see anything in your patch that added a fops_put().

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates
  2007-04-28  6:33             ` Trent Piepho
@ 2007-04-28  9:47               ` Markus Rechberger
  0 siblings, 0 replies; 31+ messages in thread
From: Markus Rechberger @ 2007-04-28  9:47 UTC (permalink / raw)
  To: Trent Piepho
  Cc: Michael Krufky, Linux and Kernel Video,
	Linux Kernel Mailing list, Mauro Carvalho Chehab,
	linux-dvb-maintainer

On 4/28/07, Trent Piepho <xyzzy@speakeasy.org> wrote:
> On Sat, 28 Apr 2007, Markus Rechberger wrote:
> > On 4/27/07, Trent Piepho <xyzzy@speakeasy.org> wrote:
> > > On Mon, 16 Apr 2007, Markus Rechberger wrote:
> > > > > >> enough testing to be sent to mainline.
> > >
> > > I wish these patches had more comments about how they worked, because
> it's
> > > not clear to me exactly what they are doing or why they do it.
> > >
> > > Fix 3/3 for bug 7819: fixed hotplugging for dvbnet
> > >
> > > I'm just going to talk about this one patch, since it appears to be the
> > > simplest.
> > >
> > > This patch removes the 'wait_queue' memory of dvb_demux.  Why does a
> patch
> > > to dvbnet have anything to do with the demux device?  Should this change
> > > have been part of the previous patch, the one what fixes demux and dvr?
> > >
> >
> > The waitqueue got added in a previous patch just ignore it..
>
> Do the patches need to be applied all together?  If I apply just the first
> two, do I get something that's broken?
>

yes very likely only because of this wait_queue..

> > > The patch replace the (file_operations)->release pointer with the new
> > > function dvb_net_close() in place of dvb_generic_release().  The first
> > > part of dvb_net_close() is just a cut&paste from dvb_generic_release(),
> > > so maybe it would be better to just call dvb_generic_release() instead?
> > >
> >
> > no because it needs the dvb_net structure which cannot be used in the
> > dvb_generic_release function.
>
> I mean, have dvb_net_close() call dvb_generic_release() and then do the
> extra stuff.
>
dvb_generic_release is really generic and has no information about the
dvb net structure if it's used for eg. the frontend

for example the dvb_frontend release function:
static int dvb_frontend_release(struct inode *inode, struct file *file)
{
        struct dvb_device *dvbdev = file->private_data;
        struct dvb_frontend *fe = dvbdev->priv;
        struct dvb_frontend_private *fepriv = fe->frontend_priv;

it would be possible to use dvb_release_generic if there wouldn't be
any reference to dvb_frontend and dvb_frontend_private.
In case of dvb-net it's a dvb_net specific release function by adding
the dvb_net structure.

If you look at dvb_generic_release it only uses dvb_device which is
really generic and used by all the dvb modules (frontend/dmx/..)

> > > There is also a bug:
> > >
> > > +static int dvb_net_close(struct inode *inode, struct file *file)
> > > +{
> > > +       struct dvb_device *dvbdev = file->private_data;
> > > +       struct dvb_net *dvbnet = dvbdev->priv;
> > > +
> > > +       if (!dvbdev)
> > > +               return -ENODEV;
> > >
> > > The check for !dvbdev is too late, dvbdev was already dereferenced on
> the
> > > previous line to get dvbnet, so if dvbdev is NULL you will have already
> > > crashed.
> > >
> >
> > I think this check isn't needed at all actually, why should someone
> > release dvbdev before already?
> >
> > > Is the check for !dvbdev unnecessary paranoia?  Or can dvbdev actually
> be
> > > NULL is some cases?
> > >
> > > So, w.r.t. dvbnet, my understanding is that somehow dvb_net_release() is
> > > called while the net device is still in use.  Is that correct?
> > > dvb_net_release() will end up deleting some stuff that needs to be
> around
> > > while there is still a user of the device?
> > >
> > > Would it be possible to keep dvb_net_release() from getting called in
> the
> > > first place until there are no users of the device?
>
> What about this?  I don't have any hot pluggable hardware, so how does
> dvb_net_release() get called when the device disconnects?
>

I don't understand, it's inode based if you open the file it will also
release the file if you close it.
If it's not hotpluggable it will not use the wait_queue because the
usecount would be 0 already when unloading the module.

> > > When looking at this code, keep in mind that users starts at 1 and goes
> > > down as the device is used.
> > >
> > > void dvb_net_release (struct dvb_net *dvbnet)
> > > {
> > >         int i;
> > >
> > >         dvbnet->exit = 1;
> > >         if (dvbnet->dvbdev->users < 1)		/* line A */
> > >                 wait_event(dvbnet->dvbdev->wait_queue,  /* line B */
> > >                                 dvbnet->dvbdev->users==1);
> > > 	/* line C */
> > >         dvb_unregister_device(dvbnet->dvbdev);
> > > 	[...]
> > > }
> > >
> > > Isn't there a race condition here?  What if there are no users of the
> > > device at the time line A runs, but the device is opened before line C
> > > runs?  After the wait_even() on line B returns there are no users, but
> what
> > > if new users opens the device after the after line B?
> > >
> >
> > yes this is a valid argument, practically it will never occure though.
> > Since I also wrote that I didn't have a dvb signal at the time of
> > writing this I don't even know if the dvb-net implementation is ok at
> > all.
> > I don't even know if that part of the framework works and if someone
> > really uses it.
> >
> > > Is seems like you need something to prevent new users from opening the
> > > device, i.e. make it so that dvbnet->exit=1 prevents the device from
> > > getting opened, but if that's the intention, I don't see where it's
> > > happening.
> > >
> > > In dvb_net_close():
> > >
> > > +       if(dvbdev->users == 1 && dvbnet->exit==1) {
> > > +               fops_put(file->f_op);
> > > +               file->f_op = NULL;
> > > +               wake_up(&dvbdev->wait_queue);
> > > +       }
> > >
> > > What is the purpose of the fops_put() call and setting file->f_op to
> NULL?
> > >
> >
> > fops_put lowers the usecount on the inode, after wake_up the f_op
> > structure is invalid because it's just allocated memory which gets
> > freed by the dvb release function.
>
> fopts_put() lowers the usecount of the module that owns the inode.  I don't
> see how it works to add this when it wasn't here before?  Isn't it going to
> mess up the module usecount by doing a fopts_put() that's not matched by a
> fopts_get()?  I didn't see anything in your patch that added a fops_put().
>

fops_put is nullpointer safe, the close() function remember the
allocated memory is gone after the release function deallocates the
memory.
What other module should own a usecount of it?

If you look at file_table.c:
        if (file->f_op && file->f_op->release)
                file->f_op->release(inode, file);
        security_file_free(file);
        if (unlikely(S_ISCHR(inode->i_mode) && inode->i_cdev != NULL))
                cdev_put(inode->i_cdev);
        fops_put(file->f_op); <- this would be invalid in our case
because the f_op structure gets deallocated earlier already so setting
it to NULL would prevent to lower the usecount.

first it calls file->f_op->release (our close/release function)
in the close/release function, while there's still a user the fops
deallocation is on hold.
As soon as the wake up function gets called the process will very
likely switch to the waked up procedure and it will immediatelly free
the f_ops structure. After cycling back to the close function we have
invalid memory and an invalid f_ops pointer.

Markus

^ permalink raw reply	[flat|nested] 31+ messages in thread

* [GIT PATCHES] V4L/DVB updates
@ 2008-03-20 15:18 Mauro Carvalho Chehab
  0 siblings, 0 replies; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2008-03-20 15:18 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, linux-dvb-maintainer, video4linux-list, linux-kernel

Linus,

Please pull from:
        ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master

For the following:

   - saa7134: fix FM radio support for the Pinnacle PCTV 110i
   - bttv: struct member initialized twice
   - ivtv: fix for yuv filter table check
   - VIDEO_VIVI must depend on VIDEO_DEV
   - cx88: Fix: Loads tuner module before sending commands to it
   - saa7134: fix: tuner should be loaded before calling saa7134_board_init2()
   - ivtv: Add missing sg_init_table()
   - em28xx: Correct use of ! and &
   - em28xx: correct use of and fix
   - usb/opera1.c: fix a memory leak
   - V4L1 - fix v4l_compat_translate_ioctl possible NULL deref
   - usb video: add a device link to usbvideo devices, else hal will ignore them
   - tvp5150.c: logical-bitwise and confusion
   - bug #10211: Fix depencencies for cx2341x

Cheers,
Mauro.

---

 drivers/media/dvb/dvb-usb/opera1.c          |    2 +-
 drivers/media/video/Kconfig                 |    4 +-
 drivers/media/video/bt8xx/bttv-driver.c     |    1 -
 drivers/media/video/cx88/cx88-cards.c       |    5 +++
 drivers/media/video/cx88/cx88-video.c       |    2 -
 drivers/media/video/em28xx/em28xx-core.c    |    2 +-
 drivers/media/video/ivtv/ivtv-driver.c      |    7 ++--
 drivers/media/video/ivtv/ivtv-firmware.c    |    8 +++-
 drivers/media/video/saa7134/saa7134-cards.c |   41 +++++++++++-----------
 drivers/media/video/saa7134/saa7134-core.c  |    5 ++-
 drivers/media/video/tvp5150.c               |    4 +-
 drivers/media/video/usbvideo/usbvideo.c     |    9 +++--
 drivers/media/video/v4l1-compat.c           |   50 ++++++++++++++++++++++-----
 13 files changed, 90 insertions(+), 50 deletions(-)

Adrian Bunk (2):
      V4L/DVB (7251): VIDEO_VIVI must depend on VIDEO_DEV
      V4L/DVB (7328): usb/opera1.c: fix a memory leak

Andrew Morton (1):
      V4L/DVB (7291): em28xx: correct use of and fix

Cyrill Gorcunov (1):
      V4L/DVB (7330): V4L1 - fix v4l_compat_translate_ioctl possible NULL deref

Harvey Harrison (1):
      V4L/DVB (7236): bttv: struct member initialized twice

Ian Armstrong (2):
      V4L/DVB (7242): ivtv: fix for yuv filter table check
      V4L/DVB (7279): ivtv: Add missing sg_init_table()

Julia Lawall (1):
      V4L/DVB (7285): em28xx: Correct use of ! and &

Mauro Carvalho Chehab (3):
      V4L/DVB (7267): cx88: Fix: Loads tuner module before sending commands to it
      V4L/DVB (7268): saa7134: fix: tuner should be loaded before calling saa7134_board_init2()
      V4L/DVB (7367): bug #10211: Fix depencencies for cx2341x

Pascal Terjan (1):
      V4L/DVB (7334): usb video: add a device link to usbvideo devices, else hal will ignore them

Roel Kluin (1):
      V4L/DVB (7362): tvp5150.c: logical-bitwise and confusion

Yuri Funduryan (1):
      V4L/DVB (7228): saa7134: fix FM radio support for the Pinnacle PCTV 110i

---------------------------------------------------
V4L/DVB development is hosted at http://linuxtv.org

^ permalink raw reply	[flat|nested] 31+ messages in thread

* [GIT PATCHES] V4L/DVB updates
@ 2007-12-24 12:37 Mauro Carvalho Chehab
  0 siblings, 0 replies; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-12-24 12:37 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, linux-dvb-maintainer, video4linux-list, linux-kernel

Linus,

Please pull from:
        ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
master

For two trivial driver fixes:
   - A fix at Kconfig to DVB_LGDT330X be selected on cx23885;
   - Some ivtv boards requres a longer i2c udelay for they to work.

Cheers,
Mauro.

---

 drivers/media/video/cx23885/Kconfig |    1 +
 drivers/media/video/ivtv/ivtv-i2c.c |    3 +++
 2 files changed, 4 insertions(+), 0 deletions(-)

Hans Verkuil (1):
      V4L/DVB (6876): ivtv: mspx4xx needs a longer i2c udelay

Michael Krufky (1):
      V4L/DVB (6871): Kconfig: VIDEO_CX23885 must select DVB_LGDT330X

---------------------------------------------------
V4L/DVB development is hosted at http://linuxtv.org


^ permalink raw reply	[flat|nested] 31+ messages in thread

* [GIT PATCHES] V4L/DVB updates
@ 2007-07-20 19:29 Mauro Carvalho Chehab
  0 siblings, 0 replies; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-07-20 19:29 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, linux-dvb-maintainer, video4linux-list, linux-kernel

Linus,

Please pull from:
        ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master

For the following:
   - Some cleanups on several drivers;
   - Some fixes on ivtv driver;
   - Remove some memory leaks on wm8775 and wm8739;
   - Add missing <sys/time.h> for userspace V4L2 API;
   - Add check for valid control ID to v4l2_ctrl_next.

Cheers,
Mauro.

---

 drivers/media/common/ir-functions.c      |    4 +-
 drivers/media/dvb/ttpci/av7110.c         |    2 +-
 drivers/media/radio/radio-aimslab.c      |    2 +-
 drivers/media/radio/radio-cadet.c        |    4 +-
 drivers/media/radio/radio-gemtek-pci.c   |    3 --
 drivers/media/video/bt866.c              |    2 +-
 drivers/media/video/bt8xx/bttv-cards.c   |    2 +-
 drivers/media/video/bt8xx/bttv-input.c   |    2 +-
 drivers/media/video/bt8xx/bttvp.h        |    4 +-
 drivers/media/video/c-qcam.c             |    4 +-
 drivers/media/video/cx88/cx88-video.c    |    8 +++++-
 drivers/media/video/cx88/cx88.h          |    2 +-
 drivers/media/video/ivtv/Kconfig         |    5 ++-
 drivers/media/video/ivtv/ivtv-driver.c   |   43 ++++++++++++++----------------
 drivers/media/video/ivtv/ivtv-driver.h   |    2 +-
 drivers/media/video/ivtv/ivtv-fileops.c  |    6 ++--
 drivers/media/video/ivtv/ivtv-firmware.c |   25 ++++++++---------
 drivers/media/video/ivtv/ivtv-gpio.c     |    2 +-
 drivers/media/video/ivtv/ivtv-i2c.c      |   20 +++++++-------
 drivers/media/video/ivtv/ivtv-irq.c      |   11 +++++---
 drivers/media/video/ivtv/ivtv-mailbox.c  |   33 ++++++++++++++---------
 drivers/media/video/ivtv/ivtv-streams.c  |   12 +++++---
 drivers/media/video/saa5249.c            |    8 +++---
 drivers/media/video/saa7110.c            |    4 +-
 drivers/media/video/saa7134/saa7134.h    |    2 +-
 drivers/media/video/tvaudio.c            |    4 +-
 drivers/media/video/v4l2-common.c        |   19 +++++++++---
 drivers/media/video/vino.c               |    2 +-
 drivers/media/video/wm8739.c             |    2 +
 drivers/media/video/wm8775.c             |    2 +
 include/linux/videodev2.h                |    1 +
 31 files changed, 134 insertions(+), 108 deletions(-)

Alexey Dobriyan (1):
      V4L/DVB (5852): ivtv: don't recompile needlessly

Cyrill Gorcunov (1):
      V4L/DVB (5871): Conexant 2388x: check for kthread_run

Hans Verkuil (9):
      V4L/DVB (5850): ivtv: improve API command debugging
      V4L/DVB (5851): ivtv: fix missing I2C_ALGOBIT config option
      V4L/DVB (5853): ivtv: add support to suppress high volume i2c debug messages.
      V4L/DVB (5854): ivtv: cleanup of driver messages
      V4L/DVB (5855): ivtv: fix Kconfig typo and refer to the driver homepage.
      V4L/DVB (5866): ivtv: fix DMA timeout when capturing VBI + another stream
      V4L/DVB (5867): videodev2.h: add missing <sys/time.h> for userspace
      V4L/DVB (5869): Add check for valid control ID to v4l2_ctrl_next.
      V4L/DVB (5880): wm8775/wm8739: Fix memory leak when unloading module

Mauro Carvalho Chehab (6):
      V4L/DVB (5857): Use msecs_to_jiffies instead of HZ on radio drivers
      V4L/DVB (5858): Use msecs_to_jiffies instead of HZ on media/video I2C drivers
      V4L/DVB (5859): use msecs_to_jiffies on InfraRed RC5 timeout
      V4L/DVB (5860): Use msecs_to_jiffies instead of HZ on some webcam drivers
      V4L/DVB (5861): Use msecs_to_jiffies instead of HZ on bttv, cx88 and saa7134
      V4L/DVB (5865): Remove usage of HZ on ivtv driver, replacing by msecs_to_jiffies

Trent Piepho (1):
      V4L/DVB (5877): radio-gemtek-pci: remove unused structure member

Yoann Padioleau (1):
      V4L/DVB (5848): Av7110: fix typo

---------------------------------------------------
V4L/DVB development is hosted at http://linuxtv.org


^ permalink raw reply	[flat|nested] 31+ messages in thread

* [GIT PATCHES] V4L/DVB updates
@ 2007-07-16 21:34 Mauro Carvalho Chehab
  0 siblings, 0 replies; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-07-16 21:34 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, linux-dvb-maintainer, video4linux-list, linux-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 21528 bytes --]

Linus,

Please pull from:
        ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master

For the following:

   - Add experimental support for tea5761 tuner and AF9005 demodulator
   - Add instructions to retrieve opera firmware
   - Some improvements at dvb-pll and at tuner core
   - Usbvision conversion to use video_ioctl2
   - new board additions on existing drivers
   - Several cleanups, updates and fixes on existing drivers

Cheers,
Mauro.

---

 Documentation/dvb/bt8xx.txt                        |   32 +-
 Documentation/dvb/get_dvb_firmware                 |   63 +-
 Documentation/dvb/opera-firmware.txt               |   27 +
 Documentation/video4linux/CARDLIST.bttv            |    4 +-
 Documentation/video4linux/CARDLIST.cx88            |    1 +
 Documentation/video4linux/CARDLIST.saa7134         |    1 +
 Documentation/video4linux/CARDLIST.tuner           |    3 +-
 Documentation/video4linux/sn9c102.txt              |    3 +-
 Documentation/video4linux/zr364xx.txt              |    2 +-
 drivers/media/Kconfig                              |    4 +
 drivers/media/common/ir-functions.c                |   23 +-
 drivers/media/common/saa7146_core.c                |    8 +-
 drivers/media/common/saa7146_video.c               |    8 +-
 drivers/media/dvb/b2c2/Kconfig                     |    2 +-
 drivers/media/dvb/b2c2/Makefile                    |    2 +-
 drivers/media/dvb/b2c2/flexcop-fe-tuner.c          |    4 +-
 drivers/media/dvb/bt8xx/Kconfig                    |    2 +-
 drivers/media/dvb/bt8xx/Makefile                   |    2 +-
 drivers/media/dvb/bt8xx/dst.c                      |    2 +-
 drivers/media/dvb/bt8xx/dvb-bt8xx.c                |    5 +-
 drivers/media/dvb/cinergyT2/Makefile               |    2 +-
 drivers/media/dvb/cinergyT2/cinergyT2.c            |   19 +-
 drivers/media/dvb/dvb-core/dmxdev.c                |    2 +-
 drivers/media/dvb/dvb-core/dvb_ca_en50221.c        |   12 +-
 drivers/media/dvb/dvb-core/dvb_demux.c             |    2 +-
 drivers/media/dvb/dvb-core/dvb_frontend.h          |    2 +-
 drivers/media/dvb/dvb-core/dvb_net.c               |    5 +-
 drivers/media/dvb/dvb-core/dvbdev.c                |   10 +-
 drivers/media/dvb/dvb-usb/Kconfig                  |   29 +-
 drivers/media/dvb/dvb-usb/Makefile                 |    8 +-
 drivers/media/dvb/dvb-usb/af9005-fe.c              | 1503 +++++++++
 drivers/media/dvb/dvb-usb/af9005-remote.c          |  157 +
 drivers/media/dvb/dvb-usb/af9005-script.h          |  203 ++
 drivers/media/dvb/dvb-usb/af9005.c                 | 1141 +++++++
 drivers/media/dvb/dvb-usb/af9005.h                 | 3496 ++++++++++++++++++++
 drivers/media/dvb/dvb-usb/cxusb.c                  |   18 +-
 drivers/media/dvb/dvb-usb/dibusb-common.c          |    2 +-
 drivers/media/dvb/dvb-usb/dibusb-mb.c              |   53 +-
 drivers/media/dvb/dvb-usb/dibusb.h                 |    1 +
 drivers/media/dvb/dvb-usb/digitv.c                 |   21 +-
 drivers/media/dvb/dvb-usb/digitv.h                 |    4 +
 drivers/media/dvb/dvb-usb/dvb-usb-i2c.c            |   79 -
 drivers/media/dvb/dvb-usb/dvb-usb-ids.h            |    6 +
 drivers/media/dvb/dvb-usb/dvb-usb-remote.c         |    2 +-
 drivers/media/dvb/dvb-usb/dvb-usb.h                |   11 -
 drivers/media/dvb/dvb-usb/gl861.c                  |    7 +-
 drivers/media/dvb/dvb-usb/m920x.c                  |  127 +-
 drivers/media/dvb/dvb-usb/m920x.h                  |    5 +-
 drivers/media/dvb/dvb-usb/opera1.c                 |   25 +-
 drivers/media/dvb/dvb-usb/umt-010.c                |    8 +-
 drivers/media/dvb/frontends/Makefile               |    2 +-
 drivers/media/dvb/frontends/cx22702.c              |    1 -
 drivers/media/dvb/frontends/cx24123.c              |    2 +-
 drivers/media/dvb/frontends/dvb-pll.c              |  256 +-
 drivers/media/dvb/frontends/dvb-pll.h              |   73 +-
 drivers/media/dvb/frontends/nxt200x.c              |   23 +-
 drivers/media/dvb/frontends/nxt200x.h              |    3 -
 drivers/media/dvb/frontends/or51132.c              |    1 -
 drivers/media/dvb/frontends/or51211.c              |   31 +-
 drivers/media/dvb/frontends/stv0299.c              |    2 +-
 drivers/media/dvb/frontends/tda10023.c             |    2 +-
 drivers/media/dvb/pluto2/Makefile                  |    2 +-
 drivers/media/dvb/ttpci/Kconfig                    |    2 +-
 drivers/media/dvb/ttpci/Makefile                   |    2 +-
 drivers/media/dvb/ttpci/av7110.c                   |   13 +-
 drivers/media/dvb/ttpci/av7110.h                   |    1 +
 drivers/media/dvb/ttpci/av7110_av.c                |   20 +-
 drivers/media/dvb/ttpci/av7110_ca.c                |    4 +-
 drivers/media/dvb/ttpci/av7110_hw.c                |    8 +-
 drivers/media/dvb/ttpci/av7110_hw.h                |    2 +-
 drivers/media/dvb/ttpci/av7110_ir.c                |    2 +-
 drivers/media/dvb/ttpci/av7110_v4l.c               |    2 +-
 drivers/media/dvb/ttpci/budget-av.c                |   31 +-
 drivers/media/dvb/ttpci/budget-ci.c                |    2 +-
 drivers/media/dvb/ttusb-budget/Makefile            |    2 +-
 drivers/media/dvb/ttusb-dec/Makefile               |    2 +-
 drivers/media/radio/Kconfig                        |    4 +-
 drivers/media/radio/radio-aimslab.c                |    1 -
 drivers/media/radio/radio-aztech.c                 |    1 -
 drivers/media/radio/radio-gemtek-pci.c             |    1 -
 drivers/media/radio/radio-gemtek.c                 |    1 -
 drivers/media/radio/radio-rtrack2.c                |    1 -
 drivers/media/radio/radio-sf16fmi.c                |    1 -
 drivers/media/radio/radio-sf16fmr2.c               |    1 -
 drivers/media/radio/radio-terratec.c               |    1 -
 drivers/media/radio/radio-trust.c                  |    1 -
 drivers/media/radio/radio-typhoon.c                |    1 -
 drivers/media/video/Kconfig                        |    9 +
 drivers/media/video/Makefile                       |    6 +-
 drivers/media/video/adv7170.c                      |    8 +-
 drivers/media/video/adv7175.c                      |    8 +-
 drivers/media/video/bt819.c                        |    9 +-
 drivers/media/video/bt856.c                        |    8 +-
 drivers/media/video/bt8xx/bttv-cards.c             |  442 ++--
 drivers/media/video/bt8xx/bttv-driver.c            |   34 +-
 drivers/media/video/bt8xx/bttv-input.c             |    2 +-
 drivers/media/video/bt8xx/bttv.h                   |    2 +
 drivers/media/video/bt8xx/bttvp.h                  |    2 +-
 drivers/media/video/cpia2/cpia2_core.c             |    9 +-
 drivers/media/video/cpia2/cpia2_v4l.c              |    8 +-
 drivers/media/video/cx88/Kconfig                   |    2 +-
 drivers/media/video/cx88/cx88-blackbird.c          |   14 +-
 drivers/media/video/cx88/cx88-cards.c              |   24 +
 drivers/media/video/cx88/cx88-dvb.c                |  122 +-
 drivers/media/video/cx88/cx88-i2c.c                |   25 +-
 drivers/media/video/cx88/cx88-input.c              |   25 +-
 drivers/media/video/cx88/cx88-mpeg.c               |    2 +-
 drivers/media/video/cx88/cx88-vp3054-i2c.c         |   12 +-
 drivers/media/video/cx88/cx88-vp3054-i2c.h         |    7 +
 drivers/media/video/cx88/cx88.h                    |    6 +-
 drivers/media/video/et61x251/Kconfig               |    2 +-
 drivers/media/video/et61x251/et61x251.h            |   23 +-
 drivers/media/video/et61x251/et61x251_core.c       |  189 +-
 drivers/media/video/et61x251/et61x251_sensor.h     |    8 +-
 drivers/media/video/et61x251/et61x251_tas5130d1b.c |    2 +-
 drivers/media/video/ir-kbd-i2c.c                   |   53 +-
 drivers/media/video/ivtv/ivtv-driver.c             |   13 +-
 drivers/media/video/ivtv/ivtv-driver.h             |   19 +-
 drivers/media/video/ivtv/ivtv-fileops.c            |    8 +-
 drivers/media/video/ivtv/ivtv-firmware.c           |    4 +-
 drivers/media/video/ivtv/ivtv-gpio.c               |    9 +-
 drivers/media/video/ivtv/ivtv-ioctl.c              |    4 +-
 drivers/media/video/ivtv/ivtv-irq.c                |   36 +-
 drivers/media/video/ivtv/ivtv-streams.c            |   35 +-
 drivers/media/video/ivtv/ivtv-vbi.c                |   31 +-
 drivers/media/video/msp3400-driver.c               |    6 +-
 drivers/media/video/mt20xx.c                       |   80 +-
 drivers/media/video/ov7670.c                       |    4 +-
 drivers/media/video/pwc/pwc-if.c                   |   12 +-
 drivers/media/video/pwc/pwc.h                      |    4 +-
 drivers/media/video/saa7111.c                      |    8 +-
 drivers/media/video/saa7114.c                      |   10 +-
 drivers/media/video/saa7134/Kconfig                |    2 +-
 drivers/media/video/saa7134/saa7134-alsa.c         |   16 +-
 drivers/media/video/saa7134/saa7134-cards.c        |   41 +-
 drivers/media/video/saa7134/saa7134-dvb.c          |  169 +-
 drivers/media/video/saa7134/saa7134-empress.c      |    8 +
 drivers/media/video/saa7134/saa7134-input.c        |   20 +-
 drivers/media/video/saa7134/saa7134-tvaudio.c      |   42 +-
 drivers/media/video/saa7134/saa7134.h              |    6 +-
 drivers/media/video/saa7185.c                      |    8 +-
 drivers/media/video/sn9c102/sn9c102.h              |    9 +-
 drivers/media/video/sn9c102/sn9c102_core.c         |  173 +-
 drivers/media/video/sn9c102/sn9c102_ov7630.c       |  214 ++-
 drivers/media/video/sn9c102/sn9c102_ov7660.c       |   88 +-
 drivers/media/video/stradis.c                      |    2 +-
 drivers/media/video/stv680.c                       |    7 +-
 drivers/media/video/tda8290.c                      |  129 +-
 drivers/media/video/tda9887.c                      |   57 +-
 drivers/media/video/tea5761.c                      |  243 ++
 drivers/media/video/tea5767.c                      |   16 +-
 drivers/media/video/tuner-core.c                   |   95 +-
 drivers/media/video/tuner-driver.h                 |  107 +
 drivers/media/video/tuner-simple.c                 |   27 +-
 drivers/media/video/tuner-types.c                  |   22 +-
 drivers/media/video/tveeprom.c                     |    8 +-
 drivers/media/video/tvp5150.c                      |    2 +-
 drivers/media/video/usbvideo/konicawc.c            |    2 +-
 drivers/media/video/usbvideo/quickcam_messenger.c  |    4 +-
 drivers/media/video/usbvideo/vicam.c               |  181 -
 drivers/media/video/usbvision/usbvision-cards.c    |    8 +-
 drivers/media/video/usbvision/usbvision-core.c     |   43 +-
 drivers/media/video/usbvision/usbvision-video.c    | 1561 +++++-----
 drivers/media/video/usbvision/usbvision.h          |   13 +-
 drivers/media/video/vino.c                         |    6 +-
 drivers/media/video/vivi.c                         |  178 +-
 drivers/media/video/zc0301/Kconfig                 |    2 +-
 drivers/media/video/zc0301/zc0301.h                |   21 +-
 drivers/media/video/zc0301/zc0301_core.c           |  147 +-
 drivers/media/video/zc0301/zc0301_pas202bcb.c      |    1 +
 drivers/media/video/zc0301/zc0301_pb0330.c         |    1 +
 drivers/media/video/zc0301/zc0301_sensor.h         |    2 +-
 drivers/media/video/zoran_driver.c                 |   63 -
 drivers/media/video/zr364xx.c                      |   18 +-
 include/media/saa7146.h                            |    6 +-
 include/media/tuner.h                              |   71 +-
 176 files changed, 9814 insertions(+), 3034 deletions(-)
 create mode 100644 Documentation/dvb/opera-firmware.txt
 create mode 100644 drivers/media/dvb/dvb-usb/af9005-fe.c
 create mode 100644 drivers/media/dvb/dvb-usb/af9005-remote.c
 create mode 100644 drivers/media/dvb/dvb-usb/af9005-script.h
 create mode 100644 drivers/media/dvb/dvb-usb/af9005.c
 create mode 100644 drivers/media/dvb/dvb-usb/af9005.h
 create mode 100644 drivers/media/video/tea5761.c
 create mode 100644 drivers/media/video/tuner-driver.h

Aapo Tahkola (6):
      V4L/DVB (5628): Add support for A-LINK DTU dvb-t adapter
      V4L/DVB (5692): M920x: attempt to fix hw pid filters on second endpoint
      V4L/DVB (5693): M920x: second endpoint also needs to be changed to alt setting
      V4L/DVB (5694): M920x: fix for Dposh devices
      V4L/DVB (5695): M920x: enable second adapter on LifeView TV Walker Twin
      V4L/DVB (5696): M920x: add missing error handling to prevent syslog spamming

Adrian Bunk (3):
      V4L/DVB (5740): Git-dvb: fix the tea5761 tuner support
      V4L/DVB (5813): TUNER_TEA5761 kconfig fixes
      V4L/DVB (5814): Unexport dvb_pll_configure

Akinobu Mita (1):
      V4L/DVB (5678): Zr364xx: fix return values

Antoine Jacquet (1):
      V4L/DVB (5792): Zr364xx: add support for Trust Powerc@m 970Z

Christoph Hellwig (1):
      V4L/DVB (5724): Saa7134-tvaudio: kthread conversion

Daniel Gimpelevich (1):
      V4L/DVB (5685): Cx88: add support for ADS Tech Instant Video PCI

David Warman (2):
      V4L/DVB (5641): change VideoNorm to NTSC for Belkin USB Videobus II
      V4L/DVB (5642): add comment that VO_MODE is also being set.

Dmitry Torokhov (4):
      V4L/DVB (5682): SAA7134 - switch to use msecs_to_jiffies()
      V4L/DVB (5683): V4L: cx88 - switch to using msecs_to_jiffies()
      V4L/DVB (5684): V4L: ir-kbd-i2c - switch to using msecs_to_jiffies()
      V4L/DVB (5698): Input: drivers/media - switch to using input_dev->dev.parent

Douglas Schilling Landgraf (2):
      V4L/DVB (5705): Removed unnecessary .hardware from video_device struct.
      V4L/DVB (5828): Kconfig: Added GemTek USB radio and removed experimental dependency.

Edgar Pisani (1):
      V4L/DVB (5787): Cx88: add remote control support for Leadtek Winfast DTV1000

Hans Verkuil (11):
      V4L/DVB (5671): Autodetect new PVR150 low profile cards.
      V4L/DVB (5674): Models 30012-30039 are for a low profile PVR250, not PVR150.
      V4L/DVB (5729): Remove support for 256 Kb firmware files.
      V4L/DVB (5733): Blackbird should accept only new cx2341x encoding firmwares
      V4L/DVB (5768): Ivtv: fix converity warning
      V4L/DVB (5769): Ivtv: fix broken VBI output support
      V4L/DVB (5770): Ivtv: fix return code of VIDIOC_G/S_FBUF when no FB is present
      V4L/DVB (5841): tveeprom: add support for Philips FQ1216LME MK3 tuner.
      V4L/DVB (5842): ivtv: Add locking to ensure stream setup is atomic.
      V4L/DVB (5843): ivtv: fix missing signal_pending check.
      V4L/DVB (5844): ivtv: add high volume debugging flag

James Le Cuirot (1):
      V4L/DVB (5821): Saa7134: add remote control support for LifeView FlyDVB-S LR300

Jan Frey (1):
      V4L/DVB (5786): Ir-kbd-i2c: add support for Hauppauge HVR1300 remote

Jean Delvare (1):
      V4L/DVB (5815): Cx88: i2c structure templates clean-up

Luca Olivetti (2):
      V4L/DVB (5625): Add support for the AF9005 demodulator from Afatech
      V4L/DVB (5626): Marked af9005 driver as experimental and fix dependencies

Luca Risolia (3):
      V4L/DVB (5765): SN9C1xx driver updates
      V4L/DVB (5766): ET61x251 driver updates
      V4L/DVB (5767): ZC0301 driver updates

Marco Gittler (2):
      V4L/DVB (5795): Fix: remove unused struct that could avoiding load the firmware
      V4L/DVB (5829): Firmware extract and loading for opera dvb-usb update

Matthew Garrett (1):
      V4L/DVB (5825): Alter the tuner type for the WinTV USB UK PAL model.

Matthias Kaehlcke (2):
      V4L/DVB (5809): Use mutex instead of semaphore in Philips webcam driver
      V4L/DVB (5811): Use mutex instead of semaphore in Virtual Video driver

Mauro Carvalho Chehab (13):
      V4L/DVB (5563a): Add experimental support for tea5761 tuner
      V4L/DVB (5681): Correct aliases for STD/L and STD/Lc
      V4L/DVB (5727): Remove VIVI_SCATTER
      V4L/DVB (5774a): Remove CONFIG_BIGPHYS_AREA from zoran_driver
      V4L/DVB (5750): Remove obsoleted support for PROC_FS on vicam.c
      V4L/DVB (5763): Fix tea5761 unselection
      V4L/DVB (5783): Fix excess of debug messages on cx88-mpeg
      V4L/DVB (5789): Fix 3dfx Voodoo entries on Cardlist
      V4L/DVB (5790): Fix error handling for stv680
      V4L/DVB (5791): Fix Kbuild for kbd-ir-i2c
      V4L/DVB (5819): Cleanup: reorder some includes
      V4L/DVB (5820): Cleanup on cinergyT2: Remove unneeded if(1)
      V4L/DVB (5840): fix dst and cx24123: tune() callback changed signess for delay

Michael Krufky (37):
      V4L/DVB (5632): Dvb-pll: pass dvb_frontend_parameters to generic set() function
      V4L/DVB (5633): Tuv1236d: move rf input switching code into dvb-pll
      V4L/DVB (5634): Saa7134-dvb: convert philips td1316 handling to use dvb-pll
      V4L/DVB (5635): Budget-av: convert philips sd1878 / tda8261 to use dvb-pll
      V4L/DVB (5648): Dvb/frontends: remove unnecessary #include's of "dvb-pll.h"
      V4L/DVB (5649): Umt-010: convert tua6034 handling to properly use dvb-pll
      V4L/DVB (5650): Umt-010: trivial whitespace cleanup
      V4L/DVB (5651): Dibusb-mb: convert pll handling to properly use dvb-pll
      V4L/DVB (5652): Dibusb-mb: use dvb_attach for dib3000mb_attach
      V4L/DVB (5637): Cx88: kill core->pll_desc and core->pll_addr
      V4L/DVB (5718): Mt20xx: whitespace cleanup
      V4L/DVB (5719): Tuner: Move device-specific private data out of tuner struct
      V4L/DVB (5734): Cx88: kill dev->fw_size
      V4L/DVB (5741): Tuner: add release callback
      V4L/DVB (5742): Tuner: define release callback for mt20xx, tda9887 and tda8290
      V4L/DVB (5743): Tuner: clean up kfree() after release
      V4L/DVB (5747): Tea5761: remove duplicated "#include <media/tuner.h>"
      V4L/DVB (5753): Tuner: create struct tuner_operations
      V4L/DVB (5754): Mt20xx: store tuning operations in tuner_operations structure
      V4L/DVB (5755): Tda8290: store tuning operations in tuner_operations structure
      V4L/DVB (5756): Tda9887: store tuning operations in tuner_operations structure
      V4L/DVB (5757): Tea5761: store tuning operations in tuner_operations structure
      V4L/DVB (5758): Tea5767: store tuning operations in tuner_operations structure
      V4L/DVB (5759): Tuner-simple: store tuning operations in tuner_operations struct
      V4L/DVB (5771): Get_dvb_firmware: update script for new location
      V4L/DVB (5772): Cx88: remove two unused pointers from struct cx8802_dev
      V4L/DVB (5778): Dvb-usb: kill unused tuner/i2c functions
      V4L/DVB (5779): Dibusb-mb: fix broken 'tuner_pass_ctrl' functionality
      V4L/DVB (5780): Dvb: Remove static dependencies on dvb-pll
      V4L/DVB (5784): Dibusb-mb: fix tuner autodetection regression
      V4L/DVB (5788): Cx88-input: convert nested if's to switch..case
      V4L/DVB (5793): Tuner: remove hardware-specific info from public header
      V4L/DVB (5798): Dvb-pll: add support for Philips fcv1236d
      V4L/DVB (5799): Or51211: remove hardcoded fcv1236d tuner programming
      V4L/DVB (5800): Tuner: correct description of Philips FCV1236D tuner
      V4L/DVB (5801): Tuner: update FCV1236D ranges to match the datasheet
      V4L/DVB (5803): Bttv: add support for DViCO FusionHDTV 2

Oliver Endriss (5):
      V4L/DVB (5669): Budget-av: Add support for EasyWatch DVB-S (0x1894:0x001b)
      V4L/DVB (5835): saa7146/dvb-ttpci: Fix signedness warnings (gcc 4.1.1, kernel 2.6.22)
      V4L/DVB (5836): dvb-ttpci: re-initialize aspect ratio and pan scan after arm crash
      V4L/DVB (5837): stv0299: Fix signedness warning (gcc 4.1.1, kernel 2.6.22)
      V4L/DVB (5838): dvb-core: Fix signedness warnings (gcc 4.1.1, kernel 2.6.22)

Rafael Bilski (1):
      V4L/DVB (5776): Hardware MPEG audio fix for SAA7134 based "KNC One TV-Station DVR" card

Rafał Bilski (1):
      V4L/DVB (5775): Alsa fix for SAA7134 based "KNC One TV-Station DVR" card

Robert P. J. Day (4):
      V4L/DVB (5704): Remove worthless references to obsolete MODULE_PARM macro.
      V4L/DVB (5739): Replace C code with calls to ARRAY_SIZE macro.
      V4L/DVB (5846): Clean up setting state and scheduling timeouts
      V4L/DVB (5847): Clean up schedule_timeout calls in cpia2 and ivtv code

Simon Arlott (1):
      V4L/DVB (5631): Dvb-core: Add level fixes to printk()s, plus spelling/grammer

Thierry MERLE (4):
      V4L/DVB (5643): Usbvision: make common video and radio ioctls
      V4L/DVB (5644): Usbvision: video_ioctl2 conversion
      V4L/DVB (5824): Usbvision: Hauppauge WinTV USB SECAM_L fix
      V4L/DVB (5826): Usbvision: video mux cleanup

Tony Wan (2):
      V4L/DVB (5646): V4l: saa7134: add support for 10moons TM300 card
      V4L/DVB (5647): Saa7134: enable ir-remote for 10moons TM300

Trent Piepho (10):
      V4L/DVB (5629): Cx88: VP3054 support can't be a module when cx88 is compiled in
      V4L/DVB (5636): Integrate all users of the fmd1216 tuner with dvb-pll
      V4L/DVB (5745): Dvb: use '+=' instead of '=' for EXTRA_CFLAGS
      V4L/DVB (5777): Dvb-pll digitv dvb-usb: Eliminate last user of dvb_pll_configure
      V4L/DVB (5805): Bttv: Fix problems with probing for non-existent tuners
      V4L/DVB (5806): Bttv: Be consistent in using symbolic names instead of constants
      V4L/DVB (5807): Bttv: Add support for DBG_[SG]_REGISTER ioctls
      V4L/DVB (5831): stradis: use ARRAY_SIZE
      V4L/DVB (5832): ir-common: optimize bit extract function
      V4L/DVB (5834): dvb-core: fix signedness warnings and const stripping

Uwe Bugla (1):
      V4L/DVB (5701): Documentation/dvb/bt8xx.txt update

Wade Berrier (1):
      V4L/DVB (5785): Revisited: 3dfx Voodoo TV 200 (US)

---------------------------------------------------
V4L/DVB development is hosted at http://linuxtv.org


^ permalink raw reply	[flat|nested] 31+ messages in thread

* [GIT PATCHES] V4L/DVB updates
@ 2007-05-22 20:52 Mauro Carvalho Chehab
  0 siblings, 0 replies; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-05-22 20:52 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, linux-dvb-maintainer, video4linux-list, linux-kernel

Linus,

Please pull from:
        ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master

For the following:

   - Two fixes on Kconfig dependencies (ivtv and em28xx)
   - Adding new fields to v4l2_pix_format broke the ABI, reverted that change
   - Dvb-core: Handle failures to create devices
   - Fix dst usage count
   - Fix suport for SECAM with FI1216MF
   - OLPC: Cafe_ccic and ov7670 fixes

Cheers,
Mauro.

---

 drivers/media/dvb/bt8xx/dst.c          |    3 ---
 drivers/media/dvb/dvb-core/dvbdev.c    |   15 +++++++++++----
 drivers/media/video/cafe_ccic-regs.h   |    6 ++++++
 drivers/media/video/cafe_ccic.c        |   18 +++++++++++++++++-
 drivers/media/video/em28xx/Kconfig     |    3 +--
 drivers/media/video/ivtv/Kconfig       |    2 +-
 drivers/media/video/ivtv/ivtv-driver.h |    8 --------
 drivers/media/video/ivtv/ivtv-ioctl.c  |   12 ++----------
 drivers/media/video/ov7670.c           |   21 ++++++++++++++++++---
 drivers/media/video/tuner-simple.c     |   10 +++++++---
 include/linux/videodev2.h              |    2 --
 11 files changed, 63 insertions(+), 37 deletions(-)

Hans Verkuil (1):
      V4L/DVB (5670): Adding new fields to v4l2_pix_format broke the ABI, reverted that change

Jonathan Corbet (2):
      V4L/DVB (5690): Cafe_ccic: Properly power down the sensor
      V4L/DVB (5691): Ov7670: reset clkrc in rgb565 mode

Manu Abraham (1):
      V4L/DVB (5639a): Fix dst usage count

Matthieu CASTET (1):
      V4L/DVB (5680): Tuner-simple.c fix suport for SECAM with FI1216MF

Mauro Carvalho Chehab (2):
      V4L/DVB (5639): Fix Kconfig dependencies for ivtv
      V4L/DVB (5640): Fix: em28xx shouldn't be selecting VIDEO_BUF

Simon Arlott (1):
      V4L/DVB (5630): Dvb-core: Handle failures to create devices

---------------------------------------------------
V4L/DVB development is hosted at http://linuxtv.org


^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [GIT PATCHES] V4L/DVB updates
  2007-05-09 10:27   ` Mauro Carvalho Chehab
@ 2007-05-09 19:05     ` Geert Uytterhoeven
  0 siblings, 0 replies; 31+ messages in thread
From: Geert Uytterhoeven @ 2007-05-09 19:05 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Hans Verkuil, Linus Torvalds, Andrew Morton,
	linux-dvb-maintainer, video4linux-list, Linux Kernel Development,
	Rechberger Markus

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1735 bytes --]

On Wed, 9 May 2007, Mauro Carvalho Chehab wrote:
> Em Qua, 2007-05-09 às 08:30 +0200, Geert Uytterhoeven escreveu:
> > On Fri, 27 Apr 2007, Mauro Carvalho Chehab wrote:
> > > A short changelog:
> > > 
> > >    - New drivers:
> > >         ivtv driver for Hauppauge PVR series and similar boards;
> > 
> > Can we please have proper Kconfig dependencies instead of
> > 
> > | #ifdef CONFIG_LIRC_I2C
> > | #  error "This driver is not compatible with the LIRC I2C kernel configuration
> > | #endif /* CONFIG_LIRC_I2C */
> > | 
> > | #ifndef CONFIG_PCI
> > | #  error "This driver requires kernel PCI support."
> > | #endif /* CONFIG_PCI */
> > 
> > in drivers/media/video/ivtv/ivtv-driver.h? Especially a dependency on
> > CONFIG_PCI would be nice (CONFIG_LIRC_I2C doesn't exist in mainline?).
> > 
> > | drivers/media/video/video-buf.c: In function 'videobuf_queue_pci':
> > | drivers/media/video/video-buf.c:399: error: 'pci_map_sg' undeclared (first use in this function)
> > 
> > Probably some new driver does a select VIDEO_BUF, which overrides that
> > VIDEO_BUF depends on PCI?
> 
> Can you check if the following patch would fix it? VIDEO_BUF is selected
> by several PCI-dependent devices. The only non-PCI device wrongly
> selecting VIDEO_BUF seems to be em28xx.

Yes, it fixed the issues (after manual application of the last chunk,
which didn't apply cleanly). Thanks!

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [GIT PATCHES] V4L/DVB updates
  2007-05-09  6:30 ` Geert Uytterhoeven
@ 2007-05-09 10:27   ` Mauro Carvalho Chehab
  2007-05-09 19:05     ` Geert Uytterhoeven
  0 siblings, 1 reply; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-05-09 10:27 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Hans Verkuil, Linus Torvalds, Andrew Morton,
	linux-dvb-maintainer, video4linux-list, Linux Kernel Development,
	Rechberger Markus

Hi Geert,

Em Qua, 2007-05-09 às 08:30 +0200, Geert Uytterhoeven escreveu:
> On Fri, 27 Apr 2007, Mauro Carvalho Chehab wrote:
> > A short changelog:
> > 
> >    - New drivers:
> >         ivtv driver for Hauppauge PVR series and similar boards;
> 
> Can we please have proper Kconfig dependencies instead of
> 
> | #ifdef CONFIG_LIRC_I2C
> | #  error "This driver is not compatible with the LIRC I2C kernel configuration
> | #endif /* CONFIG_LIRC_I2C */
> | 
> | #ifndef CONFIG_PCI
> | #  error "This driver requires kernel PCI support."
> | #endif /* CONFIG_PCI */
> 
> in drivers/media/video/ivtv/ivtv-driver.h? Especially a dependency on
> CONFIG_PCI would be nice (CONFIG_LIRC_I2C doesn't exist in mainline?).
> 
> | drivers/media/video/video-buf.c: In function 'videobuf_queue_pci':
> | drivers/media/video/video-buf.c:399: error: 'pci_map_sg' undeclared (first use in this function)
> 
> Probably some new driver does a select VIDEO_BUF, which overrides that
> VIDEO_BUF depends on PCI?

Can you check if the following patch would fix it? VIDEO_BUF is selected
by several PCI-dependent devices. The only non-PCI device wrongly
selecting VIDEO_BUF seems to be em28xx.

If the fixes are ok, I'll later add on my -git tree and ask Linus to
pull.

Cheers,
Mauro

---

 linux/drivers/media/video/em28xx/Kconfig     |    1 -
 linux/drivers/media/video/ivtv/Kconfig       |    2 +-
 linux/drivers/media/video/ivtv/ivtv-driver.h |    8 --------
 3 files changed, 1 insertion(+), 10 deletions(-)

diff -r 8b431c3f669b -r ccd4eeca9037 linux/drivers/media/video/ivtv/Kconfig
--- a/linux/drivers/media/video/ivtv/Kconfig	Tue May 08 23:19:22 2007 -0300
+++ b/linux/drivers/media/video/ivtv/Kconfig	Wed May 09 07:00:00 2007 -0300
@@ -1,6 +1,6 @@ config VIDEO_IVTV
 config VIDEO_IVTV
 	tristate "Conexant cx23416/cx23415 MPEG encoder/decoder support"
-	depends on VIDEO_V4L1 && VIDEO_V4L2 && USB && I2C && EXPERIMENTAL
+	depends on VIDEO_V4L1 && VIDEO_V4L2 && PCI && I2C && EXPERIMENTAL
 	select FW_LOADER
 	select VIDEO_TUNER
 	select VIDEO_TVEEPROM
diff -r 8b431c3f669b -r ccd4eeca9037 linux/drivers/media/video/ivtv/ivtv-driver.h
--- a/linux/drivers/media/video/ivtv/ivtv-driver.h	Tue May 08 23:19:22 2007 -0300
+++ b/linux/drivers/media/video/ivtv/ivtv-driver.h	Wed May 09 07:00:00 2007 -0300
@@ -69,14 +69,6 @@
 /* #define HAVE_XC3028 1 */
 
 #include <media/ivtv.h>
-
-#ifdef CONFIG_LIRC_I2C
-#  error "This driver is not compatible with the LIRC I2C kernel configuration option."
-#endif /* CONFIG_LIRC_I2C */
-
-#ifndef CONFIG_PCI
-#  error "This driver requires kernel PCI support."
-#endif /* CONFIG_PCI */
 
 #define IVTV_ENCODER_OFFSET	0x00000000
 #define IVTV_ENCODER_SIZE	0x00800000	/* Last half isn't needed 0x01000000 */

diff -r ccd4eeca9037 -r 589fa7f7b695 linux/drivers/media/video/em28xx/Kconfig
--- a/linux/drivers/media/video/em28xx/Kconfig	Wed May 09 07:00:00 2007 -0300
+++ b/linux/drivers/media/video/em28xx/Kconfig	Wed May 09 07:06:23 2007 -0300
@@ -1,7 +1,6 @@ config VIDEO_EM28XX
 config VIDEO_EM28XX
 	tristate "Empia EM2800/2820/2840 USB video capture support"
 	depends on VIDEO_V4L1 && I2C
-	select VIDEO_BUF
 	select VIDEO_TUNER
 	select VIDEO_TVEEPROM
 	select VIDEO_IR

-- 
Cheers,
Mauro


^ permalink raw reply	[flat|nested] 31+ messages in thread

* Re: [GIT PATCHES] V4L/DVB updates
  2007-04-27 19:59 Mauro Carvalho Chehab
@ 2007-05-09  6:30 ` Geert Uytterhoeven
  2007-05-09 10:27   ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 31+ messages in thread
From: Geert Uytterhoeven @ 2007-05-09  6:30 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Hans Verkuil
  Cc: Linus Torvalds, Andrew Morton, linux-dvb-maintainer,
	video4linux-list, Linux Kernel Development

On Fri, 27 Apr 2007, Mauro Carvalho Chehab wrote:
> A short changelog:
> 
>    - New drivers:
>         ivtv driver for Hauppauge PVR series and similar boards;

Can we please have proper Kconfig dependencies instead of

| #ifdef CONFIG_LIRC_I2C
| #  error "This driver is not compatible with the LIRC I2C kernel configuration
| #endif /* CONFIG_LIRC_I2C */
| 
| #ifndef CONFIG_PCI
| #  error "This driver requires kernel PCI support."
| #endif /* CONFIG_PCI */

in drivers/media/video/ivtv/ivtv-driver.h? Especially a dependency on
CONFIG_PCI would be nice (CONFIG_LIRC_I2C doesn't exist in mainline?).

| drivers/media/video/video-buf.c: In function 'videobuf_queue_pci':
| drivers/media/video/video-buf.c:399: error: 'pci_map_sg' undeclared (first use in this function)

Probably some new driver does a select VIDEO_BUF, which overrides that
VIDEO_BUF depends on PCI?

Thanks!

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 31+ messages in thread

* [GIT PATCHES] V4L/DVB updates
@ 2007-05-08 18:05 Mauro Carvalho Chehab
  0 siblings, 0 replies; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-05-08 18:05 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, linux-dvb-maintainer, video4linux-list, linux-kernel

Linus,

Please pull from:
        ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master

There are several cleanups, driver updates and fixes on this series, including some
important fixes on handling V4L1 calls.

This series also adds support for a few newer saa7134 cards, some newer webcams based
on Sonix sn9c1xx chips, and support for a newer m920x board.

Cheers,
Mauro.

---

 Documentation/video4linux/CARDLIST.saa7134       |    5 +-
 Documentation/video4linux/sn9c102.txt            |   18 +-
 drivers/media/Kconfig                            |    9 +
 drivers/media/Makefile                           |    2 +-
 drivers/media/common/saa7146_core.c              |   54 ++-
 drivers/media/common/saa7146_fops.c              |    1 -
 drivers/media/dvb/Kconfig                        |   24 +-
 drivers/media/dvb/dvb-core/Kconfig               |   14 +-
 drivers/media/dvb/dvb-usb/dvb-usb-ids.h          |    5 +
 drivers/media/dvb/dvb-usb/dvb-usb.h              |    2 +-
 drivers/media/dvb/dvb-usb/m920x.c                |  565 ++++++++++++++++------
 drivers/media/dvb/dvb-usb/m920x.h                |   13 +-
 drivers/media/dvb/dvb-usb/vp702x-fe.c            |   14 +-
 drivers/media/dvb/pluto2/pluto2.c                |    8 +
 drivers/media/dvb/ttpci/av7110.c                 |    9 +-
 drivers/media/dvb/ttpci/budget-ci.c              |    2 +-
 drivers/media/dvb/ttpci/budget-core.c            |   37 +-
 drivers/media/radio/Kconfig                      |   11 +-
 drivers/media/radio/dsbr100.c                    |  345 +++++++------
 drivers/media/radio/radio-cadet.c                |  297 +++++++-----
 drivers/media/radio/radio-maestro.c              |    3 -
 drivers/media/radio/radio-zoltrix.c              |    1 -
 drivers/media/video/Kconfig                      |   45 +-
 drivers/media/video/cx25840/cx25840-core.c       |    4 +-
 drivers/media/video/cx88/cx88-mpeg.c             |    5 +-
 drivers/media/video/cx88/cx88-video.c            |    1 +
 drivers/media/video/cx88/cx88-vp3054-i2c.c       |    7 -
 drivers/media/video/cx88/cx88-vp3054-i2c.h       |    1 -
 drivers/media/video/em28xx/Kconfig               |    2 +-
 drivers/media/video/et61x251/Kconfig             |    2 +-
 drivers/media/video/ivtv/ivtv-driver.c           |    2 +-
 drivers/media/video/ivtv/ivtv-fileops.c          |    2 +-
 drivers/media/video/pvrusb2/Kconfig              |    2 +-
 drivers/media/video/pvrusb2/pvrusb2-encoder.c    |   13 +-
 drivers/media/video/pvrusb2/pvrusb2-hdw.c        |   10 +-
 drivers/media/video/pvrusb2/pvrusb2-i2c-core.c   |   23 +-
 drivers/media/video/pvrusb2/pvrusb2-sysfs.c      |   14 -
 drivers/media/video/pwc/Kconfig                  |    2 +-
 drivers/media/video/saa7134/saa7134-cards.c      |  123 +++++-
 drivers/media/video/saa7134/saa7134-dvb.c        |   17 +
 drivers/media/video/saa7134/saa7134.h            |    3 +
 drivers/media/video/sn9c102/Kconfig              |    2 +-
 drivers/media/video/sn9c102/sn9c102.h            |    2 +-
 drivers/media/video/sn9c102/sn9c102_core.c       |   91 ++--
 drivers/media/video/sn9c102/sn9c102_devtable.h   |    4 +-
 drivers/media/video/sn9c102/sn9c102_hv7131d.c    |    6 +-
 drivers/media/video/sn9c102/sn9c102_hv7131r.c    |    8 +-
 drivers/media/video/sn9c102/sn9c102_mi0343.c     |   51 +-
 drivers/media/video/sn9c102/sn9c102_mi0360.c     |  220 +++++++--
 drivers/media/video/sn9c102/sn9c102_ov7630.c     |   25 +-
 drivers/media/video/sn9c102/sn9c102_ov7660.c     |   63 ++-
 drivers/media/video/sn9c102/sn9c102_pas106b.c    |   14 +-
 drivers/media/video/sn9c102/sn9c102_pas202bcb.c  |   48 +-
 drivers/media/video/sn9c102/sn9c102_sensor.h     |   33 +-
 drivers/media/video/sn9c102/sn9c102_tas5110c1b.c |    2 +-
 drivers/media/video/sn9c102/sn9c102_tas5110d.c   |    2 +-
 drivers/media/video/sn9c102/sn9c102_tas5130d1b.c |    2 +-
 drivers/media/video/usbvideo/Kconfig             |    8 +-
 drivers/media/video/usbvision/Kconfig            |    2 +-
 drivers/media/video/v4l1-compat.c                |   62 ++-
 drivers/media/video/video-buf.c                  |    4 +-
 drivers/media/video/videodev.c                   |   50 ++-
 drivers/media/video/zc0301/Kconfig               |    2 +-
 include/media/saa7146.h                          |    2 +
 include/media/saa7146_vv.h                       |    2 +
 65 files changed, 1580 insertions(+), 842 deletions(-)

Aapo Tahkola (4):
      V4L/DVB (5607): M920x: Initial support for devices likely manufactured by Dposh
      V4L/DVB (5611): M920x: replace deb_rc with deb
      V4L/DVB (5612): M920x: rename function prefixes from m9206_foo to m920x_foo
      V4L/DVB (5613): M920x: loosen up 80-col limit

Adrian Bunk (2):
      V4L/DVB (5567): Cx88-mpeg.c: make 2 functions static
      V4L/DVB (5591): Saa7146: proper prototype for saa7146_video_do_ioctl()

Alexey Dobriyan (1):
      V4L/DVB (5565): Cx88: fix compilation on alpha

Douglas Landgraf (4):
      V4L/DVB (5621): Radio-cadet.c Replace cadet_do_ioctl to use video_ioctl2
      V4L/DVB (5622): Radio-zoltrix.c cleanup
      V4L/DVB (5623): Dsbr100.c Replace usb_dsbr100_do_ioctl to use video_ioctl2
      V4L/DVB (5624): Radio-maestro.c cleanup

James T Klaas (1):
      V4L/DVB (5582): Added support for Sabrent TV-PCB05 card.

Jan Engelhardt (2):
      V4L/DVB (5586): Use menuconfig objects II - V4L
      V4L/DVB (5599): Use menuconfig objects II - DVB

Jean Delvare (1):
      V4L/DVB (5618): Cx88: Drop the generic i2c client from cx88-vp3054-i2c

Jiri Slaby (1):
      V4L/DVB (5617): V4L2: videodev, allow debugging

Jon Burgess (1):
      V4L/DVB (5592): DMA: Correctly free resources on error, sync PCI streamed data

Luca Risolia (1):
      V4L/DVB (5585): SN9C1xx driver updates

Matthias Kaehlcke (1):
      V4L/DVB (5572): Pvrusb2: use mutex instead of semaphore

Mauro Carvalho Chehab (4):
      V4L/DVB (5569): Fix: v4l1_compat should be called only if V4L1_COMPAT
      V4L/DVB (5587): Add help for RADIO_ADAPTERS and VIDEO_CAPTURE_DRIVERS
      V4L/DVB (5600): Allow compiling just DVB CORE
      V4L/DVB (5601): Create a menu for DAB

Michael Krufky (5):
      V4L/DVB (5606): M920x: add "c-basic-offset: 8" to help emacs to enforce tabbing
      V4L/DVB (5608): M920x: various whitespace cleanups
      V4L/DVB (5609): M920x: group like functions together
      V4L/DVB (5610): M920x: remove duplicated code
      V4L/DVB (5619): Dvb-usb: fix typo

Mike Isely (2):
      V4L/DVB (5574): Pvrusb2: Improve handling of PAL-60 video standard
      V4L/DVB (5575): Pvrusb2: Implement ability to disable IR receiver

Nick Andrew (2):
      V4L/DVB (5605): M920x: Add support for LifeView TV Walker Twin
      V4L/DVB (5614): M920x: Disable second adapter on LifeView TV Walker Twin

Oliver Endriss (1):
      V4L/DVB (5593): Budget-ci: Fix tuning for TDM 1316 (160..200 MHz)

Pat Erley (1):
      V4L/DVB (5602): Enable DiSEqC in Starbox II (vp7021a)

Robert P. J. Day (1):
      V4L/DVB (5583): VIDEO4LINUX-2: Replace MINOR() with a call to iminor().

Sakari Ailus (1):
      V4L/DVB (5603): V4L: Prevent queueing queued buffers.

Sam Revitch (1):
      V4L/DVB (5568): VIDIOCGMBUF handling in video_ioctl2()

Servaas Vandenberghe (1):
      V4L/DVB (5576): Improve / fix support for PAL-60 in cx25840

Simon Farnsworth (1):
      V4L/DVB (5580): Add support for three cards to saa7134 driver

Tejun Heo (1):
      V4L/DVB (5573): Pvrusb2: kill unnecessary attribute->owner

Thomas Gleixner (1):
      V4L/DVB (5566): MEDIA: Spinlock initializer cleanup

Trent Piepho (2):
      V4L/DVB (5570): V4l1-compat: misc fixes for pixelformat function
      V4L/DVB (5571): V4l1-compat:  Make VIDIOCSPICT return errors in a useful way

holger@muscate-magnussen.de (1):
      V4L/DVB (5578): Workaround for bad hardare/firmware on some pluto2 devices

---------------------------------------------------
V4L/DVB development is hosted at http://linuxtv.org


^ permalink raw reply	[flat|nested] 31+ messages in thread

* [GIT PATCHES] V4L/DVB updates
@ 2007-05-01 17:40 Mauro Carvalho Chehab
  0 siblings, 0 replies; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-05-01 17:40 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, linux-dvb-maintainer, video4linux-list, linux-kernel

Linus,

Please pull from:
        ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master

This series contains a few fixes and cleanups, including a compilation fix for alpha
architecture:

   - Cx88: fix compilation on alpha
   - MEDIA: Spinlock initializer cleanup
   - Cx88-mpeg.c: make 2 functions static
   - VIDIOCGMBUF handling in video_ioctl2()
   - Fix: v4l1_compat should be called only if V4L1_COMPAT
   - V4l1-compat: misc fixes for pixelformat function
   - V4l1-compat:  Make VIDIOCSPICT return errors in a useful way
   - Pvrusb2: use mutex instead of semaphore
   - Pvrusb2: kill unnecessary attribute->owner
   - Pvrusb2: Improve handling of PAL-60 video standard
   - Pvrusb2: Implement ability to disable IR receiver
   - Improve / fix support for PAL-60 in cx25840
   - Workaround for bad hardare/firmware on some pluto2 devices

Cheers,
Mauro.

---

 drivers/media/dvb/pluto2/pluto2.c              |    8 +++
 drivers/media/video/cx25840/cx25840-core.c     |    4 +-
 drivers/media/video/cx88/cx88-alsa.c           |    1 +
 drivers/media/video/cx88/cx88-mpeg.c           |    5 +-
 drivers/media/video/cx88/cx88-video.c          |    1 +
 drivers/media/video/ivtv/ivtv-driver.c         |    2 +-
 drivers/media/video/pvrusb2/pvrusb2-encoder.c  |   13 ++++-
 drivers/media/video/pvrusb2/pvrusb2-hdw.c      |   10 ++--
 drivers/media/video/pvrusb2/pvrusb2-i2c-core.c |   23 ++++++++-
 drivers/media/video/pvrusb2/pvrusb2-sysfs.c    |   14 -----
 drivers/media/video/v4l1-compat.c              |   64 +++++++++++++++++------
 drivers/media/video/videodev.c                 |   48 +++++++++++-------
 12 files changed, 130 insertions(+), 63 deletions(-)

Adrian Bunk (1):
      V4L/DVB (5567): Cx88-mpeg.c: make 2 functions static

Alexey Dobriyan (1):
      V4L/DVB (5565): Cx88: fix compilation on alpha

Matthias Kaehlcke (1):
      V4L/DVB (5572): Pvrusb2: use mutex instead of semaphore

Mauro Carvalho Chehab (1):
      V4L/DVB (5569): Fix: v4l1_compat should be called only if V4L1_COMPAT

Mike Isely (2):
      V4L/DVB (5574): Pvrusb2: Improve handling of PAL-60 video standard
      V4L/DVB (5575): Pvrusb2: Implement ability to disable IR receiver

Sam Revitch (1):
      V4L/DVB (5568): VIDIOCGMBUF handling in video_ioctl2()

Servaas Vandenberghe (1):
      V4L/DVB (5576): Improve / fix support for PAL-60 in cx25840

Tejun Heo (1):
      V4L/DVB (5573): Pvrusb2: kill unnecessary attribute->owner

Thomas Gleixner (1):
      V4L/DVB (5566): MEDIA: Spinlock initializer cleanup

Trent Piepho (2):
      V4L/DVB (5570): V4l1-compat: misc fixes for pixelformat function
      V4L/DVB (5571): V4l1-compat:  Make VIDIOCSPICT return errors in a useful way

holger@muscate-magnussen.de (1):
      V4L/DVB (5578): Workaround for bad hardare/firmware on some pluto2 devices

---------------------------------------------------
V4L/DVB development is hosted at http://linuxtv.org


^ permalink raw reply	[flat|nested] 31+ messages in thread

* [GIT PATCHES] V4L/DVB updates
@ 2007-04-27 19:59 Mauro Carvalho Chehab
  2007-05-09  6:30 ` Geert Uytterhoeven
  0 siblings, 1 reply; 31+ messages in thread
From: Mauro Carvalho Chehab @ 2007-04-27 19:59 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, linux-dvb-maintainer, video4linux-list, linux-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 31312 bytes --]

Linus,

Please pull from:
        ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master

A short changelog:

   - New drivers:
        ivtv driver for Hauppauge PVR series and similar boards;
	ZR364xx USB driver;
        Opera S1 DVB USB driver;
        TDA10023 DVB frontend driver;
	TDA827x DVB tuner driver;

   - Add support for the following cards:
	AverMedia M102 miniPCI;
	Identify MSI TV@nywhere Duo;
        Pinnacle PCTV Sat Pro USB;
        Some missing Hauppauge and Belkin boards;
        Autodetect ADS Tech InstantTV DVB-S;
        Some ASUS hybrid boards;
        Anubis Electronics / MSI Digi Vox Mini II;
        Cisco VT Camera support;
        Remote of Asustech P7131 Hybrid LNA;
        Logitech ViewPort AV 100.

   - V4L API improvements;

   - Several cleanups, fixes and driver improvements.

Cheers,
Mauro.

---

 Documentation/feature-removal-schedule.txt         |   12 +
 Documentation/video4linux/CARDLIST.bttv            |    2 +
 Documentation/video4linux/CARDLIST.cx88            |    2 +-
 Documentation/video4linux/CARDLIST.ivtv            |   18 +
 Documentation/video4linux/CARDLIST.saa7134         |    8 +-
 Documentation/video4linux/CARDLIST.usbvision       |   64 +
 Documentation/video4linux/README.ivtv              |  187 +++
 .../video4linux/cx2341x/fw-decoder-regs.txt        |   12 +-
 .../video4linux/cx2341x/fw-encoder-api.txt         |   19 +-
 Documentation/video4linux/cx2341x/fw-osd-api.txt   |   12 +-
 Documentation/video4linux/sn9c102.txt              |   64 +-
 Documentation/video4linux/zr364xx.txt              |   65 +
 MAINTAINERS                                        |   46 +-
 drivers/media/common/ir-keymaps.c                  |   18 +-
 drivers/media/common/saa7146_video.c               |    6 +
 drivers/media/dvb/b2c2/Kconfig                     |    1 -
 drivers/media/dvb/b2c2/flexcop-fe-tuner.c          |    3 +-
 drivers/media/dvb/b2c2/flexcop-pci.c               |    9 +-
 drivers/media/dvb/bt8xx/Kconfig                    |    2 +-
 drivers/media/dvb/bt8xx/bt878.c                    |    4 +-
 drivers/media/dvb/bt8xx/dvb-bt8xx.c                |    3 +-
 drivers/media/dvb/bt8xx/dvb-bt8xx.h                |    2 +-
 drivers/media/dvb/dvb-core/dmxdev.c                |   56 +-
 drivers/media/dvb/dvb-core/dmxdev.h                |    2 +
 drivers/media/dvb/dvb-core/dvb_frontend.c          |   20 +-
 drivers/media/dvb/dvb-core/dvb_net.c               |   32 +-
 drivers/media/dvb/dvb-core/dvb_net.h               |    1 +
 drivers/media/dvb/dvb-core/dvbdev.c                |    1 +
 drivers/media/dvb/dvb-core/dvbdev.h                |    1 +
 drivers/media/dvb/dvb-usb/Kconfig                  |   12 +-
 drivers/media/dvb/dvb-usb/Makefile                 |    4 +
 drivers/media/dvb/dvb-usb/au6610.c                 |    6 +-
 drivers/media/dvb/dvb-usb/cxusb.c                  |    4 +-
 drivers/media/dvb/dvb-usb/dib0700_core.c           |    4 -
 drivers/media/dvb/dvb-usb/dvb-usb-ids.h            |    6 +
 drivers/media/dvb/dvb-usb/gl861.c                  |    8 +-
 drivers/media/dvb/dvb-usb/m920x.c                  |  235 ++-
 drivers/media/dvb/dvb-usb/m920x.h                  |   46 +-
 drivers/media/dvb/dvb-usb/opera1.c                 |  581 ++++++++
 drivers/media/dvb/dvb-usb/opera1.h                 |    9 +
 drivers/media/dvb/dvb-usb/ttusb2.c                 |    7 +-
 drivers/media/dvb/frontends/Kconfig                |   28 +-
 drivers/media/dvb/frontends/Makefile               |    3 +-
 drivers/media/dvb/frontends/dvb-pll.c              |  340 +++--
 drivers/media/dvb/frontends/dvb-pll.h              |   16 +-
 drivers/media/dvb/frontends/lgdt330x.c             |    4 +-
 drivers/media/dvb/frontends/lgh06xf.c              |  134 --
 drivers/media/dvb/frontends/lgh06xf.h              |   35 -
 drivers/media/dvb/frontends/or51132.c              |  305 ++---
 drivers/media/dvb/frontends/tda10021.c             |   47 +-
 drivers/media/dvb/frontends/tda10023.c             |  540 +++++++
 .../media/dvb/frontends/{tda10021.h => tda1002x.h} |   33 +-
 drivers/media/dvb/frontends/tda1004x.c             |   98 +-
 drivers/media/dvb/frontends/tda1004x.h             |   54 +-
 drivers/media/dvb/frontends/tda827x.c              |  512 +++++++
 drivers/media/dvb/frontends/tda827x.h              |   62 +
 drivers/media/dvb/pluto2/Kconfig                   |    1 -
 drivers/media/dvb/ttpci/Kconfig                    |    6 +-
 drivers/media/dvb/ttpci/av7110.c                   |   17 +-
 drivers/media/dvb/ttpci/av7110.h                   |   28 +-
 drivers/media/dvb/ttpci/av7110_av.c                |   24 +-
 drivers/media/dvb/ttpci/av7110_hw.h                |   10 +-
 drivers/media/dvb/ttpci/av7110_ir.c                |  365 +++--
 drivers/media/dvb/ttpci/budget-av.c                |  147 +-
 drivers/media/dvb/ttpci/budget-ci.c                |   96 +-
 drivers/media/dvb/ttpci/budget-core.c              |   58 +-
 drivers/media/dvb/ttpci/budget.h                   |    3 +
 drivers/media/dvb/ttusb-budget/Kconfig             |    1 -
 drivers/media/radio/radio-aimslab.c                |  240 ++--
 drivers/media/radio/radio-gemtek-pci.c             |  253 ++--
 drivers/media/radio/radio-gemtek.c                 |  260 ++--
 drivers/media/radio/radio-maestro.c                |  266 ++--
 drivers/media/radio/radio-rtrack2.c                |  255 ++--
 drivers/media/radio/radio-sf16fmi.c                |  262 ++--
 drivers/media/radio/radio-sf16fmr2.c               |  350 +++--
 drivers/media/radio/radio-terratec.c               |  247 ++--
 drivers/media/radio/radio-trust.c                  |  256 ++--
 drivers/media/radio/radio-typhoon.c                |  239 ++--
 drivers/media/radio/radio-zoltrix.c                |  256 ++--
 drivers/media/video/Kconfig                        |   14 +
 drivers/media/video/Makefile                       |    2 +
 drivers/media/video/bt8xx/bttv-cards.c             |   53 +-
 drivers/media/video/bt8xx/bttv-driver.c            |   24 +-
 drivers/media/video/bt8xx/bttv-gpio.c              |    5 -
 drivers/media/video/bt8xx/bttv-i2c.c               |    2 +-
 drivers/media/video/bt8xx/bttv-if.c                |   48 -
 drivers/media/video/bt8xx/bttv.h                   |   25 +-
 drivers/media/video/bt8xx/bttvp.h                  |    3 +
 drivers/media/video/cafe_ccic.c                    |   79 +-
 drivers/media/video/cpia_pp.c                      |   49 +-
 drivers/media/video/cs53l32a.c                     |    4 +
 drivers/media/video/cx2341x.c                      |   72 +-
 drivers/media/video/cx25840/cx25840-core.c         |    9 +-
 drivers/media/video/cx25840/cx25840-core.h         |    3 +-
 drivers/media/video/cx25840/cx25840-firmware.c     |    1 -
 drivers/media/video/cx88/Kconfig                   |    1 -
 drivers/media/video/cx88/cx88-alsa.c               |    9 +-
 drivers/media/video/cx88/cx88-cards.c              |   37 +-
 drivers/media/video/cx88/cx88-core.c               |    8 +-
 drivers/media/video/cx88/cx88-dvb.c                |   31 +-
 drivers/media/video/cx88/cx88-i2c.c                |    3 +-
 drivers/media/video/cx88/cx88-mpeg.c               |   29 +-
 drivers/media/video/cx88/cx88-video.c              |    5 +-
 drivers/media/video/cx88/cx88.h                    |    4 +-
 drivers/media/video/em28xx/em28xx-i2c.c            |    2 +-
 drivers/media/video/ir-kbd-i2c.c                   |    2 +-
 drivers/media/video/ivtv/Kconfig                   |   26 +
 drivers/media/video/ivtv/Makefile                  |    7 +
 drivers/media/video/ivtv/ivtv-audio.c              |   74 +
 drivers/media/video/ivtv/ivtv-audio.h              |   23 +
 drivers/media/video/ivtv/ivtv-cards.c              |  964 ++++++++++++
 drivers/media/video/ivtv/ivtv-cards.h              |  207 +++
 drivers/media/video/ivtv/ivtv-controls.c           |  303 ++++
 drivers/media/video/ivtv/ivtv-controls.h           |   21 +
 drivers/media/video/ivtv/ivtv-driver.c             | 1374 +++++++++++++++++
 drivers/media/video/ivtv/ivtv-driver.h             |  868 +++++++++++
 drivers/media/video/ivtv/ivtv-fileops.c            |  921 ++++++++++++
 drivers/media/video/ivtv/ivtv-fileops.h            |   44 +
 drivers/media/video/ivtv/ivtv-firmware.c           |  272 ++++
 drivers/media/video/ivtv/ivtv-firmware.h           |   25 +
 drivers/media/video/ivtv/ivtv-gpio.c               |  307 ++++
 drivers/media/video/ivtv/ivtv-gpio.h               |   25 +
 drivers/media/video/ivtv/ivtv-i2c.c                |  748 ++++++++++
 drivers/media/video/ivtv/ivtv-i2c.h                |   36 +
 drivers/media/video/ivtv/ivtv-ioctl.c              | 1567 ++++++++++++++++++++
 drivers/media/video/ivtv/ivtv-ioctl.h              |   28 +
 drivers/media/video/ivtv/ivtv-irq.c                |  838 +++++++++++
 drivers/media/video/ivtv/ivtv-irq.h                |   26 +
 drivers/media/video/ivtv/ivtv-mailbox.c            |  360 +++++
 drivers/media/video/ivtv/ivtv-mailbox.h            |   25 +
 drivers/media/video/ivtv/ivtv-queue.c              |  262 ++++
 drivers/media/video/ivtv/ivtv-queue.h              |   64 +
 drivers/media/video/ivtv/ivtv-streams.c            |  977 ++++++++++++
 drivers/media/video/ivtv/ivtv-streams.h            |   31 +
 drivers/media/video/ivtv/ivtv-udma.c               |  200 +++
 drivers/media/video/ivtv/ivtv-udma.h               |   43 +
 drivers/media/video/ivtv/ivtv-vbi.c                |  538 +++++++
 drivers/media/video/ivtv/ivtv-vbi.h                |   26 +
 drivers/media/video/ivtv/ivtv-version.h            |   26 +
 drivers/media/video/ivtv/ivtv-video.c              |  142 ++
 drivers/media/video/ivtv/ivtv-video.h              |   24 +
 drivers/media/video/ivtv/ivtv-yuv.c                | 1129 ++++++++++++++
 drivers/media/video/ivtv/ivtv-yuv.h                |   24 +
 drivers/media/video/msp3400-driver.c               |    5 +
 drivers/media/video/msp3400-driver.h               |    1 +
 drivers/media/video/ov7670.c                       |   40 +-
 drivers/media/video/planb.c                        |    6 +-
 drivers/media/video/planb.h                        |    1 +
 drivers/media/video/pvrusb2/pvrusb2-encoder.c      |    2 +-
 drivers/media/video/pvrusb2/pvrusb2-hdw-internal.h |    2 +
 drivers/media/video/pvrusb2/pvrusb2-hdw.c          |   16 +-
 drivers/media/video/pvrusb2/pvrusb2-hdw.h          |    3 +
 drivers/media/video/pvrusb2/pvrusb2-sysfs.c        |   30 +
 drivers/media/video/pvrusb2/pvrusb2-v4l2.c         |    2 +
 drivers/media/video/pwc/pwc-ctrl.c                 |   61 +-
 drivers/media/video/pwc/pwc-if.c                   |   16 +-
 drivers/media/video/pwc/pwc-ioctl.h                |   36 +-
 drivers/media/video/pwc/pwc-kiara.c                |    2 +
 drivers/media/video/pwc/pwc-kiara.h                |    5 +-
 drivers/media/video/pwc/pwc-timon.c                |    4 +-
 drivers/media/video/pwc/pwc-timon.h                |    6 +-
 drivers/media/video/pwc/pwc-v4l.c                  |   60 +-
 drivers/media/video/pwc/pwc.h                      |    5 +-
 drivers/media/video/saa7115.c                      |   10 +-
 drivers/media/video/saa7127.c                      |   12 +-
 drivers/media/video/saa7134/Kconfig                |    1 +
 drivers/media/video/saa7134/saa7134-cards.c        |  204 +++-
 drivers/media/video/saa7134/saa7134-core.c         |  125 +-
 drivers/media/video/saa7134/saa7134-dvb.c          | 1027 +++++--------
 drivers/media/video/saa7134/saa7134-i2c.c          |    4 +-
 drivers/media/video/saa7134/saa7134-input.c        |    1 +
 drivers/media/video/saa7134/saa7134-video.c        |   85 +-
 drivers/media/video/saa7134/saa7134.h              |   10 +-
 drivers/media/video/se401.c                        |   36 +-
 drivers/media/video/sn9c102/Kconfig                |    2 +-
 drivers/media/video/sn9c102/Makefile               |   17 +-
 drivers/media/video/sn9c102/sn9c102.h              |   17 +-
 drivers/media/video/sn9c102/sn9c102_core.c         |  274 +++--
 drivers/media/video/sn9c102/sn9c102_devtable.h     |   14 +-
 drivers/media/video/sn9c102/sn9c102_hv7131d.c      |   25 +-
 drivers/media/video/sn9c102/sn9c102_hv7131r.c      |  366 +++++
 drivers/media/video/sn9c102/sn9c102_mi0343.c       |  130 +-
 drivers/media/video/sn9c102/sn9c102_mi0360.c       |  338 +++++
 drivers/media/video/sn9c102/sn9c102_ov7630.c       |  121 +-
 drivers/media/video/sn9c102/sn9c102_ov7660.c       |  234 +--
 drivers/media/video/sn9c102/sn9c102_pas106b.c      |   23 +-
 drivers/media/video/sn9c102/sn9c102_pas202bcb.c    |   77 +-
 drivers/media/video/sn9c102/sn9c102_sensor.h       |   12 +-
 drivers/media/video/sn9c102/sn9c102_tas5110c1b.c   |   18 +-
 drivers/media/video/sn9c102/sn9c102_tas5110d.c     |  118 ++
 drivers/media/video/sn9c102/sn9c102_tas5130d1b.c   |   19 +-
 drivers/media/video/tda7432.c                      |    1 -
 drivers/media/video/tda8290.c                      |  144 ++-
 drivers/media/video/tda9875.c                      |    1 -
 drivers/media/video/tuner-core.c                   |   28 +-
 drivers/media/video/tvaudio.c                      |    5 +-
 drivers/media/video/tveeprom.c                     |   45 +-
 drivers/media/video/upd64031a.c                    |    4 +
 drivers/media/video/upd64083.c                     |    5 +
 drivers/media/video/usbvideo/usbvideo.c            |   18 +-
 drivers/media/video/usbvision/usbvision-cards.c    | 1165 +++++++++++++--
 drivers/media/video/usbvision/usbvision-cards.h    |   66 +
 drivers/media/video/usbvision/usbvision-core.c     |   10 +-
 drivers/media/video/usbvision/usbvision-i2c.c      |  104 +-
 drivers/media/video/usbvision/usbvision-video.c    |  173 +--
 drivers/media/video/usbvision/usbvision.h          |   39 +-
 drivers/media/video/v4l2-common.c                  |   41 +-
 drivers/media/video/videocodec.c                   |    3 +
 drivers/media/video/videodev.c                     |   40 +-
 drivers/media/video/wm8739.c                       |    4 +
 drivers/media/video/wm8775.c                       |    4 +
 drivers/media/video/zr364xx.c                      |  929 ++++++++++++
 include/linux/dvb/audio.h                          |    5 +-
 include/linux/dvb/version.h                        |    2 +-
 include/linux/dvb/video.h                          |   62 +
 include/linux/videodev2.h                          |   83 +-
 include/media/cx2341x.h                            |    6 +-
 include/media/ivtv.h                               |   65 +
 include/media/tuner.h                              |    5 +
 include/media/v4l2-chip-ident.h                    |  149 ++
 include/media/v4l2-common.h                        |   47 +-
 include/media/v4l2-dev.h                           |   10 +
 222 files changed, 23073 insertions(+), 4357 deletions(-)
 create mode 100644 Documentation/video4linux/CARDLIST.ivtv
 create mode 100644 Documentation/video4linux/CARDLIST.usbvision
 create mode 100644 Documentation/video4linux/README.ivtv
 create mode 100644 Documentation/video4linux/zr364xx.txt
 create mode 100644 drivers/media/dvb/dvb-usb/opera1.c
 create mode 100644 drivers/media/dvb/dvb-usb/opera1.h
 delete mode 100644 drivers/media/dvb/frontends/lgh06xf.c
 delete mode 100644 drivers/media/dvb/frontends/lgh06xf.h
 create mode 100644 drivers/media/dvb/frontends/tda10023.c
 rename drivers/media/dvb/frontends/{tda10021.h => tda1002x.h} (66%)
 create mode 100644 drivers/media/dvb/frontends/tda827x.c
 create mode 100644 drivers/media/dvb/frontends/tda827x.h
 create mode 100644 drivers/media/video/ivtv/Kconfig
 create mode 100644 drivers/media/video/ivtv/Makefile
 create mode 100644 drivers/media/video/ivtv/ivtv-audio.c
 create mode 100644 drivers/media/video/ivtv/ivtv-audio.h
 create mode 100644 drivers/media/video/ivtv/ivtv-cards.c
 create mode 100644 drivers/media/video/ivtv/ivtv-cards.h
 create mode 100644 drivers/media/video/ivtv/ivtv-controls.c
 create mode 100644 drivers/media/video/ivtv/ivtv-controls.h
 create mode 100644 drivers/media/video/ivtv/ivtv-driver.c
 create mode 100644 drivers/media/video/ivtv/ivtv-driver.h
 create mode 100644 drivers/media/video/ivtv/ivtv-fileops.c
 create mode 100644 drivers/media/video/ivtv/ivtv-fileops.h
 create mode 100644 drivers/media/video/ivtv/ivtv-firmware.c
 create mode 100644 drivers/media/video/ivtv/ivtv-firmware.h
 create mode 100644 drivers/media/video/ivtv/ivtv-gpio.c
 create mode 100644 drivers/media/video/ivtv/ivtv-gpio.h
 create mode 100644 drivers/media/video/ivtv/ivtv-i2c.c
 create mode 100644 drivers/media/video/ivtv/ivtv-i2c.h
 create mode 100644 drivers/media/video/ivtv/ivtv-ioctl.c
 create mode 100644 drivers/media/video/ivtv/ivtv-ioctl.h
 create mode 100644 drivers/media/video/ivtv/ivtv-irq.c
 create mode 100644 drivers/media/video/ivtv/ivtv-irq.h
 create mode 100644 drivers/media/video/ivtv/ivtv-mailbox.c
 create mode 100644 drivers/media/video/ivtv/ivtv-mailbox.h
 create mode 100644 drivers/media/video/ivtv/ivtv-queue.c
 create mode 100644 drivers/media/video/ivtv/ivtv-queue.h
 create mode 100644 drivers/media/video/ivtv/ivtv-streams.c
 create mode 100644 drivers/media/video/ivtv/ivtv-streams.h
 create mode 100644 drivers/media/video/ivtv/ivtv-udma.c
 create mode 100644 drivers/media/video/ivtv/ivtv-udma.h
 create mode 100644 drivers/media/video/ivtv/ivtv-vbi.c
 create mode 100644 drivers/media/video/ivtv/ivtv-vbi.h
 create mode 100644 drivers/media/video/ivtv/ivtv-version.h
 create mode 100644 drivers/media/video/ivtv/ivtv-video.c
 create mode 100644 drivers/media/video/ivtv/ivtv-video.h
 create mode 100644 drivers/media/video/ivtv/ivtv-yuv.c
 create mode 100644 drivers/media/video/ivtv/ivtv-yuv.h
 create mode 100644 drivers/media/video/sn9c102/sn9c102_hv7131r.c
 create mode 100644 drivers/media/video/sn9c102/sn9c102_mi0360.c
 create mode 100644 drivers/media/video/sn9c102/sn9c102_tas5110d.c
 create mode 100644 drivers/media/video/usbvision/usbvision-cards.h
 create mode 100644 drivers/media/video/zr364xx.c
 create mode 100644 include/media/ivtv.h
 create mode 100644 include/media/v4l2-chip-ident.h

Aapo Tahkola (5):
      V4L/DVB (5423): M920x: i2c cleanups
      V4L/DVB (5424): Fix i2c implementation for gl861 and au6610
      V4L/DVB (5425): M920x: rework driver code to allow for different devices
      V4L/DVB (5426): M920x: remove unneeded code
      V4L/DVB (5448): M920x: rename megasky_identify_state to m920x_identify_state

Adrian Bunk (5):
      V4L/DVB (5278): Bt8xx/: possible cleanups
      V4L/DVB (5293): Make dvb_usb_gl861_debug static
      V4L/DVB (5294): Make pvr2_encoder_prep_config() static
      V4L/DVB (5397): Saa7134: fix MODULES=n compilation
      V4L/DVB (5471): Cpia_pp.c: convert to module_{init,exit}

Akinobu Mita (1):
      V4L/DVB (5513): Bt878: prevent probing wrong card entry

Alan Cox (2):
      V4L/DVB (5551): Plan-b: header change
      V4L/DVB (5552): Plan-b: Switch to refcounting PCI API

Amit Choudhary (2):
      V4L/DVB (5489): Codec.c: check kmalloc() return value.
      V4L/DVB (5490): Drivers/media/video/se401.c: check kmalloc() return value.

Andrew Morton (1):
      V4L/DVB (5388): Ivtv warning fix

Antoine Jacquet (2):
      V4L/DVB (5257): USB: add zr364xx V4L2 driver
      V4L/DVB (5385): Fix compilation issue with zr364xx when V4L1 is disabled

Christophe Cattelain (1):
      V4L/DVB (5371): [PATCH] Pinnacle PCTV Sat Pro USB (450e) support by ttusb2.c (400e driver)

Damian Minkov (1):
      V4L/DVB (5481): Fix audio input for AverTv Go 007

David Härdeman (1):
      V4L/DVB (5335): Budget-ci: Use the repeat handling of the input subsystem

Dennis Ranke (1):
      V4L/DVB (5373): [PATCH] Hauppauge Nova-T endianess problem on powerpc

Douglas Landgraf (12):
      V4L/DVB (5534): Radio-rtrack2.c Replace rt_ioctl to use video_ioctl2
      V4L/DVB (5539): Radio-rtrack2.c Added VIDIOC_[GS]_AUDIO and VIDIOC_[S|G]_INPUT
      V4L/DVB (5540): Radio-trust.c Replace tr_do_ioctl to use video_ioctl2
      V4L/DVB (5541): Radio-zoltrix.c Replace zol_do_ioctl to use video_ioctl2
      V4L/DVB (5546): Radio-terratec.c Replace tt_do_ioctl to use video_ioctl2
      V4L/DVB (5549): Radio-sf16fmr2.c Replace fmr2_do_ioctl to use video_ioctl2
      V4L/DVB (5550): Radio-sf16fmi.c Replace fmi_do_ioctl to use video_ioctl2
      V4L/DVB (5553): Replace typhoon_do_ioctl to use video_ioctl2
      V4L/DVB (5555): Radio-aimslab.c Replace rt_ioctl to use video_ioctl2
      V4L/DVB (5556): Radio-gemtek.c Replace gemtek_ioctl to use video_ioctl2
      V4L/DVB (5562): Radio-gemtek-pci.c Replace gemtek_pci_ioctl to use video_ioctl2
      V4L/DVB (5563): Radio-maestro.c Replace radio_ioctl to use video_ioctl2

Dwaine P. Garden (1):
      V4L/DVB (5386): Add some missing Hauppauge and Belkin devices to the driver

Ed Vipas (1):
      V4L/DVB (5486): Add support for remote of Asustech P7131 Hybrid	LNA

Emil Georgiev (1):
      V4L/DVB (5383): Fix duplicated codes in Pinnacle Grey remote

Hans Verkuil (36):
      V4L/DVB (5268): Add support for three new MPEG controls.
      V4L/DVB (5272): Add V4L2_CAP_VIDEO_OUTPUT_POS capability
      V4L/DVB (5289): Add support for video output overlays.
      V4L/DVB (5290): Add support for VIDIOC_INT_G/S_STD_OUTPUT
      V4L/DVB (5306): Add support for VIDIOC_G_CHIP_IDENT
      V4L/DVB (5307): Add support for the cx23415 MPEG decoding features.
      V4L/DVB (5336): Cx23416 doc updates + rename CX2341X_ENC_UNKNOWN
      V4L/DVB (5341): Add cx23415/6 chip idents.
      V4L/DVB (5345): ivtv driver for Conexant cx23416/cx23415 MPEG encoder/decoder
      V4L/DVB (5355): Add VIDIOC_G_CHIP_IDENT to various i2c modules
      V4L/DVB (5356): Fix bogus error messages in ivtv for VIDIOC_G_CHIP_IDENT
      V4L/DVB (5375): Add missing VIDEO_CX25840 dep, remove unused VIDEO_TLV320AIC23B dep
      V4L/DVB (5376): Add dependency on VIDEO_V4L1
      V4L/DVB (5377): Replace SA_* with IRQF_*
      V4L/DVB (5378): Add missing IVTV_FB_WARN #define
      V4L/DVB (5379): If possible make vars/functions static.
      V4L/DVB (5389): Add tveeprom entry for tuner LG S701D MK3
      V4L/DVB (5402): Add vsync_field to the union in video_event for VIDEO_EVENT_VSYNC
      V4L/DVB (5403): Set vsync_field correctly in ivtv.
      V4L/DVB (5404): Merges VBI & YUV handling into a single work queue.
      V4L/DVB (5405): Add missing includes.
      V4L/DVB (5406): Add comment why the symbols are exported.
      V4L/DVB (5407a): Update feature-removal-schedule.txt: remove VIDIOC_S/G_MPEGCOMP
      V4L/DVB (5409): Add CARDLIST.ivtv and README.ivtv
      V4L/DVB (5410): Add VIDIOC_G/S_PRIORITY support to ivtv.
      V4L/DVB (5411): Use v4l_printk_ioctl for debug
      V4L/DVB (5412): Fix VIDIOC_TRY_ENCODER_CMD and VIDEO_TRY_COMMAND
      V4L/DVB (5413): Use spin_lock_init to fix lockdep warnings.
      V4L/DVB (5414): Add missing kfree in early exit of saa7115.
      V4L/DVB (5416): Use pci_register_driver instead of pci_module_init in ivtv.
      V4L/DVB (5417): First unregister the driver, and then free the memory.
      V4L/DVB (5418): Speed is a signed 32-bit integer, not unsigned.
      V4L/DVB (5419): Add comment how the speed field is interpreted.
      V4L/DVB (5420): Initialize the inputs before registering the devices.
      V4L/DVB (5436): Fix TV output initialization
      V4L/DVB (5560): Ivtv: fix incorrect bitwise-and for command flags.

Hartmut Birr (4):
      V4L/DVB (5542): Budget-av: Remove polarity switching of the clock for DVB-C
      V4L/DVB (5543): Tda10023: Add support for frontend TDA10023
      V4L/DVB (5544): Budget-av: Make inversion setting configurable, add KNC ONE V1.0 card
      V4L/DVB (5545): Saa7146: Release capture buffers on device close

Hartmut Hackmann (20):
      V4L/DVB (5311): Tda1004x driver updates
      V4L/DVB (5312): Saa713x: added a GPIO handler function
      V4L/DVB (5313): Added a config entry and a gpio function pointer to tuner struct
      V4L/DVB (5314): Added support for tda827x tuners with preamlifiers
      V4L/DVB (5315): Tda1004x: check request firmware for NULL ponter again
      V4L/DVB (5318): Fix tda8290 code for tda827x module
      V4L/DVB (5319): Set tda827x to sleep mode after attach
      V4L/DVB (5320): Filled in limiting values in tda827x.c
      V4L/DVB (5321): Saa7134-dvb: initialize the dvb frontend in dvb_init
      V4L/DVB (5322): Removed board naming code in saa7134-dvb
      V4L/DVB (5323): Updated support for tuner callbacks
      V4L/DVB (5326): Allow to set tuner_config in attach inform
      V4L/DVB (5369): Fixed 1 byte too short buffer in tda827x.c
      V4L/DVB (5443): Saa7134: put tuner to sleep mode after board initialization
      V4L/DVB (5444): Saa7134-dvb fix sleep function of the fmd1216 tuner.
      V4L/DVB (5445): Added / corrected support for some ASUS hybrid boards
      V4L/DVB (5446): Renamed ASUStek P7131 card [1043:4876]
      V4L/DVB (5458): Tda1004x: add ts_mode option to config struct
      V4L/DVB (5484): Set tda8290 to analog mode after init
      V4L/DVB (5485): Tda827x: delayed probing of tuner version

Heikki Orsila (1):
      V4L/DVB (5329): Some saa7134 cleanups

Hendrik Borghorst (1):
      V4L/DVB (5505): Fix Kernel Bugzilla #8301: spinlock fix for flexcop-pci

Ian Armstrong (2):
      V4L/DVB (5437): Update cx23415 documentation
      V4L/DVB (5438): Fix ivtv yuv threshold handling

Jarod Wilson (1):
      V4L/DVB (5482): Bttv: automatically load dvb-bt8xx for bttv cards with dvb

Jean Delvare (3):
      V4L/DVB (5380): Cx25840-firmware include cleanup
      V4L/DVB (5491): Cx88: Support the DTV1000 T analog inputs
      V4L/DVB (5492): Remove useless includes of i2c-algo-bit.h

Jean Tourrilhes (1):
      V4L/DVB (5461): Pwc: cisco VT Camera support

Jonathan Corbet (7):
      V4L/DVB (5464): Set the PCI device in the V4L2 device
      V4L/DVB (5465): Remove an obsolete PCI ID
      V4L/DVB (5466): Fix up some Cafe CCIC delay issues
      V4L/DVB (5467): Add suspend/resume support to the Cafe CCIC
      V4L/DVB (5468): Don't mirror ov7670 images by default
      V4L/DVB (5469a): Copyright and maintainer tweaks
      V4L/DVB (5469): Add raw bayer support to the ov7670 driver

Luc Saillard (2):
      V4L/DVB (5547): Add ENUM_FRAMESIZES and ENUM_FRAMEINTERVALS ioctls
      V4L/DVB (5548): Fix v4l2 buffer to the length

Luca Risolia (1):
      V4L/DVB (5474): SN9C1xx driver updates

Marco Gittler (2):
      V4L/DVB (5532): Add support for Opera S1- DVB-USB
      V4L/DVB (5558): Opera: use 7-bit i2c addresses

Markus Rechberger (7):
      V4L/DVB (5298): Added support for deferred module requesting to cx88
      V4L/DVB (5299): Added support for loading cx88-dvb and cx88-blackbird
      V4L/DVB (5324): This patch fixes request_module_depend()
      V4L/DVB (5330): Added card definition for AverMedia M102 miniPCI
      V4L/DVB (5510): Fix 1/3 for bug 7819: fixed frontend hotplug issue
      V4L/DVB (5511): Fix 2/3 for bug 7819: demux and dvr
      V4L/DVB (5512): Fix 3/3 for bug 7819: fixed hotplugging for dvbnet

Mauro Carvalho Chehab (14):
      V4L/DVB (5297): Fix identation on tda10021.c
      V4L/DVB (5462): Add Logitech ViewPort AV 100
      V4L/DVB (5476): Fix gpiomux array size
      V4L/DVB (5477): CodingStyle cleanups on for loops at bttv-cards.c
      V4L/DVB (5478): Use ARRAY_SIZE and a cleaner logic for initializing tuner
      V4L/DVB (5479): Use ARRAY_SIZE instead of a magic number
      V4L/DVB (5480): Fix cx88_print_irqbits calls to use ARRAY_SIZE
      V4L/DVB (5488): Replace DMA magic mask for its aliases
      V4L/DVB (5500): Add a CARDLIST for the supported devices by usbvision driver
      V4L/DVB (5515): Use a better format to represent usbvision supported boards
      V4L/DVB (5516): Reduce usbvision data size
      V4L/DVB (5518): Fix a bug on device detection
      V4L/DVB (5521): Usb_get_dev were called twice. Removing the extra call.
      V4L/DVB (5554): Fix: vidioc_g_parm were not zeroing the memory

Michael Krufky (3):
      V4L/DVB (5317): Create tda827x dvb tuner module
      V4L/DVB (5431): Cx88: autodetect ADS Tech InstantTV DVB-S
      V4L/DVB (5432): Cx88: whitespace cleanup

Mike Isely (2):
      V4L/DVB (5367): Pvrusb2: (trivial) Fix too-wide source line
      V4L/DVB (5507): Pvrusb2: Gather USB bus address info and report it

Oleg Nesterov (1):
      V4L/DVB (5398): Cpia_pp.c: don't use _WORK_NAR

Oliver Endriss (4):
      V4L/DVB (5334): Dvb-ttpci: Infrared remote control refactoring
      V4L/DVB (5344): Dvb-ttpci: Support for MSC_RAW and MSC_SCAN RC events
      V4L/DVB (5381): Dvb-ttpci: Update frontend lock status in transfer mode (bugfix)
      V4L/DVB (5440): Dvb-ttpci: Infrared remote initialization fix

Oliver Neukum (1):
      V4L/DVB (5399): Usbvideo module handling

Peter Missel (2):
      V4L/DVB (5316): Add radio support for the Lifeview FlyDVB-T Duo
      V4L/DVB (5331): Identify MSI TV@nywhere Duo

Pierre Willenbrock (2):
      V4L/DVB (5449): M920x: add error messages for debugging purposes
      V4L/DVB (5459): M920x: add support for Anubis Electronics / MSI Digi Vox Mini II

Scott Alfter (1):
      V4L/DVB (5497): Additional card support for bttv driver

Steven Toth (1):
      V4L/DVB (5434): Updates to the tveeprom tuner, video decoder and audio chip

Thierry MERLE (6):
      V4L/DVB (5522): Usbvision: i2c function cleanups
      V4L/DVB (5523): Usbvision: fix a debug message in usb probe function
      V4L/DVB (5524): Usbvision: fix TDA9887 detection
      V4L/DVB (5528): Usbvision: reverting some i2c cleanups
      V4L/DVB (5529): Usbvision: remove not needed TUNER_SET_TYPE_ADDR call
      V4L/DVB (5530): Usbvision: remove CustomDevice facility

Trent Piepho (20):
      V4L/DVB (5360): Dvb-pll: Use sizeof() to get name length
      V4L/DVB (5361): Dvb-pll: Fix Kconfig files and allow dvb-pll to be optional
      V4L/DVB (5362): Dvb-pll: add code for doing tuner initialization
      V4L/DVB (5363): Dvb: Remove lgh06xf driver
      V4L/DVB (5374): Or51132: refactor i2c code, improve error resilience
      V4L/DVB (5391): Saa7134: Clean up printk()s
      V4L/DVB (5392): Zr364xx: Use kernel's byte-swapping function
      V4L/DVB (5427): M920x: Improve I2C operations
      V4L/DVB (5428): M920x: Detect zero-length I2C messages and fix a typo
      V4L/DVB (5452): Cx88: merge identical boards
      V4L/DVB (5455): Dvb-pll: Adjust rounding to be consistent
      V4L/DVB (5456): Dvb-pll: Move IF frequency from per-band data to per-tuner data
      V4L/DVB (5457): Dvb-pll: Replace sleep function with a more capable one
      V4L/DVB (5494): Lgdt330x: Fix some warnings
      V4L/DVB (5502): Sn9c102: more efficient register writing code
      V4L/DVB (5503): Sn9c102: declare constant byte sequences as static const
      V4L/DVB (5504): Sn9c102: Make driver V4L2 not V4L1
      V4L/DVB (5517): Usbvision: store the device database more efficiently
      V4L/DVB (5525): Usbvision: fix confusion over 7-bit vs 8-bit TDDA9887 addresses
      V4L/DVB (5557): Cafe_ccic: check return value of pci_enable_device

Ville-Pekka Vainio (1):
      V4L/DVB (5520): Add support for the extra keys in the black Technotrend 1500 IR

vignesh.babu@wipro.com (1):
      V4L/DVB (5526): Cx88-alsa.c: Use kzalloc

---------------------------------------------------
V4L/DVB development is hosted at http://linuxtv.org


^ permalink raw reply	[flat|nested] 31+ messages in thread

end of thread, other threads:[~2008-03-20 15:18 UTC | newest]

Thread overview: 31+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-15 15:31 [GIT PATCHES] V4L/DVB updates Mauro Carvalho Chehab
2007-04-16  0:33 ` [v4l-dvb-maintainer] " Michael Krufky
2007-04-16  5:22   ` Manu Abraham
2007-04-16  8:17     ` Markus Rechberger
2007-04-16 10:00       ` Mauro Carvalho Chehab
2007-04-16 14:15   ` Adrian Bunk
2007-04-16 14:52     ` CIJOML
2007-04-16 15:00     ` CIJOML
2007-04-16 15:34     ` Michael Krufky
2007-04-16 16:16       ` Markus Rechberger
2007-04-27 21:34         ` Trent Piepho
2007-04-27 22:43           ` Markus Rechberger
2007-04-28  6:33             ` Trent Piepho
2007-04-28  9:47               ` Markus Rechberger
2007-04-16 16:18       ` CIJOML
2007-04-16 16:25         ` Michael Krufky
2007-04-16 22:15           ` hermann pitton
2007-04-17  3:42           ` Mauro Carvalho Chehab
2007-04-16 15:50 ` Dmitry Torokhov
2007-04-16 21:49   ` [v4l-dvb-maintainer] " Trent Piepho
2007-04-27 19:59 Mauro Carvalho Chehab
2007-05-09  6:30 ` Geert Uytterhoeven
2007-05-09 10:27   ` Mauro Carvalho Chehab
2007-05-09 19:05     ` Geert Uytterhoeven
2007-05-01 17:40 Mauro Carvalho Chehab
2007-05-08 18:05 Mauro Carvalho Chehab
2007-05-22 20:52 Mauro Carvalho Chehab
2007-07-16 21:34 Mauro Carvalho Chehab
2007-07-20 19:29 Mauro Carvalho Chehab
2007-12-24 12:37 Mauro Carvalho Chehab
2008-03-20 15:18 Mauro Carvalho Chehab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).