From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755929AbXD0PYK (ORCPT ); Fri, 27 Apr 2007 11:24:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755957AbXD0PYK (ORCPT ); Fri, 27 Apr 2007 11:24:10 -0400 Received: from mtagate8.de.ibm.com ([195.212.29.157]:4759 "EHLO mtagate8.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755929AbXD0PYH (ORCPT ); Fri, 27 Apr 2007 11:24:07 -0400 Subject: Re: [patch 18/38] Improved oops output. From: Martin Schwidefsky Reply-To: schwidefsky@de.ibm.com To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Heiko Carstens In-Reply-To: <20070427142506.GA12738@infradead.org> References: <20070427140503.087958775@de.ibm.com> <20070427140516.013904506@de.ibm.com> <20070427142506.GA12738@infradead.org> Content-Type: text/plain Organization: IBM Corporation Date: Fri, 27 Apr 2007 17:24:25 +0200 Message-Id: <1177687465.23773.2.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2007-04-27 at 15:25 +0100, Christoph Hellwig wrote: > On Fri, Apr 27, 2007 at 04:05:21PM +0200, Martin Schwidefsky wrote: > > From: Martin Schwidefsky > > > > This patch adds two improvements to the oops output. First it adds an > > additional line after the PSW which decodes the different fields of it. > > Second a disassembler is added that decodes the instructions surrounding > > the faulting PSW. The output of a test oops now looks like this: > > So we're growing in-kernel disassemblers now? :) > > I wonder whether this is really worth it, but at least your handwritten > one is much nicer than the copy & paste from gdb in the kdb patches. The disassembler uses about 8K of memory and it really helps in debugging. For me it is worth the cost. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.