LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de> To: linux-kernel@vger.kernel.org Cc: Michael Ellerman <michael@ellerman.id.au>, Greg Kroah-Hartman <gregkh@suse.de> Subject: [PATCH 35/46] debugfs: Add debugfs_create_u64() Date: Fri, 27 Apr 2007 11:53:49 -0700 [thread overview] Message-ID: <11777001682584-git-send-email-gregkh@suse.de> (raw) In-Reply-To: <11777001642551-git-send-email-gregkh@suse.de> From: Michael Ellerman <michael@ellerman.id.au> I went to use this the other day, only to find it didn't exist. It's a straight copy of the debugfs u32 code, then s/u32/u64/. A quick test shows it seems to be working. Signed-off-by: Michael Ellerman <michael@ellerman.id.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/debugfs/file.c | 42 ++++++++++++++++++++++++++++++++++++++++++ include/linux/debugfs.h | 9 +++++++++ 2 files changed, 51 insertions(+), 0 deletions(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 682f928..2e124e0 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -179,6 +179,48 @@ struct dentry *debugfs_create_u32(const char *name, mode_t mode, } EXPORT_SYMBOL_GPL(debugfs_create_u32); +static void debugfs_u64_set(void *data, u64 val) +{ + *(u64 *)data = val; +} + +static u64 debugfs_u64_get(void *data) +{ + return *(u64 *)data; +} +DEFINE_SIMPLE_ATTRIBUTE(fops_u64, debugfs_u64_get, debugfs_u64_set, "%llu\n"); + +/** + * debugfs_create_u64 - create a debugfs file that is used to read and write an unsigned 64-bit value + * @name: a pointer to a string containing the name of the file to create. + * @mode: the permission that the file should have + * @parent: a pointer to the parent dentry for this file. This should be a + * directory dentry if set. If this parameter is %NULL, then the + * file will be created in the root of the debugfs filesystem. + * @value: a pointer to the variable that the file should read to and write + * from. + * + * This function creates a file in debugfs with the given name that + * contains the value of the variable @value. If the @mode variable is so + * set, it can be read from, and written to. + * + * This function will return a pointer to a dentry if it succeeds. This + * pointer must be passed to the debugfs_remove() function when the file is + * to be removed (no automatic cleanup happens if your module is unloaded, + * you are responsible here.) If an error occurs, %NULL will be returned. + * + * If debugfs is not enabled in the kernel, the value -%ENODEV will be + * returned. It is not wise to check for this value, but rather, check for + * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling + * code. + */ +struct dentry *debugfs_create_u64(const char *name, mode_t mode, + struct dentry *parent, u64 *value) +{ + return debugfs_create_file(name, mode, parent, value, &fops_u64); +} +EXPORT_SYMBOL_GPL(debugfs_create_u64); + static ssize_t read_file_bool(struct file *file, char __user *user_buf, size_t count, loff_t *ppos) { diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h index 9fa0983..5a9c495 100644 --- a/include/linux/debugfs.h +++ b/include/linux/debugfs.h @@ -44,6 +44,8 @@ struct dentry *debugfs_create_u16(const char *name, mode_t mode, struct dentry *parent, u16 *value); struct dentry *debugfs_create_u32(const char *name, mode_t mode, struct dentry *parent, u32 *value); +struct dentry *debugfs_create_u64(const char *name, mode_t mode, + struct dentry *parent, u64 *value); struct dentry *debugfs_create_bool(const char *name, mode_t mode, struct dentry *parent, u32 *value); @@ -104,6 +106,13 @@ static inline struct dentry *debugfs_create_u32(const char *name, mode_t mode, return ERR_PTR(-ENODEV); } +static inline struct dentry *debugfs_create_u64(const char *name, mode_t mode, + struct dentry *parent, + u64 *value) +{ + return ERR_PTR(-ENODEV); +} + static inline struct dentry *debugfs_create_bool(const char *name, mode_t mode, struct dentry *parent, u32 *value) -- 1.5.1.2
next prev parent reply other threads:[~2007-04-27 19:09 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-04-27 18:51 [GIT PATCH] Driver core patches for 2.6.21 Greg KH 2007-04-27 18:53 ` [PATCH 01/46] driver core: fix device_add error path Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 02/46] driver core: fix namespace issue with devices assigned to classes Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 03/46] dev_printk and new-style class devices Greg Kroah-Hartman [not found] ` <11777000511784-git-send-email-gregkh@suse.de> 2007-04-27 18:53 ` [PATCH 05/46] driver core: Use attribute groups in struct device_type Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 06/46] Driver core: add name to device_type Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 07/46] kobject: kobject_shadow_add cleanup Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 08/46] driver core: per-subsystem multithreaded probing Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 09/46] powerpc: make it compile for multithread change Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 10/46] driver core: don't fail attaching the device if it cannot be bound Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 11/46] Driver core: remove unneeded completion from driver release path Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 12/46] kref: fix CPU ordering with respect to krefs Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 13/46] Driver core: notify userspace of network device renames Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 14/46] Driver core: suppress uevents via filter Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 15/46] Driver core: switch firmware_class to uevent_suppress Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 16/46] uevent: use add_uevent_var() instead of open coding it Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 17/46] Driver core: add suspend() and resume() to struct device_type Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 18/46] Kobject: kobject_uevent.c: Collapse unnecessary loop nesting (top_kobj) Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 19/46] kobject: kobject_add() reference leak Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 20/46] Driver core: remove use of rwsem Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 21/46] SCSI: use the proper semaphore to protect the class lists Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 22/46] USB: remove use of the bus rwsem, as it doesn't really protect anything Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 23/46] PNP: stop using the subsystem rwsem Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 24/46] Input: serio - do not touch bus's rwsem Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 25/46] Input: gameport " Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 26/46] IDE: remove rwsem use from ide-proc core Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 27/46] IEEE1394: remove rwsem use from ieee1394 core Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 28/46] PHY: remove rwsem use from phy core Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 29/46] qeth: Remove usage of subsys.rwsem Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 30/46] kobject core: remove rwsem from struct subsystem Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 31/46] Driver core: make uevent-environment available in uevent-file Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 32/46] Driver core: warn when userspace writes to the uevent file in a non-supported way Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 33/46] kobject: Comment and warning fixes to kobject.c Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 34/46] the overdue removal of the mount/umount uevents Greg Kroah-Hartman 2007-04-27 18:53 ` Greg Kroah-Hartman [this message] 2007-04-27 18:53 ` [PATCH 36/46] driver core: bus_add_driver should return an error if no bus Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 37/46] Driver core: use mutex instead of semaphore in DMA pool handler Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 38/46] sysfs: bin.c printk fix Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 39/46] s390: cio: Delay uevents for subchannels Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 40/46] device_schedule_callback() needs a module reference Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 41/46] security: prevent permission checking of file removal via sysfs_remove_group() Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 42/46] define platform wakeup hook, use in pci_enable_wake() Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 43/46] s2ram: add arch irq disable/enable hooks Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 44/46] mod_sysfs_setup() doesn't return errno when kobject_add_dir() failure occurs Greg Kroah-Hartman 2007-04-27 18:53 ` [PATCH 45/46] drivers/base/attribute_container.c: use mutex instead of binary semaphore Greg Kroah-Hartman 2007-04-27 18:54 ` [PATCH 46/46] dev_dbg: check dev_dbg() arguments Greg Kroah-Hartman 2007-04-27 21:11 ` [PATCH 28/46] PHY: remove rwsem use from phy core Andy Fleming 2007-04-27 20:27 ` [PATCH 04/46] Driver core: udev triggered device-driver binding Greg Kroah-Hartman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=11777001682584-git-send-email-gregkh@suse.de \ --to=gregkh@suse.de \ --cc=linux-kernel@vger.kernel.org \ --cc=michael@ellerman.id.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).