LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [RFC: 2.6 patch] drivers/mtd/maps/nettel.c: possible cleanups
@ 2007-04-26 23:47 Adrian Bunk
2007-04-27 22:35 ` David Woodhouse
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2007-04-26 23:47 UTC (permalink / raw)
To: Andrew Morton; +Cc: dwmw2, linux-mtd, linux-kernel
This patch contains the following possible cleanups:
- make 2 needlessly global functions static
- #if 0 the unused nettel_eraseconfig()
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch has been sent on:
- 27 Mar 2007
drivers/mtd/maps/nettel.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc4-mm1/drivers/mtd/maps/nettel.c.old 2007-03-26 16:04:25.000000000 +0200
+++ linux-2.6.21-rc4-mm1/drivers/mtd/maps/nettel.c 2007-03-26 16:09:39.000000000 +0200
@@ -158,6 +158,8 @@
nettel_reboot_notifier, NULL, 0
};
+#if 0
+
/*
* Erase the configuration file system.
* Used to support the software reset button.
@@ -208,18 +210,22 @@
return(0);
}
+#endif /* 0 */
+
#else
+#if 0
int nettel_eraseconfig(void)
{
return(0);
}
+#endif /* 0 */
#endif
/****************************************************************************/
-int __init nettel_init(void)
+static int __init nettel_init(void)
{
volatile unsigned long *amdpar;
unsigned long amdaddr, maxsize;
@@ -477,7 +483,7 @@
/****************************************************************************/
-void __exit nettel_cleanup(void)
+static void __exit nettel_cleanup(void)
{
#ifdef CONFIG_MTD_CFI_INTELEXT
unregister_reboot_notifier(&nettel_notifier_block);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC: 2.6 patch] drivers/mtd/maps/nettel.c: possible cleanups
2007-04-26 23:47 [RFC: 2.6 patch] drivers/mtd/maps/nettel.c: possible cleanups Adrian Bunk
@ 2007-04-27 22:35 ` David Woodhouse
0 siblings, 0 replies; 3+ messages in thread
From: David Woodhouse @ 2007-04-27 22:35 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-mtd, linux-kernel
On Fri, 2007-04-27 at 01:47 +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make 2 needlessly global functions static
> - #if 0 the unused nettel_eraseconfig()
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
For obvious reasons I'll apply this only if approved by the owner of the
map driver in question.
--
dwmw2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC: 2.6 patch] drivers/mtd/maps/nettel.c: possible cleanups
@ 2007-03-27 1:02 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2007-03-27 1:02 UTC (permalink / raw)
To: dwmw2; +Cc: linux-mtd, linux-kernel
This patch contains the following possible cleanups:
- make 2 needlessly global functions static
- #if 0 the unused nettel_eraseconfig()
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/mtd/maps/nettel.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc4-mm1/drivers/mtd/maps/nettel.c.old 2007-03-26 16:04:25.000000000 +0200
+++ linux-2.6.21-rc4-mm1/drivers/mtd/maps/nettel.c 2007-03-26 16:09:39.000000000 +0200
@@ -158,6 +158,8 @@
nettel_reboot_notifier, NULL, 0
};
+#if 0
+
/*
* Erase the configuration file system.
* Used to support the software reset button.
@@ -208,18 +210,22 @@
return(0);
}
+#endif /* 0 */
+
#else
+#if 0
int nettel_eraseconfig(void)
{
return(0);
}
+#endif /* 0 */
#endif
/****************************************************************************/
-int __init nettel_init(void)
+static int __init nettel_init(void)
{
volatile unsigned long *amdpar;
unsigned long amdaddr, maxsize;
@@ -477,7 +483,7 @@
/****************************************************************************/
-void __exit nettel_cleanup(void)
+static void __exit nettel_cleanup(void)
{
#ifdef CONFIG_MTD_CFI_INTELEXT
unregister_reboot_notifier(&nettel_notifier_block);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-27 22:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-26 23:47 [RFC: 2.6 patch] drivers/mtd/maps/nettel.c: possible cleanups Adrian Bunk
2007-04-27 22:35 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2007-03-27 1:02 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).