LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: Len Brown <lenb@kernel.org>
Cc: Richard Knutsson <ricknu-0@student.ltu.se>,
	Ben Collins <bcollins@ubuntu.com>,
	linux-acpi@vger.kernel.org, Stelian Pop <stelian@popies.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sonypi: Fix initialization warning
Date: Wed, 08 Aug 2007 09:20:07 +0200	[thread overview]
Message-ID: <1186557607.8780.85.camel@queen.suse.de> (raw)
In-Reply-To: <200708071507.33141.lenb@kernel.org>

On Tue, 2007-08-07 at 15:07 -0400, Len Brown wrote:
> On Sunday 05 August 2007 16:03, Richard Knutsson wrote:
> > Thomas Renninger wrote:
> > > On Sun, 2007-08-05 at 21:05 +0200, Richard Knutsson wrote:
> > >   
> > >> Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
> > >> ---
> > >> Got this from the compiler (gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)):
> > >> drivers/char/sonypi.c:1153: warning: initialization from incompatible pointer type
> > >>
> > >>
> > >> diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c
> > >> index 73037a4..2dcd519 100644
> > >> --- a/drivers/char/sonypi.c
> > >> +++ b/drivers/char/sonypi.c
> > >> @@ -1147,10 +1147,15 @@ static int sonypi_acpi_remove(struct acpi_device *device, int type)
> > >>  	return 0;
> > >>  }
> > >>  
> > >> +static const struct acpi_device_id sonypi_acpi_driver_ids[] = {
> > >> +        {ACPI_PROCESSOR_HID, 0},
> > >>     
> > > This is wrong. You need to take the HID the driver should match for, in
> > > this case: {"SNY6001", 0 },
> > >   
> 
> like this?
> 
> http://git.kernel.org/?p=linux/kernel/git/lenb/linux-acpi-2.6.git;a=commitdiff;h=f7b88ccb63188e775fe02e746c39ed177741cfc7;hp=11604ecf6fb9c2ab0152fbddb7ea2724438ef76e
> 
> http://marc.info/?l=linux-acpi&m=118618043526395&w=2

Yes.

Thanks,

    Thomas


      reply	other threads:[~2007-08-08  7:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-05 19:05 Richard Knutsson
2007-08-05 19:50 ` Thomas Renninger
2007-08-05 20:03   ` Richard Knutsson
2007-08-07 19:07     ` Len Brown
2007-08-08  7:20       ` Thomas Renninger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1186557607.8780.85.camel@queen.suse.de \
    --to=trenn@suse.de \
    --cc=bcollins@ubuntu.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricknu-0@student.ltu.se \
    --cc=stelian@popies.net \
    --subject='Re: [PATCH] sonypi: Fix initialization warning' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).