LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matt Reimer <mreimer@vpop.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Philipp Zabel <philipp.zabel@gmail.com>,
	linux-kernel@vger.kernel.org, johnpol@2ka.mipt.ru,
	szabolcs.gyurko@tlt.hu
Subject: Re: [PATCH] DS1WM: decouple host IRQ and INTR active state settings.
Date: Mon, 07 Jan 2008 16:13:23 -0800	[thread overview]
Message-ID: <1199751203.26310.64.camel@bilbo.vpop.net> (raw)
In-Reply-To: <20080107151022.82901fcc.akpm@linux-foundation.org>

On Mon, 2008-01-07 at 15:10 -0800, Andrew Morton wrote:
> On Sun, 06 Jan 2008 14:46:14 +0100
> Philipp Zabel <philipp.zabel@gmail.com> wrote:
> 
> > The DS1WM driver incorrectly infers the IAS bit (1-wire interrupt active
> > high) from IRQ settings. There are devices that have IAS=0 but still need
> > the IRQ to trigger on a rising edge. With this patch, machines with DS1WM
> > that need IAS=1 have to set .active_high=1 in the ds1wm_platform_data.

> But no drivers are converted to set ds1wm_platform_data.active_high.  Won't
> IORESOURCE_IRQ_HIGHEDGE devices be broken by this change?

Good point; I think you're right. I'd guess the other platforms that use
this driver are in the handhelds.org tree, but I've been out of the loop
a while. Philipp, is this the case?

Matt


  reply	other threads:[~2008-01-08  0:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-06 13:46 Philipp Zabel
2008-01-07 15:41 ` Evgeniy Polyakov
2008-01-07 20:04 ` Matt Reimer
2008-01-07 23:10 ` Andrew Morton
2008-01-08  0:13   ` Matt Reimer [this message]
2008-01-08  8:21     ` pHilipp Zabel
2008-02-06  7:26       ` Andrew Morton
2008-02-06 14:35         ` pHilipp Zabel
2008-02-06 18:01           ` Andrew Morton
2008-02-06 18:19             ` Matt Reimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199751203.26310.64.camel@bilbo.vpop.net \
    --to=mreimer@vpop.net \
    --cc=akpm@linux-foundation.org \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.zabel@gmail.com \
    --cc=szabolcs.gyurko@tlt.hu \
    --subject='Re: [PATCH] DS1WM: decouple host IRQ and INTR active state settings.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).