LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] scripts/decode_stacktrace: Look for modules with .ko.debug extension
@ 2019-05-21 23:41 Nicolas Boichat
  2019-05-28  8:38 ` Konstantin Khlebnikov
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Boichat @ 2019-05-21 23:41 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Marc Zyngier, Konstantin Khlebnikov, Nicolas Boichat, linux-kernel

In Chromium OS kernel builds, we split the debug information as
.ko.debug files, and that's what decode_stacktrace.sh needs to use.

Relax objfile matching rule to allow any .ko* file to be matched.

Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
---
 scripts/decode_stacktrace.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
index bcdd45df3f5127a..c851c1eb16f9cf7 100755
--- a/scripts/decode_stacktrace.sh
+++ b/scripts/decode_stacktrace.sh
@@ -28,7 +28,7 @@ parse_symbol() {
 		local objfile=${modcache[$module]}
 	else
 		[[ $modpath == "" ]] && return
-		local objfile=$(find "$modpath" -name $module.ko -print -quit)
+		local objfile=$(find "$modpath" -name $module.ko* -print -quit)
 		[[ $objfile == "" ]] && return
 		modcache[$module]=$objfile
 	fi
-- 
2.21.0.1020.gf2820cf01a-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scripts/decode_stacktrace: Look for modules with .ko.debug extension
  2019-05-21 23:41 [PATCH] scripts/decode_stacktrace: Look for modules with .ko.debug extension Nicolas Boichat
@ 2019-05-28  8:38 ` Konstantin Khlebnikov
  2019-05-28 10:28   ` Nicolas Boichat
  0 siblings, 1 reply; 3+ messages in thread
From: Konstantin Khlebnikov @ 2019-05-28  8:38 UTC (permalink / raw)
  To: Nicolas Boichat, Andrew Morton; +Cc: Marc Zyngier, linux-kernel

On 22.05.2019 2:41, Nicolas Boichat wrote:
> In Chromium OS kernel builds, we split the debug information as
> .ko.debug files, and that's what decode_stacktrace.sh needs to use.
> 
> Relax objfile matching rule to allow any .ko* file to be matched.
> 
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
>   scripts/decode_stacktrace.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> index bcdd45df3f5127a..c851c1eb16f9cf7 100755
> --- a/scripts/decode_stacktrace.sh
> +++ b/scripts/decode_stacktrace.sh
> @@ -28,7 +28,7 @@ parse_symbol() {
>   		local objfile=${modcache[$module]}
>   	else
>   		[[ $modpath == "" ]] && return
> -		local objfile=$(find "$modpath" -name $module.ko -print -quit)
> +		local objfile=$(find "$modpath" -name $module.ko* -print -quit)

Ok but should be quoted "$module.ko*" or escaped $module.ko\*

>   		[[ $objfile == "" ]] && return
>   		modcache[$module]=$objfile
>   	fi
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scripts/decode_stacktrace: Look for modules with .ko.debug extension
  2019-05-28  8:38 ` Konstantin Khlebnikov
@ 2019-05-28 10:28   ` Nicolas Boichat
  0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Boichat @ 2019-05-28 10:28 UTC (permalink / raw)
  To: Konstantin Khlebnikov; +Cc: Andrew Morton, Marc Zyngier, lkml

On Tue, May 28, 2019 at 4:38 PM Konstantin Khlebnikov
<khlebnikov@yandex-team.ru> wrote:
>
> On 22.05.2019 2:41, Nicolas Boichat wrote:
> > In Chromium OS kernel builds, we split the debug information as
> > .ko.debug files, and that's what decode_stacktrace.sh needs to use.
> >
> > Relax objfile matching rule to allow any .ko* file to be matched.
> >
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
> >   scripts/decode_stacktrace.sh | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
> > index bcdd45df3f5127a..c851c1eb16f9cf7 100755
> > --- a/scripts/decode_stacktrace.sh
> > +++ b/scripts/decode_stacktrace.sh
> > @@ -28,7 +28,7 @@ parse_symbol() {
> >               local objfile=${modcache[$module]}
> >       else
> >               [[ $modpath == "" ]] && return
> > -             local objfile=$(find "$modpath" -name $module.ko -print -quit)
> > +             local objfile=$(find "$modpath" -name $module.ko* -print -quit)
>
> Ok but should be quoted "$module.ko*" or escaped $module.ko\*

Thanks for noticing, will send a v2 right away.

> >               [[ $objfile == "" ]] && return
> >               modcache[$module]=$objfile
> >       fi
> >

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-28 10:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21 23:41 [PATCH] scripts/decode_stacktrace: Look for modules with .ko.debug extension Nicolas Boichat
2019-05-28  8:38 ` Konstantin Khlebnikov
2019-05-28 10:28   ` Nicolas Boichat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).