LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] serverworks: IRQ routing needs no _p
@ 2008-01-11 18:14 Alan Cox
  2008-01-11 23:22 ` Zachary Amsden
  2008-01-14 15:52 ` Ingo Molnar
  0 siblings, 2 replies; 3+ messages in thread
From: Alan Cox @ 2008-01-11 18:14 UTC (permalink / raw)
  To: akpm, linux-kernel, mingo

I can find no reason for the _p on the serverworks IRQ routing logic, and
a review of the documentation contains no indication that any such delay
is needed so lets try this

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc6-mm1/arch/x86/pci/irq.c linux-2.6.24-rc6-mm1/arch/x86/pci/irq.c
--- linux.vanilla-2.6.24-rc6-mm1/arch/x86/pci/irq.c	2008-01-02 16:04:19.000000000 +0000
+++ linux-2.6.24-rc6-mm1/arch/x86/pci/irq.c	2008-01-11 15:21:17.000000000 +0000
@@ -461,14 +461,14 @@
  */
 static int pirq_serverworks_get(struct pci_dev *router, struct pci_dev *dev, int pirq)
 {
-	outb_p(pirq, 0xc00);
+	outb(pirq, 0xc00);
 	return inb(0xc01) & 0xf;
 }
 
 static int pirq_serverworks_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
 {
-	outb_p(pirq, 0xc00);
-	outb_p(irq, 0xc01);
+	outb(pirq, 0xc00);
+	outb(irq, 0xc01);
 	return 1;
 }
 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] serverworks: IRQ routing needs no _p
  2008-01-11 18:14 [PATCH] serverworks: IRQ routing needs no _p Alan Cox
@ 2008-01-11 23:22 ` Zachary Amsden
  2008-01-14 15:52 ` Ingo Molnar
  1 sibling, 0 replies; 3+ messages in thread
From: Zachary Amsden @ 2008-01-11 23:22 UTC (permalink / raw)
  To: Alan Cox; +Cc: akpm, linux-kernel, mingo

On Fri, 2008-01-11 at 18:14 +0000, Alan Cox wrote:
> I can find no reason for the _p on the serverworks IRQ routing logic, and
> a review of the documentation contains no indication that any such delay
> is needed so lets try this
> 

Looks good to me; unfortunately my Serverworks boxes got upgraded so I
can't test, but install base is really big.

Acked-by: Zachary Amsden <zach@vmware.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] serverworks: IRQ routing needs no _p
  2008-01-11 18:14 [PATCH] serverworks: IRQ routing needs no _p Alan Cox
  2008-01-11 23:22 ` Zachary Amsden
@ 2008-01-14 15:52 ` Ingo Molnar
  1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-01-14 15:52 UTC (permalink / raw)
  To: Alan Cox; +Cc: akpm, linux-kernel, mingo


* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> I can find no reason for the _p on the serverworks IRQ routing logic, 
> and a review of the documentation contains no indication that any such 
> delay is needed so lets try this

thanks, applied to x86.git.

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-14 15:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-11 18:14 [PATCH] serverworks: IRQ routing needs no _p Alan Cox
2008-01-11 23:22 ` Zachary Amsden
2008-01-14 15:52 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).