LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Johannes Weiner <hannes@saeurebad.de>
To: linux-kernel@vger.kernel.org
Cc: ibm-acpi@hmh.eng.br, Johannes Weiner <hannes@saeurebad.de>
Subject: [PATCH] thinkpad_acpi: Remove superfluous prototypes from internal header
Date: Wed, 16 Jan 2008 14:01:43 +0100	[thread overview]
Message-ID: <1200488504-6789-2-git-send-email-hannes@saeurebad.de> (raw)
In-Reply-To: <1200488504-6789-1-git-send-email-hannes@saeurebad.de>

The helper functions are defined at the top of the C file so they are
known within the definition of the callsites below anyway.

Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
---
 drivers/misc/thinkpad_acpi.h |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/drivers/misc/thinkpad_acpi.h b/drivers/misc/thinkpad_acpi.h
index 8fba2bb..afaeb82 100644
--- a/drivers/misc/thinkpad_acpi.h
+++ b/drivers/misc/thinkpad_acpi.h
@@ -115,13 +115,6 @@ static const char *str_supported(int is_supported);
 /* ACPI HIDs */
 #define IBM_HKEY_HID    "IBM0068"
 
-/* ACPI helpers */
-static int __must_check acpi_evalf(acpi_handle handle,
-		      void *res, char *method, char *fmt, ...);
-static int __must_check acpi_ec_read(int i, u8 * p);
-static int __must_check acpi_ec_write(int i, u8 v);
-static int __must_check _sta(acpi_handle handle);
-
 /* ACPI handles */
 static acpi_handle root_handle;			/* root namespace */
 static acpi_handle ec_handle;			/* EC */
@@ -135,9 +128,6 @@ static void drv_acpi_handle_init(char *name,
 	drv_acpi_handle_init(#object, &object##_handle, *object##_parent,	\
 		object##_paths, ARRAY_SIZE(object##_paths), &object##_path)
 
-/* ThinkPad ACPI helpers */
-static int issue_thinkpad_cmos_command(int cmos_cmd);
-
 /* procfs support */
 static struct proc_dir_entry *proc_dir;
 
-- 
1.5.3.8


  reply	other threads:[~2008-01-16 13:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16 13:01 thinkpad_acpi: define _sta only when needed Johannes Weiner
2008-01-16 13:01 ` Johannes Weiner [this message]
2008-01-16 13:01   ` [PATCH] thinkpad_acpi: Define _sta() only when there are callsites Johannes Weiner
2008-01-16 19:14     ` Henrique de Moraes Holschuh
2008-01-16 19:13   ` [PATCH] thinkpad_acpi: Remove superfluous prototypes from internal header Henrique de Moraes Holschuh
2008-01-16 19:13 ` thinkpad_acpi: define _sta only when needed Henrique de Moraes Holschuh
2008-01-16 21:10   ` Johannes Weiner
2008-01-16 21:54     ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200488504-6789-2-git-send-email-hannes@saeurebad.de \
    --to=hannes@saeurebad.de \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).