LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Johannes Weiner <hannes@saeurebad.de> To: linux-kernel@vger.kernel.org Cc: ibm-acpi@hmh.eng.br, Johannes Weiner <hannes@saeurebad.de> Subject: [PATCH] thinkpad_acpi: Define _sta() only when there are callsites Date: Wed, 16 Jan 2008 14:01:44 +0100 [thread overview] Message-ID: <1200488504-6789-3-git-send-email-hannes@saeurebad.de> (raw) In-Reply-To: <1200488504-6789-2-git-send-email-hannes@saeurebad.de> With configs where neither the dock nor the bay subdriver is enabled, _sta() is defined but never used. Define it conditionally. Signed-off-by: Johannes Weiner <hannes@saeurebad.de> --- drivers/misc/thinkpad_acpi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c index cf56647..d5ac8b7 100644 --- a/drivers/misc/thinkpad_acpi.c +++ b/drivers/misc/thinkpad_acpi.c @@ -293,6 +293,7 @@ static int acpi_ec_write(int i, u8 v) return 1; } +#if defined(CONFIG_THINKPAD_ACPI_DOCK) || defined(CONFIG_THINKPAD_ACPI_DOCK) static int _sta(acpi_handle handle) { int status; @@ -302,6 +303,7 @@ static int _sta(acpi_handle handle) return status; } +#endif static int issue_thinkpad_cmos_command(int cmos_cmd) { -- 1.5.3.8
next prev parent reply other threads:[~2008-01-16 13:01 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-01-16 13:01 thinkpad_acpi: define _sta only when needed Johannes Weiner 2008-01-16 13:01 ` [PATCH] thinkpad_acpi: Remove superfluous prototypes from internal header Johannes Weiner 2008-01-16 13:01 ` Johannes Weiner [this message] 2008-01-16 19:14 ` [PATCH] thinkpad_acpi: Define _sta() only when there are callsites Henrique de Moraes Holschuh 2008-01-16 19:13 ` [PATCH] thinkpad_acpi: Remove superfluous prototypes from internal header Henrique de Moraes Holschuh 2008-01-16 19:13 ` thinkpad_acpi: define _sta only when needed Henrique de Moraes Holschuh 2008-01-16 21:10 ` Johannes Weiner 2008-01-16 21:54 ` Henrique de Moraes Holschuh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1200488504-6789-3-git-send-email-hannes@saeurebad.de \ --to=hannes@saeurebad.de \ --cc=ibm-acpi@hmh.eng.br \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).