LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bryan Wu <bryan.wu@analog.com>
To: jeff@garzik.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Alexey Demin <bf53x@ya.ru>,
	Bryan Wu <bryan.wu@analog.com>
Subject: [PATCH 7/8] [Blackfin] EMAC driver: fix bug - invalidate data cache of new_skb->data range when cache is WB
Date: Wed, 30 Jan 2008 16:52:27 +0800	[thread overview]
Message-ID: <1201683148-23931-8-git-send-email-bryan.wu@analog.com> (raw)
In-Reply-To: <1201683148-23931-1-git-send-email-bryan.wu@analog.com>

From: Alexey Demin <bf53x@ya.ru>

It prevents overwritting new data from DMA.

Signed-off-by: Alexey Demin <bf53x@ya.ru>
Signed-off-by: Bryan Wu <bryan.wu@analog.com>
---
 drivers/net/bfin_mac.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
index f2368b7..0a17fb4 100644
--- a/drivers/net/bfin_mac.c
+++ b/drivers/net/bfin_mac.c
@@ -651,6 +651,12 @@ static void bf537mac_rx(struct net_device *dev)
 	current_rx_ptr->skb = new_skb;
 	current_rx_ptr->desc_a.start_addr = (unsigned long)new_skb->data - 2;
 
+	/* Invidate the data cache of skb->data range when it is write back
+	 * cache. It will prevent overwritting the new data from DMA
+	 */
+	blackfin_dcache_invalidate_range((unsigned long)new_skb->head,
+					 (unsigned long)new_skb->end);
+
 	len = (unsigned short)((current_rx_ptr->status.status_word) & RX_FRLEN);
 	skb_put(skb, len);
 	blackfin_dcache_invalidate_range((unsigned long)skb->head,
-- 
1.5.3.4

  parent reply	other threads:[~2008-01-30  8:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30  8:52 [PATCH 0/8] [Blackfin] EMAC driver updates Bryan Wu
2008-01-30  8:52 ` [PATCH 1/8] [Blackfin] EMAC driver: shorten the mdelay value to solve netperf performance issue Bryan Wu
2008-01-30  9:00   ` Jeff Garzik
2008-01-30  8:52 ` [PATCH 2/8] [Blackfin] EMAC driver: define MDC_CLK=2.5MHz and caculate mdc_div according to SCLK Bryan Wu
2008-01-30  8:52 ` [PATCH 3/8] [Blackfin] EMAC driver: bf537 MAC multicast hash filtering patch Bryan Wu
2008-01-30  8:52 ` [PATCH 4/8] [Blackfin] EMAC driver: use simpler comment headers and strip out information that is maintained in the scm's log Bryan Wu
2008-01-30  8:52 ` [PATCH 5/8] [Blackfin] EMAC driver: ADSP-BF52x arch/mach support Bryan Wu
2008-01-30  8:52 ` [PATCH 6/8] [Blackfin] EMAC driver: add power down mode Bryan Wu
2008-01-30  8:52 ` Bryan Wu [this message]
2008-01-30  8:52 ` [PATCH 8/8] [Blackfin] EMAC driver: Fix bug: The clock divisor is set to all ones at reset Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201683148-23931-8-git-send-email-bryan.wu@analog.com \
    --to=bryan.wu@analog.com \
    --cc=bf53x@ya.ru \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH 7/8] [Blackfin] EMAC driver: fix bug - invalidate data cache of new_skb->data range when cache is WB' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).