LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bryan Wu <bryan.wu@analog.com>
To: dbrownell@users.sourceforge.net, spi-devel-general@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org,
	Michael Hennerich <michael.hennerich@analog.com>,
	Bryan Wu <bryan.wu@analog.com>
Subject: [PATCH 1/6] [Blackfin] SPI driver: remove useless return status check in restore_state function pointed by Michael.
Date: Wed, 30 Jan 2008 17:13:36 +0800	[thread overview]
Message-ID: <1201684421-26124-2-git-send-email-bryan.wu@analog.com> (raw)
In-Reply-To: <1201684421-26124-1-git-send-email-bryan.wu@analog.com>

Cc: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Bryan Wu <bryan.wu@analog.com>
---
 drivers/spi/spi_bfin5xx.c |   15 ++-------------
 1 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c
index 7ef39a6..8fd1365 100644
--- a/drivers/spi/spi_bfin5xx.c
+++ b/drivers/spi/spi_bfin5xx.c
@@ -223,10 +223,9 @@ static void cs_deactive(struct driver_data *drv_data, struct chip_data *chip)
 #define MAX_SPI_SSEL	7
 
 /* stop controller and re-config current chip*/
-static int restore_state(struct driver_data *drv_data)
+static void restore_state(struct driver_data *drv_data)
 {
 	struct chip_data *chip = drv_data->cur_chip;
-	int ret = 0;
 
 	/* Clear status and disable clock */
 	write_STAT(drv_data, BIT_STAT_CLR);
@@ -239,13 +238,6 @@ static int restore_state(struct driver_data *drv_data)
 
 	bfin_spi_enable(drv_data);
 	cs_active(drv_data, chip);
-
-	if (ret)
-		dev_dbg(&drv_data->pdev->dev,
-			": request chip select number %d failed\n",
-			chip->chip_select_num);
-
-	return ret;
 }
 
 /* used to kick off transfer in rx mode */
@@ -978,10 +970,7 @@ static void pump_messages(struct work_struct *work)
 
 	/* Setup the SSP using the per chip configuration */
 	drv_data->cur_chip = spi_get_ctldata(drv_data->cur_msg->spi);
-	if (restore_state(drv_data)) {
-		spin_unlock_irqrestore(&drv_data->lock, flags);
-		return;
-	};
+	restore_state(drv_data);
 
 	list_del_init(&drv_data->cur_msg->queue);
 
-- 
1.5.3.4

  reply	other threads:[~2008-01-30  9:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30  9:13 [PATCH 0/6] [Blackfin] SPI driver updates Bryan Wu
2008-01-30  9:13 ` Bryan Wu [this message]
2008-01-30  9:13 ` [PATCH 2/6] [Blackfin] SPI driver: Use SPI device name to do gpio peripheral request Bryan Wu
2008-01-30 21:48   ` [spi-devel-general] " David Brownell
2008-01-31  3:12     ` Bryan Wu
2008-01-30  9:13 ` [PATCH 3/6] [Blackfin] SPI driver: fix bug - PBX cannot work with this SPI framework driver Bryan Wu
2008-01-30  9:13 ` [PATCH 4/6] [Blackfin] SPI driver: fix bug - SPI duplex operation can read a dummy byte at the first transfer Bryan Wu
2008-01-30  9:13 ` [PATCH 5/6] [Blackfin] SPI driver: Fix bug SPI_write should not return until complete bit is set Bryan Wu
2008-01-30  9:13 ` [PATCH 6/6] [Blackfin] SPI driver: use simpler comment headers and strip out information that is maintained in the scm's log Bryan Wu
2008-01-31 20:50 ` [spi-devel-general] [PATCH 0/6] [Blackfin] SPI driver updates David Brownell
2008-02-01  9:41   ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201684421-26124-2-git-send-email-bryan.wu@analog.com \
    --to=bryan.wu@analog.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    --subject='Re: [PATCH 1/6] [Blackfin] SPI driver: remove useless return status check in restore_state function pointed by Michael.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).