LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	isdn4linux@listserv.isdn4linux.de
Cc: Sam Ravnborg <sam@ravnborg.org>, Karsten Keil <kkeil@suse.de>,
	Jeff Garzik <jgarzik@pobox.com>
Subject: [PATCH] isdn: fix section mismatch warning in hfc_sx.c
Date: Fri,  1 Feb 2008 14:42:44 +0100	[thread overview]
Message-ID: <1201873364-13475-5-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20080201133838.GA13349@uranus.ravnborg.org>

Fix the following warning:
WARNING: drivers/isdn/hisax/built-in.o(.text+0x35818): Section mismatch in reference from the function hfcsx_card_msg() to the function .devinit.text:inithfcsx()

hfcsx_card_msg() may be called outside __devinit context.
Following the program logic is looks like the CARD_INIT branch
will only be taken under __devinit context but to be consistent
remove the __devinit annotation of inithfcsx() so we
do not mix non-__devinit and __devinit code.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Karsten Keil <kkeil@suse.de>
Cc: Jeff Garzik <jgarzik@pobox.com>
---
 drivers/isdn/hisax/hfc_sx.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/isdn/hisax/hfc_sx.c b/drivers/isdn/hisax/hfc_sx.c
index 4fd09d2..05482d2 100644
--- a/drivers/isdn/hisax/hfc_sx.c
+++ b/drivers/isdn/hisax/hfc_sx.c
@@ -1330,8 +1330,7 @@ hfcsx_bh(struct work_struct *work)
 /********************************/
 /* called for card init message */
 /********************************/
-static void __devinit
-inithfcsx(struct IsdnCardState *cs)
+static void inithfcsx(struct IsdnCardState *cs)
 {
 	cs->setstack_d = setstack_hfcsx;
 	cs->BC_Send_Data = &hfcsx_send_data;
-- 
1.5.4.rc3.14.g44397


  parent reply	other threads:[~2008-02-01 13:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 13:38 [PATCH 0/5] isdn: fix section mismatch warnings in isdn Sam Ravnborg
2008-02-01 13:42 ` [PATCH] isdn: fix section mismatch warnings from hisax_cs_setup_card Sam Ravnborg
2008-02-01 13:42 ` [PATCH] isdn: fix section mismatch warning for ISACVer Sam Ravnborg
2008-02-01 13:42 ` [PATCH] isdn: fix section mismatch warning in enpci_card_msg Sam Ravnborg
2008-02-08  2:20   ` David Miller
2008-02-08  5:58     ` Sam Ravnborg
2008-02-08  6:27       ` David Miller
2008-02-08 20:01         ` Sam Ravnborg
2008-02-01 13:42 ` [PATCH] isdn: fix section mismatch warnings in isac.c and isar.c Sam Ravnborg
2008-02-01 13:42 ` Sam Ravnborg [this message]
2008-02-01 13:46 ` [PATCH 0/5] isdn: fix section mismatch warnings in isdn Sam Ravnborg
2008-02-01 16:36 ` Jeff Garzik
2008-02-03 16:50 ` Karsten Keil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201873364-13475-5-git-send-email-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=jgarzik@pobox.com \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] isdn: fix section mismatch warning in hfc_sx.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).