LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Borislav Petkov <petkovbb@googlemail.com> To: <bzolnier@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Borislav Petkov <petkovbb@gmail.com> Subject: [PATCH 12/22] ide-tape: dump gcw fields on error in idetape_identify_device() Date: Mon, 4 Feb 2008 14:40:30 +0100 [thread overview] Message-ID: <1202132440-26648-13-git-send-email-petkovbb@gmail.com> (raw) In-Reply-To: <1202132440-26648-1-git-send-email-petkovbb@gmail.com> goes before "ide-tape: remove IDETAPE_DEBUG_INFO" patch in IDE quilt tree Cc: Borislav Petkov <bbpetkov@yahoo.de> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/ide-tape.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 1c4f94c..712c5df 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -3402,16 +3402,17 @@ static int idetape_identify_device (ide_drive_t *drive) /* Check that we can support this device */ - if (gcw.protocol !=2 ) - printk(KERN_ERR "ide-tape: Protocol is not ATAPI\n"); + if (gcw.protocol != 2) + printk(KERN_ERR "ide-tape: Protocol (0x%02x) is not ATAPI\n", + gcw.protocol); else if (gcw.device_type != 1) - printk(KERN_ERR "ide-tape: Device type is not set to tape\n"); + printk(KERN_ERR "ide-tape: Device type (0x%02x) is not set " + "to tape\n", gcw.device_type); else if (!gcw.removable) printk(KERN_ERR "ide-tape: The removable flag is not set\n"); else if (gcw.packet_size != 0) { - printk(KERN_ERR "ide-tape: Packet size is not 12 bytes long\n"); - if (gcw.packet_size == 1) - printk(KERN_ERR "ide-tape: Sorry, padding to 16 bytes is still not supported\n"); + printk(KERN_ERR "ide-tape: Packet size (0x%02x) is not 12 " + "bytes long\n", gcw.packet_size); } else return 1; return 0; -- 1.5.3.7
next prev parent reply other threads:[~2008-02-04 13:44 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-02-04 13:40 Borislav Petkov 2008-02-04 13:40 ` [PATCH 01/22] ide-tape: refactor the debug logging facility Borislav Petkov 2008-02-04 13:40 ` [PATCH 02/22] ide-tape: remove struct idetape_read_position_result_t Borislav Petkov 2008-02-05 1:23 ` Bartlomiej Zolnierkiewicz 2008-02-04 13:40 ` [PATCH 03/22] ide-tape: remove unreachable code chunk Borislav Petkov 2008-02-04 13:40 ` [PATCH 04/22] ide-tape: simplify code branching in the interrupt handler Borislav Petkov 2008-02-04 13:40 ` [PATCH 05/22] ide-tape: remove typedef idetape_chrdev_direction_t Borislav Petkov 2008-02-04 13:40 ` [PATCH 06/22] ide-tape: struct idetape_tape_t: remove unused members Borislav Petkov 2008-09-22 13:25 ` Sergei Shtylyov 2008-09-22 13:58 ` Boris Petkov 2008-09-22 15:50 ` Sergei Shtylyov 2008-02-04 13:40 ` [PATCH 07/22] ide-tape: struct idetape_tape_t: shorten member names v2 Borislav Petkov 2008-02-05 1:23 ` Bartlomiej Zolnierkiewicz 2008-02-05 4:47 ` Borislav Petkov 2008-02-04 13:40 ` [PATCH 08/22] ide-tape: remove packet command and struct request memory buffers Borislav Petkov 2008-02-04 13:40 ` [PATCH 09/22] ide-tape: remove idetape_increase_max_pipeline_stages() Borislav Petkov 2008-02-04 13:40 ` [PATCH 10/22] ide-tape: shorten some function names Borislav Petkov 2008-02-04 13:40 ` [PATCH 11/22] ide-tape: remove atomic test/set macros Borislav Petkov 2008-02-04 13:40 ` Borislav Petkov [this message] 2008-02-04 13:40 ` [PATCH 13/22] ide-tape: remove struct idetape_id_gcw Borislav Petkov 2008-02-04 13:40 ` [PATCH 14/22] ide-tape: cleanup and fix comments Borislav Petkov 2008-02-05 1:27 ` Bartlomiej Zolnierkiewicz 2008-02-04 13:40 ` [PATCH 15/22] ide-tape: remove unused "length" arg from idetape_create_read_buffer_cmd() Borislav Petkov 2008-02-04 13:40 ` [PATCH 16/22] ide-tape: include proper headers Borislav Petkov 2008-02-04 13:40 ` [PATCH 17/22] ide-tape: collect module-related macro calls at the end Borislav Petkov 2008-02-04 13:40 ` [PATCH 18/22] ide-tape: remove leftover OnStream support warning Borislav Petkov 2008-02-04 13:40 ` [PATCH 19/22] ide-tape: fix syntax error in idetape_identify_device() Borislav Petkov 2008-02-04 13:40 ` [PATCH 20/22] ide-tape: cleanup the remaining codestyle issues Borislav Petkov 2008-02-05 1:27 ` Bartlomiej Zolnierkiewicz 2008-02-04 13:40 ` [PATCH 21/22] ide-tape: bump minor driver version Borislav Petkov 2008-02-04 13:40 ` [PATCH 22/22] ide-tape: schedule driver for removal after 6 months in case it turns out Borislav Petkov 2008-02-05 1:20 ` ide-tape redux (was: Bartlomiej Zolnierkiewicz 2008-02-06 5:23 ` Borislav Petkov 2008-02-06 5:27 ` Borislav Petkov 2008-02-09 16:25 ` Bartlomiej Zolnierkiewicz 2008-02-09 19:42 ` [PATCH 1/2] ide-tape: move all struct and other defs at the top Borislav Petkov 2008-02-11 22:12 ` Bartlomiej Zolnierkiewicz 2008-02-09 16:25 ` ide-tape redux (was: Bartlomiej Zolnierkiewicz 2008-02-09 19:43 ` [PATCH 2/2] ide-tape: remove atomic test/set macros for packet commands Borislav Petkov 2008-02-11 22:12 ` Bartlomiej Zolnierkiewicz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1202132440-26648-13-git-send-email-petkovbb@gmail.com \ --to=petkovbb@googlemail.com \ --cc=bzolnier@gmail.com \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=petkovbb@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).