LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ipvs: Make wrr "no available servers" error message rate-limited
@ 2008-02-05 20:30 Sven Wegener
  2008-02-06  2:19 ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Sven Wegener @ 2008-02-05 20:30 UTC (permalink / raw)
  To: netdev; +Cc: linux-kernel

No available servers is more an error message than something informational. It
should also be rate-limited, else we're going to flood our logs on a busy
director, if all real servers are out of order with a weight of zero.

Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
---

Actually, do we need this message at all? The wrr scheduler is the only one
printing an error message in such a case.

 net/ipv4/ipvs/ip_vs_wrr.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/ipvs/ip_vs_wrr.c b/net/ipv4/ipvs/ip_vs_wrr.c
index 749fa04..85c680a 100644
--- a/net/ipv4/ipvs/ip_vs_wrr.c
+++ b/net/ipv4/ipvs/ip_vs_wrr.c
@@ -22,6 +22,7 @@
 
 #include <linux/module.h>
 #include <linux/kernel.h>
+#include <linux/net.h>
 
 #include <net/ip_vs.h>
 
@@ -169,7 +170,7 @@ ip_vs_wrr_schedule(struct ip_vs_service *svc, const struct sk_buff *skb)
 				 */
 				if (mark->cw == 0) {
 					mark->cl = &svc->destinations;
-					IP_VS_INFO("ip_vs_wrr_schedule(): "
+					IP_VS_ERR_RL("ip_vs_wrr_schedule(): "
 						   "no available servers\n");
 					dest = NULL;
 					goto out;
-- 
1.5.3.7


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-06  4:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-05 20:30 [PATCH] ipvs: Make wrr "no available servers" error message rate-limited Sven Wegener
2008-02-06  2:19 ` Simon Horman
2008-02-06  4:00   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).