LKML Archive on
help / color / mirror / Atom feed
From: Harvey Harrison <>
To: Ingo Molnar <>
Cc: "H. Peter Anvin" <>,
	Thomas Gleixner <>,
	LKML <>
Subject: [PATCH 2/3] x86: sparse warning in efi.c
Date: Wed, 06 Feb 2008 16:07:48 -0800	[thread overview]
Message-ID: <1202342868.5820.90.camel@brick> (raw)

arch/x86/kernel/efi.c:57:12: warning: symbol 'efi_phys' was not declared. Should it be static?

Yes, it should.

Signed-off-by: Harvey Harrison <>
 arch/x86/kernel/efi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/efi.c b/arch/x86/kernel/efi.c
index 32dd62b..43022d6 100644
--- a/arch/x86/kernel/efi.c
+++ b/arch/x86/kernel/efi.c
@@ -54,7 +54,7 @@ EXPORT_SYMBOL(efi);
 struct efi_memory_map memmap;
-struct efi efi_phys __initdata;
+static struct efi efi_phys __initdata;
 static efi_system_table_t efi_systab __initdata;
 static int __init setup_noefi(char *arg)

                 reply	other threads:[~2008-02-07  0:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202342868.5820.90.camel@brick \ \ \ \ \ \
    --subject='Re: [PATCH 2/3] x86: sparse warning in efi.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).