LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Badari Pulavarty <pbadari@us.ibm.com>
To: Greg KH <greg@kroah.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [-mm PATCH] sysdev_unregister() should call kobject_del()
Date: Thu, 07 Feb 2008 15:56:58 -0800	[thread overview]
Message-ID: <1202428618.26309.45.camel@dyn9047017100.beaverton.ibm.com> (raw)

Hi Greg,

While playing with hotplug memory remove on 2.6.24-mm1, I 
noticed that /sysfs directory entries are not getting removed.

sysdev_unregister() used to call kobject_unregister().
But in 2.6.24-mm1, its only dropping the ref. It should
call kobject_del() to remove the object. Correct ?

With this change, the directories are getting removed
correctly. Comments ?

Thanks,
Badari

sysdev_unregister() should call kobject_del() to remove
the object.

Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>
---
 drivers/base/sys.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6.24/drivers/base/sys.c
===================================================================
--- linux-2.6.24.orig/drivers/base/sys.c	2008-02-05 09:56:56.000000000 -0800
+++ linux-2.6.24/drivers/base/sys.c	2008-02-07 15:38:17.000000000 -0800
@@ -265,6 +265,7 @@ void sysdev_unregister(struct sys_device
 	}
 	mutex_unlock(&sysdev_drivers_lock);
 
+	kobject_del(&sysdev->kobj);
 	kobject_put(&sysdev->kobj);
 }
 



             reply	other threads:[~2008-02-07 23:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 23:56 Badari Pulavarty [this message]
2008-02-08  0:38 ` Greg KH
2008-02-08  1:25   ` Badari Pulavarty
2008-02-08  4:55     ` Greg KH
2008-02-08  5:08       ` Badari Pulavarty
2008-02-08  5:41         ` Greg KH
2008-02-08 16:42           ` Badari Pulavarty
2008-02-08 21:30             ` Dave Hansen
2008-02-08 23:22       ` Badari Pulavarty
2008-02-08 23:57         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202428618.26309.45.camel@dyn9047017100.beaverton.ibm.com \
    --to=pbadari@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [-mm PATCH] sysdev_unregister() should call kobject_del()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).