LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Marcin Juszkiewicz <openembedded@haerwu.biz>,
	Christoph Hellwig <hch@infradead.org>, Greg KH <greg@kroah.com>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture
Date: Fri, 08 Feb 2008 09:04:13 +0000	[thread overview]
Message-ID: <1202461453.5469.217.camel@pmac.infradead.org> (raw)
In-Reply-To: <20080207202329.GA21949@uranus.ravnborg.org>


On Thu, 2008-02-07 at 21:23 +0100, Sam Ravnborg wrote:
> Both situations are trivially fixable by introducing
> HAVE_IDE and HAVE_MTD.
> See attached patch.

HAVE_MTD is wrong. The actual problem we're trying to solve is that when
the architecture lacks alignment fixups, certain patterns of write
access to 16-bit or 32-bit NOR flash arrays are broken. So it's not
'MTD' which should be conditional -- but only certain configurations of
NOR flash, which could perhaps be prevented by disallowing any of the
MTD_MAP_BANK_WIDTH_* options other than MTD_MAP_BANK_WIDTH_1 from being
set.

And it's not just an ARM-specific problem; a number of our MMU-less
architectures also lack alignment traps now. It _used_ to be the case
that platforms without alignment fixups were simply considered to be
broken -- if the hardware didn't support unaligned access, either
natively or through traps, it just wasn't supported by Linux. But since
that isn't really the case any more, perhaps we should seek a better
option than just disabling certain functionality (or _not_ disabling it,
in the case of the network stack, and just kind of praying that it works
even though we don't really think it does).

We could add get_unaligned() in certain places in the code, but that
isn't ideal for the majority of architectures. What we really want, I
suppose, is get_something_which_may_be_but_probably_is_not_unaligned().

With a better name.

-- 
dwmw2


  parent reply	other threads:[~2008-02-08  9:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 12:38 Hans-Jürgen Koch
2008-02-07 12:58 ` Christoph Hellwig
2008-02-07 13:01   ` Sam Ravnborg
2008-02-07 15:09     ` Marcin Juszkiewicz
2008-02-07 16:05       ` Russell King - ARM Linux
2008-02-07 20:23         ` Sam Ravnborg
2008-02-07 20:29           ` Russell King - ARM Linux
2008-02-07 21:05             ` Sam Ravnborg
2008-02-08  9:04           ` David Woodhouse [this message]
2008-02-08  9:45             ` Russell King - ARM Linux
2008-02-08 10:18               ` David Woodhouse
2008-02-08 10:23                 ` Russell King - ARM Linux
2008-02-08 10:43                   ` David Woodhouse
2008-02-08 10:45                     ` Russell King - ARM Linux
2008-02-12  1:51                       ` Greg Ungerer
2008-02-08 10:58             ` David Woodhouse
2008-02-08 18:46               ` Sam Ravnborg
2008-02-08 18:52                 ` David Woodhouse
2008-02-09 11:39           ` Sam Ravnborg
2008-02-07 14:21   ` Russell King - ARM Linux
2008-02-07 13:02 ` Russell King - ARM Linux
2008-02-07 13:12   ` Hans-Jürgen Koch
2008-02-11  8:25     ` Hans-Jürgen Koch
2008-02-11 14:39       ` Sam Ravnborg
2008-04-10 12:21       ` Uwe Kleine-König
2008-04-10 12:27         ` Russell King - ARM Linux
2008-04-10 12:57           ` Uwe Kleine-König
2008-04-10 13:10             ` Russell King - ARM Linux
2008-04-10 13:50               ` Uwe Kleine-König
2008-04-10 18:58           ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202461453.5469.217.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=greg@kroah.com \
    --cc=hch@infradead.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=openembedded@haerwu.biz \
    --cc=sam@ravnborg.org \
    --subject='Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).