LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: CONFIG_HIGHPTE vs. sub-page page tables.
Date: Sat, 09 Feb 2008 11:56:14 +0100	[thread overview]
Message-ID: <1202554574.8936.15.camel@localhost> (raw)
In-Reply-To: <20080209103728.GA29375@elte.hu>

On Sat, 2008-02-09 at 11:37 +0100, Ingo Molnar wrote:
> i think the worst is over already and i'm reasonably sure that there are 
> no more bugs in it - this _is_ a 1:1 patch after all, so in theory the 
> worst side-effect should be build breakages due to include file 
> spaghetti. The window for this particular breakage was just 256 commits, 
> that's OK i think.

Except for the breakage of all nommu architectures .. they need the
pgtable_t as well due to the pte_fn_t type.

> If you want less stress next time around you might want to consider 
> pushing such patches via individual architectures, so that it can all be 
> shaken out (and such build bugs are found quickly) and pushed via the 
> architecture trees. (Even such a patch that changes the number of 
> cross-arch function arguments and introduces a new type can be 
> architectured in a way to make it per arch.)

I'll try that with the __pte_free_tlb macro to inline conversion patch.
This one is really driving me nuts, the dependencies of the macros in
asm/pgalloc, asm/tlb.h and asm-generic/tlb.h for the different archs are
pure evil.

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.



  reply	other threads:[~2008-02-09 10:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200802081902.m18J2nOm005840@hera.kernel.org>
2008-02-08 23:04 ` Ingo Molnar
2008-02-08 23:15   ` Ingo Molnar
2008-02-09 10:06     ` Martin Schwidefsky
2008-02-09 10:37       ` Ingo Molnar
2008-02-09 10:56         ` Martin Schwidefsky [this message]
2008-02-09 17:56           ` Mike Frysinger
2008-02-10  9:17             ` Martin Schwidefsky
2008-02-10  9:25               ` Mike Frysinger
2008-02-10  9:41                 ` Martin Schwidefsky
2008-02-10 10:06                   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202554574.8936.15.camel@localhost \
    --to=schwidefsky@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: CONFIG_HIGHPTE vs. sub-page page tables.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).