LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>,
	greg@kroah.com, linux-mm <linux-mm@kvack.org>
Subject: Re: [-mm PATCH] register_memory/unregister_memory clean ups
Date: Tue, 12 Feb 2008 13:57:14 -0800	[thread overview]
Message-ID: <1202853434.11188.76.camel@nimitz.home.sr71.net> (raw)
In-Reply-To: <1202853415.25604.59.camel@dyn9047017100.beaverton.ibm.com>


On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote:
> 
> +static void __remove_section(struct zone *zone, unsigned long
> section_nr)
> +{
> +       if (!valid_section_nr(section_nr))
> +               return;
> +
> +       unregister_memory_section(__nr_to_section(section_nr));
> +       sparse_remove_one_section(zone, section_nr);
> +}

I do think passing in a mem_section* here is highly superior.  It makes
it impossible to pass a pfn in and not get a warning.

-- Dave


  reply	other threads:[~2008-02-12 21:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 17:23 Badari Pulavarty
2008-02-11 17:54 ` Greg KH
2008-02-11 18:05   ` Badari Pulavarty
2008-02-11 19:48 ` Andrew Morton
2008-02-11 20:35   ` Greg KH
2008-02-11 21:32   ` Badari Pulavarty
2008-02-12  8:06     ` Yasunori Goto
2008-02-12 17:22       ` Badari Pulavarty
2008-02-12 20:59         ` Dave Hansen
2008-02-12 21:56           ` Badari Pulavarty
2008-02-12 21:57             ` Dave Hansen [this message]
2008-02-12 22:07               ` Badari Pulavarty
2008-02-12 22:15                 ` Dave Hansen
2008-02-12 22:51                   ` Badari Pulavarty
2008-02-12 23:03                   ` Badari Pulavarty
2008-02-12 23:20                     ` Dave Hansen
2008-02-12 22:06             ` Dave Hansen
2008-02-13  5:09               ` Yasunori Goto
2008-02-13 17:31                 ` Badari Pulavarty
2008-02-19 19:43 ` patch driver-core-register_memory-unregister_memory-clean-ups-and-bugfix.patch added to gregkh-2.6 tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202853434.11188.76.camel@nimitz.home.sr71.net \
    --to=haveblue@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pbadari@us.ibm.com \
    --cc=y-goto@jp.fujitsu.com \
    --subject='Re: [-mm PATCH] register_memory/unregister_memory clean ups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).