LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: marcin.slusarz@gmail.com
Cc: LKML <linux-kernel@vger.kernel.org>, cluster-devel@redhat.com
Subject: Re: [PATCH] gfs2: be*_add_cpu conversion
Date: Wed, 13 Feb 2008 09:55:33 +0000	[thread overview]
Message-ID: <1202896533.3862.0.camel@localhost.localdomain> (raw)
In-Reply-To: <1202857582-15450-6-git-send-email-marcin.slusarz@gmail.com>

Hi,

Now in the GFS2 -nmw git tree. Thanks,

Steve.

On Wed, 2008-02-13 at 00:06 +0100, marcin.slusarz@gmail.com wrote:
> From: Marcin Slusarz <marcin.slusarz@gmail.com>
> 
> replace all:
> big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) +
> 					expression_in_cpu_byteorder);
> with:
> 	beX_add_cpu(&big_endian_variable, expression_in_cpu_byteorder);
> generated with semantic patch
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> Cc: cluster-devel@redhat.com
> ---
>  fs/gfs2/dir.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
> index c347095..6f2e382 100644
> --- a/fs/gfs2/dir.c
> +++ b/fs/gfs2/dir.c
> @@ -1021,13 +1021,13 @@ static int dir_split_leaf(struct inode *inode, const struct qstr *name)
>  
>  			new->de_inum = dent->de_inum; /* No endian worries */
>  			new->de_type = dent->de_type; /* No endian worries */
> -			nleaf->lf_entries = cpu_to_be16(be16_to_cpu(nleaf->lf_entries)+1);
> +			be16_add_cpu(&nleaf->lf_entries, 1);
>  
>  			dirent_del(dip, obh, prev, dent);
>  
>  			if (!oleaf->lf_entries)
>  				gfs2_consist_inode(dip);
> -			oleaf->lf_entries = cpu_to_be16(be16_to_cpu(oleaf->lf_entries)-1);
> +			be16_add_cpu(&oleaf->lf_entries, -1);
>  
>  			if (!prev)
>  				prev = dent;
> @@ -1616,7 +1616,7 @@ int gfs2_dir_add(struct inode *inode, const struct qstr *name,
>  			dent->de_type = cpu_to_be16(type);
>  			if (ip->i_di.di_flags & GFS2_DIF_EXHASH) {
>  				leaf = (struct gfs2_leaf *)bh->b_data;
> -				leaf->lf_entries = cpu_to_be16(be16_to_cpu(leaf->lf_entries) + 1);
> +				be16_add_cpu(&leaf->lf_entries, 1);
>  			}
>  			brelse(bh);
>  			error = gfs2_meta_inode_buffer(ip, &bh);


  reply	other threads:[~2008-02-13  9:56 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 23:06 [PATCHSET] [bl]e*_add_cpu conversions marcin.slusarz
2008-02-12 23:06 ` [PATCH] crypto: be*_add_cpu conversion marcin.slusarz
2008-02-13  8:25   ` Roel Kluin
2008-02-13 18:36     ` Marcin Slusarz
2008-03-14  8:24       ` Herbert Xu
2008-02-12 23:06 ` [PATCH] ieee 1394: " marcin.slusarz
2008-02-16 16:54   ` Stefan Richter
2008-02-12 23:06 ` [PATCH] infiniband: " marcin.slusarz
2008-02-13  0:32   ` Roland Dreier
2008-02-12 23:06 ` [PATCH] affs: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] gfs2: " marcin.slusarz
2008-02-13  9:55   ` Steven Whitehouse [this message]
2008-02-12 23:06 ` [PATCH] hfs/hfsplus: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] ipw2200: le*_add_cpu conversion marcin.slusarz
2008-02-13 16:54   ` Chatre, Reinette
2008-02-12 23:06 ` [PATCH] scsi: " marcin.slusarz
2008-02-13 14:06   ` Salyzyn, Mark
2008-02-12 23:06 ` [PATCH] ext2: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] ext4: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] jfs: " marcin.slusarz
2008-02-13 21:51   ` Dave Kleikamp
2008-02-12 23:06 ` [PATCH] ntfs: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] ocfs2: " marcin.slusarz
2008-02-18 21:03   ` Mark Fasheh
2008-02-12 23:06 ` [PATCH] quota: " marcin.slusarz
2008-02-13  9:52   ` Jan Kara
2008-02-12 23:06 ` [PATCH] reiserfs: " marcin.slusarz
2008-02-12 23:06 ` [PATCH] sysv: [bl]e*_add_cpu conversion marcin.slusarz
2008-02-14  7:04   ` Christoph Hellwig
2008-02-16 13:31     ` Christoph Hellwig
2008-02-12 23:06 ` [PATCH] ufs: " marcin.slusarz
2008-02-13  9:41   ` Roel Kluin
2008-02-13 18:21     ` Marcin Slusarz
2008-02-16  5:28     ` Andrew Morton
2008-02-18 23:22       ` Roel Kluin
2008-02-19 17:45         ` Marcin Slusarz
2008-02-19 19:16           ` Evgeniy Dushistov
2008-03-09 10:21             ` Marcin Slusarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202896533.3862.0.camel@localhost.localdomain \
    --to=swhiteho@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --subject='Re: [PATCH] gfs2: be*_add_cpu conversion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).