LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2.6.24-rt1] SMC91x: Use special_lock when CONFIG_PREEMPT_[HARD|SOFT]IRQS
@ 2008-02-14 1:35 Kevin Hilman
2008-02-14 14:03 ` Nicolas Pitre
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Hilman @ 2008-02-14 1:35 UTC (permalink / raw)
To: linux-rt-users; +Cc: linux-kernel, Kevin Hilman
The smc_special_locks should also be used when either softIRQs or hard
IRQs are preempted which may lead to the same problems as under SMP.
Signed-off-by: Kevin Hilman <khilman@mvista.com>
---
drivers/net/smc91x.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index f198c49..be62616 100644
--- a/drivers/net/smc91x.c
+++ b/drivers/net/smc91x.c
@@ -530,7 +530,8 @@ static inline void smc_rcv(struct net_device *dev)
}
}
-#ifdef CONFIG_SMP
+#if defined(CONFIG_SMP) || \
+ defined(CONFIG_PREEMPT_SOFTIRQS) || defined(CONFIG_PREEMPT_HARDIRQS)
/*
* On SMP we have the following problem:
*
--
1.5.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.24-rt1] SMC91x: Use special_lock when CONFIG_PREEMPT_[HARD|SOFT]IRQS
2008-02-14 1:35 [PATCH 2.6.24-rt1] SMC91x: Use special_lock when CONFIG_PREEMPT_[HARD|SOFT]IRQS Kevin Hilman
@ 2008-02-14 14:03 ` Nicolas Pitre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Pitre @ 2008-02-14 14:03 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-rt-users, linux-kernel
On Wed, 13 Feb 2008, Kevin Hilman wrote:
> The smc_special_locks should also be used when either softIRQs or hard
> IRQs are preempted which may lead to the same problems as under SMP.
>
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
Acked-by: Nicolas Pitre <nico@cam.org>
>
> ---
> drivers/net/smc91x.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
> index f198c49..be62616 100644
> --- a/drivers/net/smc91x.c
> +++ b/drivers/net/smc91x.c
> @@ -530,7 +530,8 @@ static inline void smc_rcv(struct net_device *dev)
> }
> }
>
> -#ifdef CONFIG_SMP
> +#if defined(CONFIG_SMP) || \
> + defined(CONFIG_PREEMPT_SOFTIRQS) || defined(CONFIG_PREEMPT_HARDIRQS)
> /*
> * On SMP we have the following problem:
> *
> --
> 1.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Nicolas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-14 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-14 1:35 [PATCH 2.6.24-rt1] SMC91x: Use special_lock when CONFIG_PREEMPT_[HARD|SOFT]IRQS Kevin Hilman
2008-02-14 14:03 ` Nicolas Pitre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).