LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/3] sched: add declaration of sched_tail to sched.h
@ 2008-02-15 17:56 Harvey Harrison
  2008-02-17 16:33 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-02-15 17:56 UTC (permalink / raw)
  To: Ingo Molnar, Jeff Dike; +Cc: LKML

Avoids sparse warnings:
kernel/sched.c:2170:17: warning: symbol 'schedule_tail' was not declared. Should it be static?

Avoids the need for an external declaration in arch/um/process.c

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 arch/um/kernel/process.c |    2 --
 include/linux/sched.h    |    1 +
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/kernel/process.c b/arch/um/kernel/process.c
index fc50d2f..e8cb9ff 100644
--- a/arch/um/kernel/process.c
+++ b/arch/um/kernel/process.c
@@ -128,8 +128,6 @@ void *get_current(void)
 	return current;
 }
 
-extern void schedule_tail(struct task_struct *prev);
-
 /*
  * This is called magically, by its address being stuffed in a jmp_buf
  * and being longjmp-d to.
diff --git a/include/linux/sched.h b/include/linux/sched.h
index e217d18..f1d20c0 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -242,6 +242,7 @@ struct task_struct;
 
 extern void sched_init(void);
 extern void sched_init_smp(void);
+extern asmlinkage void schedule_tail(struct task_struct *prev);
 extern void init_idle(struct task_struct *idle, int cpu);
 extern void init_idle_bootup_task(struct task_struct *idle);
 
-- 
1.5.4.1.1278.gc75be



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/3] sched: add declaration of sched_tail to sched.h
  2008-02-15 17:56 [PATCH 1/3] sched: add declaration of sched_tail to sched.h Harvey Harrison
@ 2008-02-17 16:33 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-02-17 16:33 UTC (permalink / raw)
  To: Harvey Harrison; +Cc: Jeff Dike, LKML


* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> Avoids sparse warnings: kernel/sched.c:2170:17: warning: symbol 
> 'schedule_tail' was not declared. Should it be static?
> 
> Avoids the need for an external declaration in arch/um/process.c

thanks, applied.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-17 16:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-15 17:56 [PATCH 1/3] sched: add declaration of sched_tail to sched.h Harvey Harrison
2008-02-17 16:33 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).