LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 3/3] sched: fix signedness warnings in sched.c
@ 2008-02-15 17:56 Harvey Harrison
  2008-02-17 16:32 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-02-15 17:56 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: LKML

Unsigned long values are always assigned to switch_count,
make it unsigned long.

kernel/sched.c:3897:15: warning: incorrect type in assignment (different signedness)
kernel/sched.c:3897:15:    expected long *switch_count
kernel/sched.c:3897:15:    got unsigned long *<noident>
kernel/sched.c:3921:16: warning: incorrect type in assignment (different signedness)
kernel/sched.c:3921:16:    expected long *switch_count
kernel/sched.c:3921:16:    got unsigned long *<noident>

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 kernel/sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 824d5a9..0ddef83 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -3886,7 +3886,7 @@ pick_next_task(struct rq *rq, struct task_struct *prev)
 asmlinkage void __sched schedule(void)
 {
 	struct task_struct *prev, *next;
-	long *switch_count;
+	unsigned long *switch_count;
 	struct rq *rq;
 	int cpu;
 
-- 
1.5.4.1.1278.gc75be


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/3] sched: fix signedness warnings in sched.c
  2008-02-15 17:56 [PATCH 3/3] sched: fix signedness warnings in sched.c Harvey Harrison
@ 2008-02-17 16:32 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-02-17 16:32 UTC (permalink / raw)
  To: Harvey Harrison; +Cc: LKML


* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> Unsigned long values are always assigned to switch_count,
> make it unsigned long.
> 
> kernel/sched.c:3897:15: warning: incorrect type in assignment (different signedness)
> kernel/sched.c:3897:15:    expected long *switch_count
> kernel/sched.c:3897:15:    got unsigned long *<noident>
> kernel/sched.c:3921:16: warning: incorrect type in assignment (different signedness)
> kernel/sched.c:3921:16:    expected long *switch_count
> kernel/sched.c:3921:16:    got unsigned long *<noident>

thanks, applied.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-17 16:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-15 17:56 [PATCH 3/3] sched: fix signedness warnings in sched.c Harvey Harrison
2008-02-17 16:32 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).